From: Baoquan He <bhe@redhat.com>
To: kernel test robot <lkp@intel.com>
Cc: linux-kernel@vger.kernel.org, kbuild-all@lists.01.org,
linux-mm@kvack.org, akpm@linux-foundation.org, rppt@kernel.org,
david@redhat.com
Subject: Re: [PATCH v4 1/4] mm: rename memmap_init() and memmap_init_zone()
Date: Thu, 21 Jan 2021 16:17:27 +0800 [thread overview]
Message-ID: <20210121081727.GG20161@MiWiFi-R3L-srv> (raw)
In-Reply-To: <202101202302.EE9LLAFu-lkp@intel.com>
On 01/20/21 at 11:47pm, kernel test robot wrote:
> Hi Baoquan,
>
> I love your patch! Perhaps something to improve:
>
> [auto build test WARNING on linux/master]
> [also build test WARNING on linus/master v5.11-rc4 next-20210120]
> [cannot apply to mmotm/master hnaz-linux-mm/master ia64/next]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Baoquan-He/mm-clean-up-names-and-parameters-of-memmap_init_xxxx-functions/20210120-135239
> base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 1e2a199f6ccdc15cf111d68d212e2fd4ce65682e
> config: mips-randconfig-r036-20210120 (attached as .config)
> compiler: mips-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://github.com/0day-ci/linux/commit/1bbb0b35dd2fae4a7a38098e63899677c2e53108
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Baoquan-He/mm-clean-up-names-and-parameters-of-memmap_init_xxxx-functions/20210120-135239
> git checkout 1bbb0b35dd2fae4a7a38098e63899677c2e53108
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> mm/page_alloc.c:3597:15: warning: no previous prototype for 'should_fail_alloc_page' [-Wmissing-prototypes]
> 3597 | noinline bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order)
> | ^~~~~~~~~~~~~~~~~~~~~~
> >> mm/page_alloc.c:6258:23: warning: no previous prototype for 'memmap_init_zone' [-Wmissing-prototypes]
> 6258 | void __meminit __weak memmap_init_zone(unsigned long size, int nid,
This is not introduced by this patch, but existing issue, should
be not related to this patchset. I will investigate and see what we
should do with memmap_init_zone(), adding static or adding it to header
file, or just leave it as should_fail_alloc_page().
By the way, I tried to reproduce on a fedora 32 system of x86 arch, but
met below issue. could you help check what I can do to fix the error.
[root@dell-per710-01 linux]# COMPILER_INSTALL_PATH=~/0day COMPILER=gcc-9.3.0 ~/bin/make.cross ARCH=mips
Compiler will be installed in /root/0day
make W=1 CONFIG_OF_ALL_DTBS=y CONFIG_DTC=y CROSS_COMPILE=/root/0day/gcc-9.3.0-nolibc/mips-linux/bin/mips-linux- --jobs=16 ARCH=mips
HOSTCXX scripts/gcc-plugins/latent_entropy_plugin.so
HOSTCXX scripts/gcc-plugins/structleak_plugin.so
HOSTCXX scripts/gcc-plugins/randomize_layout_plugin.so
In file included from /root/0day/gcc-9.3.0-nolibc/mips-linux/bin/../lib/gcc/mips-linux/9.3.0/plugin/include/gcc-plugin.h:28,
from scripts/gcc-plugins/gcc-common.h:7,
from scripts/gcc-plugins/latent_entropy_plugin.c:78:
/root/0day/gcc-9.3.0-nolibc/mips-linux/bin/../lib/gcc/mips-linux/9.3.0/plugin/include/system.h:687:10: fatal error: gmp.h: No such file or directy
687 | #include <gmp.h>
| ^~~~~~~
compilation terminated.
make[2]: *** [scripts/gcc-plugins/Makefile:47: scripts/gcc-plugins/latent_entropy_plugin.so] Error 1
make[2]: *** Waiting for unfinished jobs..
Thanks
Baoquan
> | ^~~~~~~~~~~~~~~~
>
>
> vim +/memmap_init_zone +6258 mm/page_alloc.c
>
> 6257
> > 6258 void __meminit __weak memmap_init_zone(unsigned long size, int nid,
> 6259 unsigned long zone,
> 6260 unsigned long range_start_pfn)
> 6261 {
> 6262 unsigned long start_pfn, end_pfn;
> 6263 unsigned long range_end_pfn = range_start_pfn + size;
> 6264 int i;
> 6265
> 6266 for_each_mem_pfn_range(i, nid, &start_pfn, &end_pfn, NULL) {
> 6267 start_pfn = clamp(start_pfn, range_start_pfn, range_end_pfn);
> 6268 end_pfn = clamp(end_pfn, range_start_pfn, range_end_pfn);
> 6269
> 6270 if (end_pfn > start_pfn) {
> 6271 size = end_pfn - start_pfn;
> 6272 memmap_init_range(size, nid, zone, start_pfn, range_end_pfn,
> 6273 MEMINIT_EARLY, NULL, MIGRATE_MOVABLE);
> 6274 }
> 6275 }
> 6276 }
> 6277
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v4 1/4] mm: rename memmap_init() and memmap_init_zone()
Date: Thu, 21 Jan 2021 16:17:27 +0800 [thread overview]
Message-ID: <20210121081727.GG20161@MiWiFi-R3L-srv> (raw)
In-Reply-To: <202101202302.EE9LLAFu-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 4733 bytes --]
On 01/20/21 at 11:47pm, kernel test robot wrote:
> Hi Baoquan,
>
> I love your patch! Perhaps something to improve:
>
> [auto build test WARNING on linux/master]
> [also build test WARNING on linus/master v5.11-rc4 next-20210120]
> [cannot apply to mmotm/master hnaz-linux-mm/master ia64/next]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Baoquan-He/mm-clean-up-names-and-parameters-of-memmap_init_xxxx-functions/20210120-135239
> base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 1e2a199f6ccdc15cf111d68d212e2fd4ce65682e
> config: mips-randconfig-r036-20210120 (attached as .config)
> compiler: mips-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://github.com/0day-ci/linux/commit/1bbb0b35dd2fae4a7a38098e63899677c2e53108
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Baoquan-He/mm-clean-up-names-and-parameters-of-memmap_init_xxxx-functions/20210120-135239
> git checkout 1bbb0b35dd2fae4a7a38098e63899677c2e53108
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> mm/page_alloc.c:3597:15: warning: no previous prototype for 'should_fail_alloc_page' [-Wmissing-prototypes]
> 3597 | noinline bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order)
> | ^~~~~~~~~~~~~~~~~~~~~~
> >> mm/page_alloc.c:6258:23: warning: no previous prototype for 'memmap_init_zone' [-Wmissing-prototypes]
> 6258 | void __meminit __weak memmap_init_zone(unsigned long size, int nid,
This is not introduced by this patch, but existing issue, should
be not related to this patchset. I will investigate and see what we
should do with memmap_init_zone(), adding static or adding it to header
file, or just leave it as should_fail_alloc_page().
By the way, I tried to reproduce on a fedora 32 system of x86 arch, but
met below issue. could you help check what I can do to fix the error.
[root(a)dell-per710-01 linux]# COMPILER_INSTALL_PATH=~/0day COMPILER=gcc-9.3.0 ~/bin/make.cross ARCH=mips
Compiler will be installed in /root/0day
make W=1 CONFIG_OF_ALL_DTBS=y CONFIG_DTC=y CROSS_COMPILE=/root/0day/gcc-9.3.0-nolibc/mips-linux/bin/mips-linux- --jobs=16 ARCH=mips
HOSTCXX scripts/gcc-plugins/latent_entropy_plugin.so
HOSTCXX scripts/gcc-plugins/structleak_plugin.so
HOSTCXX scripts/gcc-plugins/randomize_layout_plugin.so
In file included from /root/0day/gcc-9.3.0-nolibc/mips-linux/bin/../lib/gcc/mips-linux/9.3.0/plugin/include/gcc-plugin.h:28,
from scripts/gcc-plugins/gcc-common.h:7,
from scripts/gcc-plugins/latent_entropy_plugin.c:78:
/root/0day/gcc-9.3.0-nolibc/mips-linux/bin/../lib/gcc/mips-linux/9.3.0/plugin/include/system.h:687:10: fatal error: gmp.h: No such file or directy
687 | #include <gmp.h>
| ^~~~~~~
compilation terminated.
make[2]: *** [scripts/gcc-plugins/Makefile:47: scripts/gcc-plugins/latent_entropy_plugin.so] Error 1
make[2]: *** Waiting for unfinished jobs..
Thanks
Baoquan
> | ^~~~~~~~~~~~~~~~
>
>
> vim +/memmap_init_zone +6258 mm/page_alloc.c
>
> 6257
> > 6258 void __meminit __weak memmap_init_zone(unsigned long size, int nid,
> 6259 unsigned long zone,
> 6260 unsigned long range_start_pfn)
> 6261 {
> 6262 unsigned long start_pfn, end_pfn;
> 6263 unsigned long range_end_pfn = range_start_pfn + size;
> 6264 int i;
> 6265
> 6266 for_each_mem_pfn_range(i, nid, &start_pfn, &end_pfn, NULL) {
> 6267 start_pfn = clamp(start_pfn, range_start_pfn, range_end_pfn);
> 6268 end_pfn = clamp(end_pfn, range_start_pfn, range_end_pfn);
> 6269
> 6270 if (end_pfn > start_pfn) {
> 6271 size = end_pfn - start_pfn;
> 6272 memmap_init_range(size, nid, zone, start_pfn, range_end_pfn,
> 6273 MEMINIT_EARLY, NULL, MIGRATE_MOVABLE);
> 6274 }
> 6275 }
> 6276 }
> 6277
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2021-01-21 8:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 4:52 [PATCH v4 0/4] mm: clean up names and parameters of memmap_init_xxxx functions Baoquan He
2021-01-20 4:52 ` [PATCH v4 1/4] mm: rename memmap_init() and memmap_init_zone() Baoquan He
2021-01-20 15:47 ` kernel test robot
2021-01-20 15:47 ` kernel test robot
2021-01-21 8:17 ` Baoquan He [this message]
2021-01-21 8:17 ` Baoquan He
2021-01-21 8:25 ` Mike Rapoport
2021-01-21 8:25 ` Mike Rapoport
2021-01-21 8:43 ` Baoquan He
2021-01-21 8:43 ` Baoquan He
2021-01-22 7:13 ` Baoquan He
2021-01-22 7:13 ` Baoquan He
2021-01-22 8:46 ` David Hildenbrand
2021-01-20 4:52 ` [PATCH v4 2/4] mm: simplify parater of function memmap_init_zone() Baoquan He
2021-01-22 8:43 ` David Hildenbrand
2021-01-20 4:52 ` [PATCH v4 3/4] mm: simplify parameter of setup_usemap() Baoquan He
2021-01-20 4:52 ` [PATCH v4 4/4] mm: remove unneeded local variable in free_area_init_core Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210121081727.GG20161@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.