From: Vincenzo Frascino <vincenzo.frascino@arm.com> To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Dmitry Vyukov <dvyukov@google.com>, Andrey Ryabinin <aryabinin@virtuozzo.com>, Alexander Potapenko <glider@google.com>, Marco Elver <elver@google.com>, Evgenii Stepanov <eugenis@google.com>, Branislav Rankov <Branislav.Rankov@arm.com>, Andrey Konovalov <andreyknvl@google.com> Subject: [PATCH v5 6/6] kasan: Forbid kunit tests when async mode is enabled Date: Thu, 21 Jan 2021 16:39:43 +0000 [thread overview] Message-ID: <20210121163943.9889-7-vincenzo.frascino@arm.com> (raw) In-Reply-To: <20210121163943.9889-1-vincenzo.frascino@arm.com> Architectures supported by KASAN_HW_TAGS can provide a sync or async mode of execution. KASAN KUNIT tests can be executed only when sync mode is enabled. Forbid the execution of the KASAN KUNIT tests when async mode is enabled. Cc: Dmitry Vyukov <dvyukov@google.com> Cc: Andrey Ryabinin <aryabinin@virtuozzo.com> Cc: Alexander Potapenko <glider@google.com> Cc: Andrey Konovalov <andreyknvl@google.com> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com> --- lib/test_kasan.c | 5 +++++ mm/kasan/kasan.h | 2 ++ 2 files changed, 7 insertions(+) diff --git a/lib/test_kasan.c b/lib/test_kasan.c index 7285dcf9fcc1..1306f707b4fe 100644 --- a/lib/test_kasan.c +++ b/lib/test_kasan.c @@ -52,6 +52,11 @@ static int kasan_test_init(struct kunit *test) return -1; } + if (!hw_is_mode_sync()) { + kunit_err(test, "can't run KASAN tests in async mode"); + return -1; + } + multishot = kasan_save_enable_multi_shot(); hw_set_tagging_report_once(false); return 0; diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h index 3923d9744105..3464113042ab 100644 --- a/mm/kasan/kasan.h +++ b/mm/kasan/kasan.h @@ -296,6 +296,7 @@ static inline const void *arch_kasan_set_tag(const void *addr, u8 tag) #define hw_enable_tagging_sync() arch_enable_tagging_sync() #define hw_enable_tagging_async() arch_enable_tagging_async() +#define hw_is_mode_sync() arch_is_mode_sync() #define hw_init_tags(max_tag) arch_init_tags(max_tag) #define hw_set_tagging_report_once(state) arch_set_tagging_report_once(state) #define hw_get_random_tag() arch_get_random_tag() @@ -306,6 +307,7 @@ static inline const void *arch_kasan_set_tag(const void *addr, u8 tag) #define hw_enable_tagging_sync() #define hw_enable_tagging_async() +#define hw_is_mode_sync() #define hw_set_tagging_report_once(state) #endif /* CONFIG_KASAN_HW_TAGS */ -- 2.30.0
WARNING: multiple messages have this Message-ID (diff)
From: Vincenzo Frascino <vincenzo.frascino@arm.com> To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com Cc: Marco Elver <elver@google.com>, Catalin Marinas <catalin.marinas@arm.com>, Branislav Rankov <Branislav.Rankov@arm.com>, Alexander Potapenko <glider@google.com>, Evgenii Stepanov <eugenis@google.com>, Andrey Konovalov <andreyknvl@google.com>, Andrey Ryabinin <aryabinin@virtuozzo.com>, Vincenzo Frascino <vincenzo.frascino@arm.com>, Will Deacon <will@kernel.org>, Dmitry Vyukov <dvyukov@google.com> Subject: [PATCH v5 6/6] kasan: Forbid kunit tests when async mode is enabled Date: Thu, 21 Jan 2021 16:39:43 +0000 [thread overview] Message-ID: <20210121163943.9889-7-vincenzo.frascino@arm.com> (raw) In-Reply-To: <20210121163943.9889-1-vincenzo.frascino@arm.com> Architectures supported by KASAN_HW_TAGS can provide a sync or async mode of execution. KASAN KUNIT tests can be executed only when sync mode is enabled. Forbid the execution of the KASAN KUNIT tests when async mode is enabled. Cc: Dmitry Vyukov <dvyukov@google.com> Cc: Andrey Ryabinin <aryabinin@virtuozzo.com> Cc: Alexander Potapenko <glider@google.com> Cc: Andrey Konovalov <andreyknvl@google.com> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com> --- lib/test_kasan.c | 5 +++++ mm/kasan/kasan.h | 2 ++ 2 files changed, 7 insertions(+) diff --git a/lib/test_kasan.c b/lib/test_kasan.c index 7285dcf9fcc1..1306f707b4fe 100644 --- a/lib/test_kasan.c +++ b/lib/test_kasan.c @@ -52,6 +52,11 @@ static int kasan_test_init(struct kunit *test) return -1; } + if (!hw_is_mode_sync()) { + kunit_err(test, "can't run KASAN tests in async mode"); + return -1; + } + multishot = kasan_save_enable_multi_shot(); hw_set_tagging_report_once(false); return 0; diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h index 3923d9744105..3464113042ab 100644 --- a/mm/kasan/kasan.h +++ b/mm/kasan/kasan.h @@ -296,6 +296,7 @@ static inline const void *arch_kasan_set_tag(const void *addr, u8 tag) #define hw_enable_tagging_sync() arch_enable_tagging_sync() #define hw_enable_tagging_async() arch_enable_tagging_async() +#define hw_is_mode_sync() arch_is_mode_sync() #define hw_init_tags(max_tag) arch_init_tags(max_tag) #define hw_set_tagging_report_once(state) arch_set_tagging_report_once(state) #define hw_get_random_tag() arch_get_random_tag() @@ -306,6 +307,7 @@ static inline const void *arch_kasan_set_tag(const void *addr, u8 tag) #define hw_enable_tagging_sync() #define hw_enable_tagging_async() +#define hw_is_mode_sync() #define hw_set_tagging_report_once(state) #endif /* CONFIG_KASAN_HW_TAGS */ -- 2.30.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-21 16:43 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-21 16:39 [PATCH v5 0/6] arm64: ARMv8.5-A: MTE: Add async mode support Vincenzo Frascino 2021-01-21 16:39 ` Vincenzo Frascino 2021-01-21 16:39 ` [PATCH v5 1/6] arm64: mte: Add asynchronous " Vincenzo Frascino 2021-01-21 16:39 ` Vincenzo Frascino 2021-01-21 16:39 ` [PATCH v5 2/6] kasan: Add KASAN mode kernel parameter Vincenzo Frascino 2021-01-21 16:39 ` Vincenzo Frascino 2021-01-21 17:34 ` Andrey Konovalov 2021-01-21 17:34 ` Andrey Konovalov 2021-01-22 11:25 ` Vincenzo Frascino 2021-01-22 11:25 ` Vincenzo Frascino 2021-01-21 16:39 ` [PATCH v5 3/6] kasan: Add report for async mode Vincenzo Frascino 2021-01-21 16:39 ` Vincenzo Frascino 2021-01-21 17:36 ` Andrey Konovalov 2021-01-21 17:36 ` Andrey Konovalov 2021-01-22 2:45 ` kernel test robot 2021-01-22 2:45 ` kernel test robot 2021-01-22 2:45 ` kernel test robot 2021-01-22 2:46 ` kernel test robot 2021-01-22 2:46 ` kernel test robot 2021-01-22 2:46 ` kernel test robot 2021-01-22 13:19 ` Catalin Marinas 2021-01-22 13:19 ` Catalin Marinas 2021-01-22 13:27 ` Vincenzo Frascino 2021-01-22 13:27 ` Vincenzo Frascino 2021-01-22 13:38 ` Vincenzo Frascino 2021-01-22 13:38 ` Vincenzo Frascino 2021-01-21 16:39 ` [PATCH v5 4/6] arm64: mte: Enable async tag check fault Vincenzo Frascino 2021-01-21 16:39 ` Vincenzo Frascino 2021-01-21 17:38 ` Andrey Konovalov 2021-01-21 17:38 ` Andrey Konovalov 2021-01-22 11:24 ` Vincenzo Frascino 2021-01-22 11:24 ` Vincenzo Frascino 2021-01-22 11:58 ` Catalin Marinas 2021-01-22 11:58 ` Catalin Marinas 2021-01-21 16:39 ` [PATCH v5 5/6] arm64: mte: Expose execution mode Vincenzo Frascino 2021-01-21 16:39 ` Vincenzo Frascino 2021-01-21 17:41 ` Andrey Konovalov 2021-01-21 17:41 ` Andrey Konovalov 2021-01-21 16:39 ` Vincenzo Frascino [this message] 2021-01-21 16:39 ` [PATCH v5 6/6] kasan: Forbid kunit tests when async mode is enabled Vincenzo Frascino 2021-01-21 17:40 ` Andrey Konovalov 2021-01-21 17:40 ` Andrey Konovalov 2021-01-22 11:26 ` Vincenzo Frascino 2021-01-22 11:26 ` Vincenzo Frascino 2021-01-22 12:00 ` Catalin Marinas 2021-01-22 12:00 ` Catalin Marinas 2021-01-22 4:04 ` kernel test robot 2021-01-22 4:04 ` kernel test robot 2021-01-22 4:04 ` kernel test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210121163943.9889-7-vincenzo.frascino@arm.com \ --to=vincenzo.frascino@arm.com \ --cc=Branislav.Rankov@arm.com \ --cc=andreyknvl@google.com \ --cc=aryabinin@virtuozzo.com \ --cc=catalin.marinas@arm.com \ --cc=dvyukov@google.com \ --cc=elver@google.com \ --cc=eugenis@google.com \ --cc=glider@google.com \ --cc=kasan-dev@googlegroups.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.