From: Alexander Lobakin <alobakin@pm.me> To: David Rientjes <rientjes@google.com> Cc: Alexander Lobakin <alobakin@pm.me>, "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, Yisen Zhuang <yisen.zhuang@huawei.com>, Salil Mehta <salil.mehta@huawei.com>, Jesse Brandeburg <jesse.brandeburg@intel.com>, Tony Nguyen <anthony.l.nguyen@intel.com>, Saeed Mahameed <saeedm@nvidia.com>, Leon Romanovsky <leon@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, Jesper Dangaard Brouer <hawk@kernel.org>, Ilias Apalodimas <ilias.apalodimas@linaro.org>, Jonathan Lemon <jonathan.lemon@gmail.com>, Willem de Bruijn <willemb@google.com>, Randy Dunlap <rdunlap@infradead.org>, Pablo Neira Ayuso <pablo@netfilter.org>, Dexuan Cui <decui@microsoft.com>, Jakub Sitnicki <jakub@cloudflare.com>, Marco Elver <elver@google.com>, Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH net-next 2/3] net: constify page_is_pfmemalloc() argument at call sites Date: Mon, 25 Jan 2021 18:27:33 +0000 [thread overview] Message-ID: <20210125182702.247232-1-alobakin@pm.me> (raw) In-Reply-To: <85978330-9753-f7a-f263-7a1cfd95b851@google.com> From: David Rientjes <rientjes@google.com> Date: Mon, 25 Jan 2021 10:19:48 -0800 (PST) > On Mon, 25 Jan 2021, Alexander Lobakin wrote: > > > Constify "page" argument for page_is_pfmemalloc() users where applicable. > > > > Signed-off-by: Alexander Lobakin <alobakin@pm.me> > > --- > > drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 2 +- > > drivers/net/ethernet/intel/fm10k/fm10k_main.c | 2 +- > > drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 +- > > drivers/net/ethernet/intel/iavf/iavf_txrx.c | 2 +- > > drivers/net/ethernet/intel/ice/ice_txrx.c | 2 +- > > drivers/net/ethernet/intel/igb/igb_main.c | 2 +- > > drivers/net/ethernet/intel/igc/igc_main.c | 2 +- > > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +- > > drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 2 +- > > drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 2 +- > > include/linux/skbuff.h | 4 ++-- > > 11 files changed, 12 insertions(+), 12 deletions(-) > > > > diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > > index 512080640cbc..0f8e962b5010 100644 > > --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > > +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > > @@ -2800,7 +2800,7 @@ static void hns3_nic_alloc_rx_buffers(struct hns3_enet_ring *ring, > > writel(i, ring->tqp->io_base + HNS3_RING_RX_RING_HEAD_REG); > > } > > > > -static bool hns3_page_is_reusable(struct page *page) > > +static bool hns3_page_is_reusable(const struct page *page) > > { > > return page_to_nid(page) == numa_mem_id() && > > !page_is_pfmemalloc(page); > > Hi Alexander, Hi David! > All of these functions appear to be doing the same thing, would it make > sense to simply add this to a header file and remove all the code > duplication as well? That's an interesting idea. I'll be glad to do this if drivers' maintainers agree it's okay for them. Thanks, Al
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Lobakin <alobakin@pm.me> To: intel-wired-lan@osuosl.org Subject: [Intel-wired-lan] [PATCH net-next 2/3] net: constify page_is_pfmemalloc() argument at call sites Date: Mon, 25 Jan 2021 18:27:33 +0000 [thread overview] Message-ID: <20210125182702.247232-1-alobakin@pm.me> (raw) In-Reply-To: <85978330-9753-f7a-f263-7a1cfd95b851@google.com> From: David Rientjes <rientjes@google.com> Date: Mon, 25 Jan 2021 10:19:48 -0800 (PST) > On Mon, 25 Jan 2021, Alexander Lobakin wrote: > > > Constify "page" argument for page_is_pfmemalloc() users where applicable. > > > > Signed-off-by: Alexander Lobakin <alobakin@pm.me> > > --- > > drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 2 +- > > drivers/net/ethernet/intel/fm10k/fm10k_main.c | 2 +- > > drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 +- > > drivers/net/ethernet/intel/iavf/iavf_txrx.c | 2 +- > > drivers/net/ethernet/intel/ice/ice_txrx.c | 2 +- > > drivers/net/ethernet/intel/igb/igb_main.c | 2 +- > > drivers/net/ethernet/intel/igc/igc_main.c | 2 +- > > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +- > > drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 2 +- > > drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 2 +- > > include/linux/skbuff.h | 4 ++-- > > 11 files changed, 12 insertions(+), 12 deletions(-) > > > > diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > > index 512080640cbc..0f8e962b5010 100644 > > --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > > +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > > @@ -2800,7 +2800,7 @@ static void hns3_nic_alloc_rx_buffers(struct hns3_enet_ring *ring, > > writel(i, ring->tqp->io_base + HNS3_RING_RX_RING_HEAD_REG); > > } > > > > -static bool hns3_page_is_reusable(struct page *page) > > +static bool hns3_page_is_reusable(const struct page *page) > > { > > return page_to_nid(page) == numa_mem_id() && > > !page_is_pfmemalloc(page); > > Hi Alexander, Hi David! > All of these functions appear to be doing the same thing, would it make > sense to simply add this to a header file and remove all the code > duplication as well? That's an interesting idea. I'll be glad to do this if drivers' maintainers agree it's okay for them. Thanks, Al
next prev parent reply other threads:[~2021-01-25 18:30 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-25 16:46 [PATCH net-next 0/3] net: constify page_is_pfmemalloc() and its users Alexander Lobakin 2021-01-25 16:46 ` [Intel-wired-lan] " Alexander Lobakin 2021-01-25 16:46 ` [PATCH net-next 1/3] mm: constify page_is_pfmemalloc() argument Alexander Lobakin 2021-01-25 16:46 ` [Intel-wired-lan] " Alexander Lobakin 2021-01-25 16:47 ` [PATCH net-next 2/3] net: constify page_is_pfmemalloc() argument at call sites Alexander Lobakin 2021-01-25 16:47 ` [Intel-wired-lan] " Alexander Lobakin 2021-01-25 18:19 ` David Rientjes 2021-01-25 18:19 ` [Intel-wired-lan] " David Rientjes 2021-01-25 18:19 ` David Rientjes 2021-01-25 18:27 ` Alexander Lobakin [this message] 2021-01-25 18:27 ` [Intel-wired-lan] " Alexander Lobakin 2021-01-25 16:47 ` [PATCH net-next 3/3] net: page_pool: simplify page recycling condition tests Alexander Lobakin 2021-01-25 16:47 ` [Intel-wired-lan] " Alexander Lobakin 2021-01-25 19:22 ` Jesper Dangaard Brouer 2021-01-25 19:22 ` [Intel-wired-lan] " Jesper Dangaard Brouer 2021-01-26 11:08 ` Ilias Apalodimas 2021-01-26 11:08 ` [Intel-wired-lan] " Ilias Apalodimas 2021-01-27 20:23 ` [PATCH net-next 0/3] net: constify page_is_pfmemalloc() and its users Alexander Lobakin 2021-01-27 20:23 ` [Intel-wired-lan] " Alexander Lobakin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210125182702.247232-1-alobakin@pm.me \ --to=alobakin@pm.me \ --cc=akpm@linux-foundation.org \ --cc=anthony.l.nguyen@intel.com \ --cc=davem@davemloft.net \ --cc=decui@microsoft.com \ --cc=elver@google.com \ --cc=hawk@kernel.org \ --cc=ilias.apalodimas@linaro.org \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=jakub@cloudflare.com \ --cc=jesse.brandeburg@intel.com \ --cc=jonathan.lemon@gmail.com \ --cc=kuba@kernel.org \ --cc=leon@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-rdma@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=pabeni@redhat.com \ --cc=pablo@netfilter.org \ --cc=rdunlap@infradead.org \ --cc=rientjes@google.com \ --cc=saeedm@nvidia.com \ --cc=salil.mehta@huawei.com \ --cc=willemb@google.com \ --cc=yisen.zhuang@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.