All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime@cerno.tech>
To: Andre Przywara <andre.przywara@arm.com>
Cc: "Chen-Yu Tsai" <wens@csie.org>,
	"Jernej Skrabec" <jernej.skrabec@siol.net>,
	"Samuel Holland" <samuel@sholland.org>,
	"Icenowy Zheng" <icenowy@aosc.io>,
	"Rob Herring" <robh@kernel.org>,
	"Clément Péron" <peron.clem@gmail.com>,
	"Shuosheng Huang" <huangshuosheng@allwinnertech.com>,
	"Yangtao Li" <tiny.windzz@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Ulf Hansson" <ulf.hansson@linaro.org>
Subject: Re: [PATCH v4 00/21] arm64: sunxi: Initial Allwinner H616 SoC support
Date: Tue, 26 Jan 2021 13:07:47 +0100	[thread overview]
Message-ID: <20210126120747.zvsk2ttowruemefu@gilmour> (raw)
In-Reply-To: <20210125151811.11871-1-andre.przywara@arm.com>

[-- Attachment #1: Type: text/plain, Size: 4552 bytes --]

Hi,

On Mon, Jan 25, 2021 at 03:17:50PM +0000, Andre Przywara wrote:
> Hi,
> 
> an update from the v3 last week, to add support for the Allwinner H616
> SoC. Still based on the (updated) sunxi/for-next branch.
> I am omitting the MMC and pinctrl patches now, as they have been taken
> by Ulf and LinusW already into their trees.
> 
> I addressed the comments from the list, though not sure if the HOSC clock
> coming from the RTC is really a good idea (didn't change it).
> 
> I was hoping that at least the clock and AXP patches (01/21-06/21) could
> make it into 5.12 still? That would allow booting boards from SD card.
> I am happy to strip the .dtsi and .dts patch to only contain the devices
> that we actually support then, if needed.
> 
> For the changes: I split the joint DT bindings patch into subsystem
> specific ones, hopefully this simplifies merging. There is a new fix
> for the axp20x-pek driver, and the AXP IRQ fix has been amended as well
> (according to Samuel's comments).
> 
> I eventually got USB to work, by requiring PHY 2 for [EO]HCI 1 & 3 as well.
> Not sure this is the right fix, it might be just one clock or reset
> line from that PHY that is needed for the others as well. Will do further
> experiments.
> 
> For a more detailed changelog, see below.

With your series applied:

ARCH=arm64 make -j18 dtbs_check  
arch/arm64/Makefile:25: ld does not support --fix-cortex-a53-843419; kernel may be susceptible to erratum
arch/arm64/Makefile:33: LSE atomics not supported by binutils
arch/arm64/Makefile:44: Detected assembler with broken .inst; disassembly will be unreliable
  DTC     arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dtb
  DTC     arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dt.yaml
  CHECK   arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dt.yaml
/home/max/Work/allwinner/build/arm64/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dt.yaml: clock@3001000: clocks: [[7], [8, 0], [8, 2]] is too long
	From schema: /home/max/Work/repos/linux/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-ccu.yaml
/home/max/Work/allwinner/build/arm64/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dt.yaml: clock@3001000: clock-names: ['hosc', 'losc', 'iosc'] is too long
	From schema: /home/max/Work/repos/linux/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-ccu.yaml
/home/max/Work/allwinner/build/arm64/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dt.yaml: ethernet@5020000: compatible: 'oneOf' conditional failed, one must be fixed:
	['allwinner,sun50i-h616-emac', 'allwinner,sun50i-a64-emac'] is too long
	Additional items are not allowed ('allwinner,sun50i-a64-emac' was unexpected)
	'allwinner,sun8i-a83t-emac' was expected
	'allwinner,sun8i-h3-emac' was expected
	'allwinner,sun8i-r40-emac' was expected
	'allwinner,sun8i-v3s-emac' was expected
	'allwinner,sun50i-a64-emac' was expected
	'allwinner,sun50i-h6-emac' was expected
	From schema: /home/max/Work/repos/linux/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml
/home/max/Work/allwinner/build/arm64/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dt.yaml: clock@7010000: clocks: [[7], [8, 0], [8, 2], [2, 4]] is too long
	From schema: /home/max/Work/repos/linux/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-ccu.yaml
/home/max/Work/allwinner/build/arm64/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dt.yaml: clock@7010000: clock-names: ['hosc', 'losc', 'iosc', 'pll-periph'] is too long
	From schema: /home/max/Work/repos/linux/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-ccu.yaml
/home/max/Work/allwinner/build/arm64/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dt.yaml: rsb@7083000: compatible: 'oneOf' conditional failed, one must be fixed:
	['allwinner,sun50i-h616-rsb', 'allwinner,sun8i-a23-rsb'] is too long
	Additional items are not allowed ('allwinner,sun8i-a23-rsb' was unexpected)
	'allwinner,sun8i-a23-rsb' was expected
	'allwinner,sun8i-a83t-rsb' was expected
	From schema: /home/max/Work/repos/linux/Documentation/devicetree/bindings/bus/allwinner,sun8i-a23-rsb.yaml
/home/max/Work/allwinner/build/arm64/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dt.yaml: leds: led-0:default-state:0: 'on' is not of type 'array'
	From schema: /home/max/Work/repos/linux/Documentation/devicetree/bindings/leds/leds-gpio.yaml

The last one is not related to your changes, but the rest must be fixed

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech>
To: Andre Przywara <andre.przywara@arm.com>
Cc: "Jernej Skrabec" <jernej.skrabec@siol.net>,
	"Samuel Holland" <samuel@sholland.org>,
	"Yangtao Li" <tiny.windzz@gmail.com>,
	linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Clément Péron" <peron.clem@gmail.com>,
	"Shuosheng Huang" <huangshuosheng@allwinnertech.com>,
	"Ulf Hansson" <ulf.hansson@linaro.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	"Icenowy Zheng" <icenowy@aosc.io>
Subject: Re: [PATCH v4 00/21] arm64: sunxi: Initial Allwinner H616 SoC support
Date: Tue, 26 Jan 2021 13:07:47 +0100	[thread overview]
Message-ID: <20210126120747.zvsk2ttowruemefu@gilmour> (raw)
In-Reply-To: <20210125151811.11871-1-andre.przywara@arm.com>


[-- Attachment #1.1: Type: text/plain, Size: 4552 bytes --]

Hi,

On Mon, Jan 25, 2021 at 03:17:50PM +0000, Andre Przywara wrote:
> Hi,
> 
> an update from the v3 last week, to add support for the Allwinner H616
> SoC. Still based on the (updated) sunxi/for-next branch.
> I am omitting the MMC and pinctrl patches now, as they have been taken
> by Ulf and LinusW already into their trees.
> 
> I addressed the comments from the list, though not sure if the HOSC clock
> coming from the RTC is really a good idea (didn't change it).
> 
> I was hoping that at least the clock and AXP patches (01/21-06/21) could
> make it into 5.12 still? That would allow booting boards from SD card.
> I am happy to strip the .dtsi and .dts patch to only contain the devices
> that we actually support then, if needed.
> 
> For the changes: I split the joint DT bindings patch into subsystem
> specific ones, hopefully this simplifies merging. There is a new fix
> for the axp20x-pek driver, and the AXP IRQ fix has been amended as well
> (according to Samuel's comments).
> 
> I eventually got USB to work, by requiring PHY 2 for [EO]HCI 1 & 3 as well.
> Not sure this is the right fix, it might be just one clock or reset
> line from that PHY that is needed for the others as well. Will do further
> experiments.
> 
> For a more detailed changelog, see below.

With your series applied:

ARCH=arm64 make -j18 dtbs_check  
arch/arm64/Makefile:25: ld does not support --fix-cortex-a53-843419; kernel may be susceptible to erratum
arch/arm64/Makefile:33: LSE atomics not supported by binutils
arch/arm64/Makefile:44: Detected assembler with broken .inst; disassembly will be unreliable
  DTC     arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dtb
  DTC     arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dt.yaml
  CHECK   arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dt.yaml
/home/max/Work/allwinner/build/arm64/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dt.yaml: clock@3001000: clocks: [[7], [8, 0], [8, 2]] is too long
	From schema: /home/max/Work/repos/linux/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-ccu.yaml
/home/max/Work/allwinner/build/arm64/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dt.yaml: clock@3001000: clock-names: ['hosc', 'losc', 'iosc'] is too long
	From schema: /home/max/Work/repos/linux/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-ccu.yaml
/home/max/Work/allwinner/build/arm64/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dt.yaml: ethernet@5020000: compatible: 'oneOf' conditional failed, one must be fixed:
	['allwinner,sun50i-h616-emac', 'allwinner,sun50i-a64-emac'] is too long
	Additional items are not allowed ('allwinner,sun50i-a64-emac' was unexpected)
	'allwinner,sun8i-a83t-emac' was expected
	'allwinner,sun8i-h3-emac' was expected
	'allwinner,sun8i-r40-emac' was expected
	'allwinner,sun8i-v3s-emac' was expected
	'allwinner,sun50i-a64-emac' was expected
	'allwinner,sun50i-h6-emac' was expected
	From schema: /home/max/Work/repos/linux/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml
/home/max/Work/allwinner/build/arm64/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dt.yaml: clock@7010000: clocks: [[7], [8, 0], [8, 2], [2, 4]] is too long
	From schema: /home/max/Work/repos/linux/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-ccu.yaml
/home/max/Work/allwinner/build/arm64/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dt.yaml: clock@7010000: clock-names: ['hosc', 'losc', 'iosc', 'pll-periph'] is too long
	From schema: /home/max/Work/repos/linux/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-ccu.yaml
/home/max/Work/allwinner/build/arm64/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dt.yaml: rsb@7083000: compatible: 'oneOf' conditional failed, one must be fixed:
	['allwinner,sun50i-h616-rsb', 'allwinner,sun8i-a23-rsb'] is too long
	Additional items are not allowed ('allwinner,sun8i-a23-rsb' was unexpected)
	'allwinner,sun8i-a23-rsb' was expected
	'allwinner,sun8i-a83t-rsb' was expected
	From schema: /home/max/Work/repos/linux/Documentation/devicetree/bindings/bus/allwinner,sun8i-a23-rsb.yaml
/home/max/Work/allwinner/build/arm64/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dt.yaml: leds: led-0:default-state:0: 'on' is not of type 'array'
	From schema: /home/max/Work/repos/linux/Documentation/devicetree/bindings/leds/leds-gpio.yaml

The last one is not related to your changes, but the rest must be fixed

Maxime

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-01-26 12:10 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-25 15:17 [PATCH v4 00/21] arm64: sunxi: Initial Allwinner H616 SoC support Andre Przywara
2021-01-25 15:17 ` Andre Przywara
2021-01-25 15:17 ` [PATCH v4 01/21] dt-bindings: clk: sunxi-ccu: Add compatible string for Allwinner H616 Andre Przywara
2021-01-25 15:17   ` Andre Przywara
2021-01-25 15:17 ` [PATCH v4 02/21] clk: sunxi-ng: Add support for the Allwinner H616 R-CCU Andre Przywara
2021-01-25 15:17   ` Andre Przywara
2021-01-25 15:17 ` [PATCH v4 03/21] clk: sunxi-ng: Add support for the Allwinner H616 CCU Andre Przywara
2021-01-25 15:17   ` Andre Przywara
2021-01-25 15:17 ` [PATCH v4 04/21] dt-bindings: mfd: axp20x: Add AXP305 compatible (plus optional IRQ) Andre Przywara
2021-01-25 15:17   ` Andre Przywara
2021-01-25 15:17 ` [PATCH v4 05/21] Input: axp20x-pek: Bail out if AXP has no interrupt line connected Andre Przywara
2021-01-25 15:17   ` Andre Przywara
2021-01-25 15:17 ` [PATCH v4 06/21] mfd: axp20x: Allow AXP chips without interrupt lines Andre Przywara
2021-01-25 15:17   ` Andre Przywara
2021-01-25 15:17 ` [PATCH v4 07/21] dt-bindings: sram: sunxi-sram: Add H616 compatible string Andre Przywara
2021-01-25 15:17   ` Andre Przywara
2021-01-25 15:17 ` [PATCH v4 08/21] soc: sunxi: sram: Add support for more than one EMAC clock Andre Przywara
2021-01-25 15:17   ` Andre Przywara
2021-01-25 15:17 ` [PATCH v4 09/21] dt-bindings: watchdog: sun4i: Add H616 compatible string Andre Przywara
2021-01-25 15:17   ` Andre Przywara
2021-01-25 15:18 ` [PATCH v4 10/21] dt-bindings: i2c: mv64xxx: " Andre Przywara
2021-01-25 15:18   ` Andre Przywara
2021-01-25 15:18 ` [PATCH v4 11/21] dt-bindings: media: IR: Add H616 IR " Andre Przywara
2021-01-25 15:18   ` Andre Przywara
2021-01-25 15:18 ` [PATCH v4 12/21] dt-bindings: rtc: sun6i: Add H616 " Andre Przywara
2021-01-25 15:18   ` Andre Przywara
2021-01-25 22:51   ` Alexandre Belloni
2021-01-25 22:51     ` Alexandre Belloni
2021-01-26  0:14     ` Andre Przywara
2021-01-26  0:14       ` Andre Przywara
2021-01-25 15:18 ` [PATCH v4 13/21] dt-bindings: spi: sunxi: " Andre Przywara
2021-01-25 15:18   ` Andre Przywara
2021-01-25 15:18 ` [PATCH v4 14/21] net: stmmac: dwmac-sun8i: Prepare for second EMAC clock register Andre Przywara
2021-01-25 15:18   ` Andre Przywara
2021-01-25 15:18 ` [PATCH v4 15/21] phy: sun4i-usb: Rework HCI PHY (aka. "pmu_unk1") handling Andre Przywara
2021-01-25 15:18   ` Andre Przywara
2021-01-25 15:18 ` [PATCH v4 16/21] dt-bindings: usb: Add H616 compatible string Andre Przywara
2021-01-25 15:18   ` Andre Przywara
2021-01-25 15:18 ` [PATCH v4 17/21] dt-bindings: usb: sunxi-musb: " Andre Przywara
2021-01-25 15:18   ` Andre Przywara
2021-01-25 15:18 ` [PATCH v4 18/21] phy: sun4i-usb: Add support for the H616 USB PHY Andre Przywara
2021-01-25 15:18   ` Andre Przywara
2021-01-25 15:18 ` [PATCH v4 19/21] arm64: dts: allwinner: Add Allwinner H616 .dtsi file Andre Przywara
2021-01-25 15:18   ` Andre Przywara
2021-01-25 15:18 ` [PATCH v4 20/21] dt-bindings: arm: sunxi: Add OrangePi Zero 2 binding Andre Przywara
2021-01-25 15:18   ` Andre Przywara
2021-01-25 15:18 ` [PATCH v4 21/21] arm64: dts: allwinner: Add OrangePi Zero 2 .dts Andre Przywara
2021-01-25 15:18   ` Andre Przywara
2021-01-26 12:07 ` Maxime Ripard [this message]
2021-01-26 12:07   ` [PATCH v4 00/21] arm64: sunxi: Initial Allwinner H616 SoC support Maxime Ripard
2021-01-27 17:15 ` (subset) " Mark Brown
2021-01-27 17:29   ` Andre Przywara
2021-01-27 17:29     ` Andre Przywara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210126120747.zvsk2ttowruemefu@gilmour \
    --to=maxime@cerno.tech \
    --cc=andre.przywara@arm.com \
    --cc=huangshuosheng@allwinnertech.com \
    --cc=icenowy@aosc.io \
    --cc=jernej.skrabec@siol.net \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=peron.clem@gmail.com \
    --cc=robh@kernel.org \
    --cc=samuel@sholland.org \
    --cc=tiny.windzz@gmail.com \
    --cc=ulf.hansson@linaro.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.