From: Mike Snitzer <snitzer@redhat.com>
To: Jeffle Xu <jefflexu@linux.alibaba.com>
Cc: joseph.qi@linux.alibaba.com, dm-devel@redhat.com,
linux-block@vger.kernel.org, io-uring@vger.kernel.org
Subject: Re: [PATCH v2 2/6] block: add queue_to_disk() to get gendisk from request_queue
Date: Wed, 27 Jan 2021 12:20:56 -0500 [thread overview]
Message-ID: <20210127172055.GB11530@redhat.com> (raw)
In-Reply-To: <20210125121340.70459-3-jefflexu@linux.alibaba.com>
On Mon, Jan 25 2021 at 7:13am -0500,
Jeffle Xu <jefflexu@linux.alibaba.com> wrote:
> Sometimes we need to get the corresponding gendisk from request_queue.
>
> It is preferred that block drivers store private data in
> gendisk->private_data rather than request_queue->queuedata, e.g. see:
> commit c4a59c4e5db3 ("dm: stop using ->queuedata").
>
> So if only request_queue is given, we need to get its corresponding
> gendisk to get the private data stored in that gendisk.
>
> Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com>
> Review-by: Mike Snitzer <snitzer@redhat.com>
^typo
Reviewed-by: Mike Snitzer <snitzer@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com>
To: Jeffle Xu <jefflexu@linux.alibaba.com>
Cc: linux-block@vger.kernel.org, joseph.qi@linux.alibaba.com,
dm-devel@redhat.com, io-uring@vger.kernel.org
Subject: Re: [dm-devel] [PATCH v2 2/6] block: add queue_to_disk() to get gendisk from request_queue
Date: Wed, 27 Jan 2021 12:20:56 -0500 [thread overview]
Message-ID: <20210127172055.GB11530@redhat.com> (raw)
In-Reply-To: <20210125121340.70459-3-jefflexu@linux.alibaba.com>
On Mon, Jan 25 2021 at 7:13am -0500,
Jeffle Xu <jefflexu@linux.alibaba.com> wrote:
> Sometimes we need to get the corresponding gendisk from request_queue.
>
> It is preferred that block drivers store private data in
> gendisk->private_data rather than request_queue->queuedata, e.g. see:
> commit c4a59c4e5db3 ("dm: stop using ->queuedata").
>
> So if only request_queue is given, we need to get its corresponding
> gendisk to get the private data stored in that gendisk.
>
> Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com>
> Review-by: Mike Snitzer <snitzer@redhat.com>
^typo
Reviewed-by: Mike Snitzer <snitzer@redhat.com>
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-01-27 17:23 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 12:13 [PATCH v2 0/6] dm: support IO polling for bio-based dm device Jeffle Xu
2021-01-25 12:13 ` [dm-devel] " Jeffle Xu
2021-01-25 12:13 ` [PATCH v2 1/6] block: move definition of blk_qc_t to types.h Jeffle Xu
2021-01-25 12:13 ` [dm-devel] " Jeffle Xu
2021-01-25 12:13 ` [PATCH v2 2/6] block: add queue_to_disk() to get gendisk from request_queue Jeffle Xu
2021-01-25 12:13 ` [dm-devel] " Jeffle Xu
2021-01-27 17:20 ` Mike Snitzer [this message]
2021-01-27 17:20 ` Mike Snitzer
2021-01-25 12:13 ` [PATCH v2 3/6] block: add iopoll method to support bio-based IO polling Jeffle Xu
2021-01-25 12:13 ` [dm-devel] " Jeffle Xu
2021-01-27 17:14 ` Mike Snitzer
2021-01-27 17:14 ` [dm-devel] " Mike Snitzer
2021-01-28 8:40 ` Christoph Hellwig
2021-01-28 8:40 ` [dm-devel] " Christoph Hellwig
2021-01-28 11:52 ` JeffleXu
2021-01-28 11:52 ` [dm-devel] " JeffleXu
2021-01-28 14:36 ` Christoph Hellwig
2021-01-28 14:36 ` [dm-devel] " Christoph Hellwig
2021-01-25 12:13 ` [PATCH v2 4/6] dm: always return BLK_QC_T_NONE for bio-based device Jeffle Xu
2021-01-25 12:13 ` [dm-devel] " Jeffle Xu
2021-01-25 12:13 ` [PATCH v2 5/6] block: add QUEUE_FLAG_POLL_CAP flag Jeffle Xu
2021-01-25 12:13 ` [dm-devel] " Jeffle Xu
2021-01-27 17:13 ` Mike Snitzer
2021-01-27 17:13 ` [dm-devel] " Mike Snitzer
2021-01-28 2:07 ` JeffleXu
2021-01-28 2:07 ` [dm-devel] " JeffleXu
2021-01-25 12:13 ` [PATCH v2 6/6] dm: support IO polling for bio-based dm device Jeffle Xu
2021-01-25 12:13 ` [dm-devel] " Jeffle Xu
2021-01-29 7:37 ` JeffleXu
2021-01-29 7:37 ` [dm-devel] " JeffleXu
2021-01-27 17:19 ` [PATCH v2 0/6] " Mike Snitzer
2021-01-27 17:19 ` [dm-devel] " Mike Snitzer
2021-01-28 3:06 ` JeffleXu
2021-01-28 3:06 ` [dm-devel] " JeffleXu
2021-01-31 16:26 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210127172055.GB11530@redhat.com \
--to=snitzer@redhat.com \
--cc=dm-devel@redhat.com \
--cc=io-uring@vger.kernel.org \
--cc=jefflexu@linux.alibaba.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.