All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Adrian Catangiu <acatan@amazon.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	qemu-devel@nongnu.org, kvm@vger.kernel.org,
	linux-s390@vger.kernel.org, gregkh@linuxfoundation.org,
	graf@amazon.com, arnd@arndb.de, ebiederm@xmission.com,
	rppt@kernel.org, 0x7f454c46@gmail.com, borntraeger@de.ibm.com,
	Jason@zx2c4.com, jannh@google.com, w@1wt.eu, colmmacc@amazon.com,
	luto@kernel.org, tytso@mit.edu, ebiggers@kernel.org,
	dwmw@amazon.co.uk, bonzini@gnu.org, sblbir@amazon.com,
	raduweis@amazon.com, corbet@lwn.net, mst@redhat.com,
	mhocko@kernel.org, rafael@kernel.org, mpe@ellerman.id.au,
	areber@redhat.com, ovzxemul@gmail.com, avagin@gmail.com,
	ptikhomirov@virtuozzo.com, gil@azul.com, asmehra@redhat.com,
	dgunigun@redhat.com, vijaysun@ca.ibm.com, oridgar@gmail.com,
	ghammer@redhat.com
Subject: Re: [PATCH v4 1/2] drivers/misc: sysgenid: add system generation id driver
Date: Wed, 27 Jan 2021 23:15:05 +0100	[thread overview]
Message-ID: <20210127221505.GB24799@amd> (raw)
In-Reply-To: <1610453760-13812-2-git-send-email-acatan@amazon.com>

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

Hi!

> - Solution
> 
> The System Generation ID is a simple concept meant to alleviate the
> issue by providing a monotonically increasing u32 counter that changes
> each time the VM or container is restored from a snapshot.

I'd make it u64.

But as people explained, this has race problems that may be impossible
to solve?

Best regards,
								Pavel
								
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Adrian Catangiu <acatan@amazon.com>
Cc: Jason@zx2c4.com, dgunigun@redhat.com, kvm@vger.kernel.org,
	linux-doc@vger.kernel.org, ghammer@redhat.com,
	vijaysun@ca.ibm.com, 0x7f454c46@gmail.com, qemu-devel@nongnu.org,
	mhocko@kernel.org, oridgar@gmail.com, avagin@gmail.com,
	ptikhomirov@virtuozzo.com, linux-s390@vger.kernel.org,
	corbet@lwn.net, mpe@ellerman.id.au, mst@redhat.com,
	ebiggers@kernel.org, borntraeger@de.ibm.com, sblbir@amazon.com,
	bonzini@gnu.org, arnd@arndb.de, jannh@google.com,
	raduweis@amazon.com, asmehra@redhat.com, graf@amazon.com,
	rppt@kernel.org, luto@kernel.org, gil@azul.com,
	colmmacc@amazon.com, tytso@mit.edu, gregkh@linuxfoundation.org,
	areber@redhat.com, linux-kernel@vger.kernel.org,
	ebiederm@xmission.com, ovzxemul@gmail.com, rafael@kernel.org,
	w@1wt.eu, dwmw@amazon.co.uk
Subject: Re: [PATCH v4 1/2] drivers/misc: sysgenid: add system generation id driver
Date: Wed, 27 Jan 2021 23:15:05 +0100	[thread overview]
Message-ID: <20210127221505.GB24799@amd> (raw)
In-Reply-To: <1610453760-13812-2-git-send-email-acatan@amazon.com>

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

Hi!

> - Solution
> 
> The System Generation ID is a simple concept meant to alleviate the
> issue by providing a monotonically increasing u32 counter that changes
> each time the VM or container is restored from a snapshot.

I'd make it u64.

But as people explained, this has race problems that may be impossible
to solve?

Best regards,
								Pavel
								
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  parent reply	other threads:[~2021-01-27 22:16 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-12 12:15 [PATCH v4 0/2] System Generation ID driver and VMGENID backend Adrian Catangiu
2021-01-12 12:15 ` Adrian Catangiu via
2021-01-12 12:15 ` Adrian Catangiu
2021-01-12 12:15 ` [PATCH v4 1/2] drivers/misc: sysgenid: add system generation id driver Adrian Catangiu
2021-01-12 12:15   ` Adrian Catangiu via
2021-01-12 12:15   ` Adrian Catangiu
2021-01-12 13:08   ` Greg KH
2021-01-12 13:08     ` Greg KH
2021-01-21  9:54     ` Catangiu, Adrian Costin
2021-01-21  9:54       ` acatan--- via
2021-01-12 13:08   ` Michael S. Tsirkin
2021-01-12 13:08     ` Michael S. Tsirkin
2021-01-21 12:48     ` Catangiu, Adrian Costin
2021-01-21 12:48       ` acatan--- via
2021-01-19 22:34   ` Randy Dunlap
2021-01-19 22:34     ` Randy Dunlap
2021-01-27 22:15   ` Pavel Machek [this message]
2021-01-27 22:15     ` Pavel Machek
2021-02-02 14:32     ` Michael S. Tsirkin
2021-02-02 14:32       ` Michael S. Tsirkin
2021-01-12 12:16 ` [PATCH v4 2/2] drivers/virt: vmgenid: add vm " Adrian Catangiu
2021-01-12 12:16   ` Adrian Catangiu via
2021-01-12 12:16   ` Adrian Catangiu
2021-01-12 12:48 ` [PATCH v4 0/2] System Generation ID driver and VMGENID backend Michael S. Tsirkin
2021-01-12 12:48   ` Michael S. Tsirkin
2021-01-21 10:28   ` Catangiu, Adrian Costin
2021-01-21 10:28     ` acatan--- via
2021-01-27 12:47     ` Michael S. Tsirkin
2021-01-27 12:47       ` Michael S. Tsirkin
2021-01-28 12:58       ` Alexander Graf
2021-01-28 12:58         ` graf--- via
2021-02-02 14:34         ` Michael S. Tsirkin
2021-02-02 14:34           ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210127221505.GB24799@amd \
    --to=pavel@ucw.cz \
    --cc=0x7f454c46@gmail.com \
    --cc=Jason@zx2c4.com \
    --cc=acatan@amazon.com \
    --cc=areber@redhat.com \
    --cc=arnd@arndb.de \
    --cc=asmehra@redhat.com \
    --cc=avagin@gmail.com \
    --cc=bonzini@gnu.org \
    --cc=borntraeger@de.ibm.com \
    --cc=colmmacc@amazon.com \
    --cc=corbet@lwn.net \
    --cc=dgunigun@redhat.com \
    --cc=dwmw@amazon.co.uk \
    --cc=ebiederm@xmission.com \
    --cc=ebiggers@kernel.org \
    --cc=ghammer@redhat.com \
    --cc=gil@azul.com \
    --cc=graf@amazon.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jannh@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mhocko@kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=mst@redhat.com \
    --cc=oridgar@gmail.com \
    --cc=ovzxemul@gmail.com \
    --cc=ptikhomirov@virtuozzo.com \
    --cc=qemu-devel@nongnu.org \
    --cc=raduweis@amazon.com \
    --cc=rafael@kernel.org \
    --cc=rppt@kernel.org \
    --cc=sblbir@amazon.com \
    --cc=tytso@mit.edu \
    --cc=vijaysun@ca.ibm.com \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.