All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Cc: "Thomas Huth" <thuth@redhat.com>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	qemu-block@nongnu.org, "Paul Durrant" <paul@xen.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	xen-devel@lists.xenproject.org,
	"Anthony Perard" <anthony.perard@citrix.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"John Snow" <jsnow@redhat.com>
Subject: [RFC PATCH 2/4] hw/ide/Kconfig: IDE_PIIX requires IDE_ISA
Date: Fri, 29 Jan 2021 20:44:13 +0100	[thread overview]
Message-ID: <20210129194415.3925153-3-f4bug@amsat.org> (raw)
In-Reply-To: <20210129194415.3925153-1-f4bug@amsat.org>

hw/ide/piix.c has a strong dependency on hw/isa/isa-bus.c:

  /usr/bin/ld: libcommon.fa.p/hw_ide_piix.c.o: in function `pci_piix_init_ports':
  /usr/bin/ld: hw/ide/piix.c:141: undefined reference to `isa_get_irq'

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/ide/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/ide/Kconfig b/hw/ide/Kconfig
index 41cdd9cbe03..0f5d316558b 100644
--- a/hw/ide/Kconfig
+++ b/hw/ide/Kconfig
@@ -17,6 +17,7 @@ config IDE_ISA
 
 config IDE_PIIX
     bool
+    select IDE_ISA
     select IDE_PCI
     select IDE_QDEV
 
-- 
2.26.2



WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
	"Anthony Perard" <anthony.perard@citrix.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Paul Durrant" <paul@xen.org>,
	qemu-block@nongnu.org, "John Snow" <jsnow@redhat.com>,
	xen-devel@lists.xenproject.org,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [RFC PATCH 2/4] hw/ide/Kconfig: IDE_PIIX requires IDE_ISA
Date: Fri, 29 Jan 2021 20:44:13 +0100	[thread overview]
Message-ID: <20210129194415.3925153-3-f4bug@amsat.org> (raw)
In-Reply-To: <20210129194415.3925153-1-f4bug@amsat.org>

hw/ide/piix.c has a strong dependency on hw/isa/isa-bus.c:

  /usr/bin/ld: libcommon.fa.p/hw_ide_piix.c.o: in function `pci_piix_init_ports':
  /usr/bin/ld: hw/ide/piix.c:141: undefined reference to `isa_get_irq'

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/ide/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/ide/Kconfig b/hw/ide/Kconfig
index 41cdd9cbe03..0f5d316558b 100644
--- a/hw/ide/Kconfig
+++ b/hw/ide/Kconfig
@@ -17,6 +17,7 @@ config IDE_ISA
 
 config IDE_PIIX
     bool
+    select IDE_ISA
     select IDE_PCI
     select IDE_QDEV
 
-- 
2.26.2



  parent reply	other threads:[~2021-01-29 19:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-29 19:44 [RFC PATCH 0/4] hw/xen: Fixes to only build the XEN_PV machine Philippe Mathieu-Daudé
2021-01-29 19:44 ` Philippe Mathieu-Daudé
2021-01-29 19:44 ` [RFC PATCH 1/4] hw/ide/Kconfig: IDE_ISA requires ISA_BUS Philippe Mathieu-Daudé
2021-01-29 19:44   ` Philippe Mathieu-Daudé
2021-01-29 19:59   ` Paolo Bonzini
2021-01-29 19:59     ` Paolo Bonzini
2021-01-29 19:44 ` Philippe Mathieu-Daudé [this message]
2021-01-29 19:44   ` [RFC PATCH 2/4] hw/ide/Kconfig: IDE_PIIX requires IDE_ISA Philippe Mathieu-Daudé
2021-01-29 20:00   ` Paolo Bonzini
2021-01-29 20:00     ` Paolo Bonzini
2021-01-29 19:44 ` [RFC PATCH 3/4] hw/xen/Kconfig: Introduce XEN_PV config Philippe Mathieu-Daudé
2021-01-29 19:44   ` Philippe Mathieu-Daudé
2021-01-29 20:01   ` Paolo Bonzini
2021-01-29 20:01     ` Paolo Bonzini
2021-01-29 19:44 ` [RFC PATCH 4/4] hw/xen: Have the xenpv machine select 9pfs Philippe Mathieu-Daudé
2021-01-29 19:44   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210129194415.3925153-3-f4bug@amsat.org \
    --to=f4bug@amsat.org \
    --cc=alex.bennee@linaro.org \
    --cc=anthony.perard@citrix.com \
    --cc=jsnow@redhat.com \
    --cc=paul@xen.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sstabellini@kernel.org \
    --cc=thuth@redhat.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.