From: Alexander Lobakin <alobakin@pm.me>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Alexander Lobakin <alobakin@pm.me>,
"David S. Miller" <davem@davemloft.net>,
David Rientjes <rientjes@google.com>,
Yisen Zhuang <yisen.zhuang@huawei.com>,
Salil Mehta <salil.mehta@huawei.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Jonathan Lemon <jonathan.lemon@gmail.com>,
Willem de Bruijn <willemb@google.com>,
Randy Dunlap <rdunlap@infradead.org>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Dexuan Cui <decui@microsoft.com>,
Jakub Sitnicki <jakub@cloudflare.com>,
Marco Elver <elver@google.com>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v2 net-next 3/4] net: introduce common dev_page_is_reserved()
Date: Sat, 30 Jan 2021 15:42:29 +0000 [thread overview]
Message-ID: <20210130154149.8107-1-alobakin@pm.me> (raw)
In-Reply-To: <20210129183907.2ae5ca3d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
From: Jakub Kicinski <kuba@kernel.org>
Date: Fri, 29 Jan 2021 18:39:07 -0800
> On Wed, 27 Jan 2021 20:11:23 +0000 Alexander Lobakin wrote:
> > + * dev_page_is_reserved - check whether a page can be reused for network Rx
> > + * @page: the page to test
> > + *
> > + * A page shouldn't be considered for reusing/recycling if it was allocated
> > + * under memory pressure or at a distant memory node.
> > + *
> > + * Returns true if this page should be returned to page allocator, false
> > + * otherwise.
> > + */
> > +static inline bool dev_page_is_reserved(const struct page *page)
>
> Am I the only one who feels like "reusable" is a better term than
> "reserved".
I thought about it, but this will need to inverse the conditions in
most of the drivers. I decided to keep it as it is.
I can redo if "reusable" is preferred.
Regarding "no objectives to take patch 1 through net-next": patches
2-3 depend on it, so I can't put it in a separate series.
Thanks,
Al
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Lobakin <alobakin@pm.me>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v2 net-next 3/4] net: introduce common dev_page_is_reserved()
Date: Sat, 30 Jan 2021 15:42:29 +0000 [thread overview]
Message-ID: <20210130154149.8107-1-alobakin@pm.me> (raw)
In-Reply-To: <20210129183907.2ae5ca3d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
From: Jakub Kicinski <kuba@kernel.org>
Date: Fri, 29 Jan 2021 18:39:07 -0800
> On Wed, 27 Jan 2021 20:11:23 +0000 Alexander Lobakin wrote:
> > + * dev_page_is_reserved - check whether a page can be reused for network Rx
> > + * @page: the page to test
> > + *
> > + * A page shouldn't be considered for reusing/recycling if it was allocated
> > + * under memory pressure or at a distant memory node.
> > + *
> > + * Returns true if this page should be returned to page allocator, false
> > + * otherwise.
> > + */
> > +static inline bool dev_page_is_reserved(const struct page *page)
>
> Am I the only one who feels like "reusable" is a better term than
> "reserved".
I thought about it, but this will need to inverse the conditions in
most of the drivers. I decided to keep it as it is.
I can redo if "reusable" is preferred.
Regarding "no objectives to take patch 1 through net-next": patches
2-3 depend on it, so I can't put it in a separate series.
Thanks,
Al
next prev parent reply other threads:[~2021-01-30 15:48 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 20:10 [PATCH v2 net-next 0/4] net: consolidate page_is_pfmemalloc() usage Alexander Lobakin
2021-01-27 20:10 ` [Intel-wired-lan] " Alexander Lobakin
2021-01-27 20:11 ` [PATCH v2 net-next 1/4] mm: constify page_is_pfmemalloc() argument Alexander Lobakin
2021-01-27 20:11 ` [Intel-wired-lan] " Alexander Lobakin
2021-01-28 22:44 ` David Rientjes
2021-01-28 22:44 ` [Intel-wired-lan] " David Rientjes
2021-01-28 22:44 ` David Rientjes
2021-01-30 2:30 ` Jakub Kicinski
2021-01-30 2:30 ` [Intel-wired-lan] " Jakub Kicinski
2021-01-27 20:11 ` [PATCH v2 net-next 2/4] skbuff: constify skb_propagate_pfmemalloc() "page" argument Alexander Lobakin
2021-01-27 20:11 ` [Intel-wired-lan] " Alexander Lobakin
2021-01-28 22:45 ` David Rientjes
2021-01-28 22:45 ` [Intel-wired-lan] " David Rientjes
2021-01-28 22:45 ` David Rientjes
2021-01-27 20:11 ` [PATCH v2 net-next 3/4] net: introduce common dev_page_is_reserved() Alexander Lobakin
2021-01-27 20:11 ` [Intel-wired-lan] " Alexander Lobakin
2021-01-27 21:47 ` Jesse Brandeburg
2021-01-27 21:47 ` [Intel-wired-lan] " Jesse Brandeburg
2021-01-28 22:48 ` David Rientjes
2021-01-28 22:48 ` [Intel-wired-lan] " David Rientjes
2021-01-28 22:48 ` David Rientjes
2021-01-30 2:39 ` Jakub Kicinski
2021-01-30 2:39 ` [Intel-wired-lan] " Jakub Kicinski
2021-01-30 15:42 ` Alexander Lobakin [this message]
2021-01-30 15:42 ` Alexander Lobakin
2021-01-30 19:07 ` Jakub Kicinski
2021-01-30 19:07 ` [Intel-wired-lan] " Jakub Kicinski
2021-01-30 19:45 ` Alexander Lobakin
2021-01-30 19:45 ` [Intel-wired-lan] " Alexander Lobakin
2021-01-30 21:23 ` John Hubbard
2021-01-30 21:23 ` [Intel-wired-lan] " John Hubbard
2021-01-27 20:11 ` [PATCH v2 net-next 4/4] net: page_pool: simplify page recycling condition tests Alexander Lobakin
2021-01-27 20:11 ` [Intel-wired-lan] " Alexander Lobakin
2021-01-28 22:49 ` David Rientjes
2021-01-28 22:49 ` [Intel-wired-lan] " David Rientjes
2021-01-28 22:49 ` David Rientjes
2021-01-27 21:52 ` [PATCH v2 net-next 0/4] net: consolidate page_is_pfmemalloc() usage Jesse Brandeburg
2021-01-27 21:52 ` [Intel-wired-lan] " Jesse Brandeburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210130154149.8107-1-alobakin@pm.me \
--to=alobakin@pm.me \
--cc=akpm@linux-foundation.org \
--cc=anthony.l.nguyen@intel.com \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=elver@google.com \
--cc=ilias.apalodimas@linaro.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jakub@cloudflare.com \
--cc=jesse.brandeburg@intel.com \
--cc=jonathan.lemon@gmail.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=rdunlap@infradead.org \
--cc=rientjes@google.com \
--cc=saeedm@nvidia.com \
--cc=salil.mehta@huawei.com \
--cc=willemb@google.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.