From: Leon Romanovsky <leon@kernel.org> To: Gal Pressman <galpress@amazon.com>, Jianxin Xiong <jianxin.xiong@intel.com> Cc: linux-rdma@vger.kernel.org, dri-devel@lists.freedesktop.org, Doug Ledford <dledford@redhat.com>, Jason Gunthorpe <jgg@ziepe.ca>, Sumit Semwal <sumit.semwal@linaro.org>, Christian Koenig <christian.koenig@amd.com>, Daniel Vetter <daniel.vetter@intel.com>, Edward Srouji <edwards@nvidia.com>, Yishai Hadas <yishaih@nvidia.com> Subject: Re: [PATCH rdma-core v7 4/6] pyverbs: Add dma-buf based MR support Date: Mon, 1 Feb 2021 08:16:03 +0200 [thread overview] Message-ID: <20210201061603.GC4593@unreal> (raw) In-Reply-To: <137f406b-d3e0-fdeb-18e7-194a2aed927c@amazon.com> On Sun, Jan 31, 2021 at 05:31:16PM +0200, Gal Pressman wrote: > On 25/01/2021 21:57, Jianxin Xiong wrote: > > Define a new sub-class of 'MR' that uses dma-buf object for the memory > > region. Define a new class 'DmaBuf' as a wrapper for dma-buf allocation > > mechanism implemented in C. > > > > Update the cmake function for cython modules to allow building modules > > with mixed cython and c source files. > > > > Signed-off-by: Jianxin Xiong <jianxin.xiong@intel.com> > > --- > > buildlib/pyverbs_functions.cmake | 78 +++++++---- > > pyverbs/CMakeLists.txt | 11 +- > > pyverbs/dmabuf.pxd | 15 +++ > > pyverbs/dmabuf.pyx | 73 ++++++++++ > > pyverbs/dmabuf_alloc.c | 278 +++++++++++++++++++++++++++++++++++++++ > > pyverbs/dmabuf_alloc.h | 19 +++ > > pyverbs/libibverbs.pxd | 2 + > > pyverbs/mr.pxd | 6 + > > pyverbs/mr.pyx | 105 ++++++++++++++- > > 9 files changed, 557 insertions(+), 30 deletions(-) > > create mode 100644 pyverbs/dmabuf.pxd > > create mode 100644 pyverbs/dmabuf.pyx > > create mode 100644 pyverbs/dmabuf_alloc.c > > create mode 100644 pyverbs/dmabuf_alloc.h <...> > > index 0000000..05eae75 > > --- /dev/null > > +++ b/pyverbs/dmabuf_alloc.c > > @@ -0,0 +1,278 @@ > > +// SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB > > +/* > > + * Copyright 2020 Intel Corporation. All rights reserved. See COPYING file > > + */ > > + > > +#include <stdio.h> > > +#include <stdlib.h> > > +#include <stdint.h> > > +#include <unistd.h> > > +#include <string.h> > > +#include <errno.h> > > +#include <drm/drm.h> > > +#include <drm/i915_drm.h> > > +#include <drm/amdgpu_drm.h> > > +#include <drm/radeon_drm.h> > > I assume these should come from the kernel headers package, right? This is gross, all kernel headers should be placed in kernel-headers/* and "update" script needs to be extended to take drm/* files too :(. Jianxin, are you fixing it? Thanks
WARNING: multiple messages have this Message-ID (diff)
From: Leon Romanovsky <leon@kernel.org> To: Gal Pressman <galpress@amazon.com>, Jianxin Xiong <jianxin.xiong@intel.com> Cc: Yishai Hadas <yishaih@nvidia.com>, linux-rdma@vger.kernel.org, Edward Srouji <edwards@nvidia.com>, dri-devel@lists.freedesktop.org, Christian Koenig <christian.koenig@amd.com>, Jason Gunthorpe <jgg@ziepe.ca>, Doug Ledford <dledford@redhat.com>, Daniel Vetter <daniel.vetter@intel.com> Subject: Re: [PATCH rdma-core v7 4/6] pyverbs: Add dma-buf based MR support Date: Mon, 1 Feb 2021 08:16:03 +0200 [thread overview] Message-ID: <20210201061603.GC4593@unreal> (raw) In-Reply-To: <137f406b-d3e0-fdeb-18e7-194a2aed927c@amazon.com> On Sun, Jan 31, 2021 at 05:31:16PM +0200, Gal Pressman wrote: > On 25/01/2021 21:57, Jianxin Xiong wrote: > > Define a new sub-class of 'MR' that uses dma-buf object for the memory > > region. Define a new class 'DmaBuf' as a wrapper for dma-buf allocation > > mechanism implemented in C. > > > > Update the cmake function for cython modules to allow building modules > > with mixed cython and c source files. > > > > Signed-off-by: Jianxin Xiong <jianxin.xiong@intel.com> > > --- > > buildlib/pyverbs_functions.cmake | 78 +++++++---- > > pyverbs/CMakeLists.txt | 11 +- > > pyverbs/dmabuf.pxd | 15 +++ > > pyverbs/dmabuf.pyx | 73 ++++++++++ > > pyverbs/dmabuf_alloc.c | 278 +++++++++++++++++++++++++++++++++++++++ > > pyverbs/dmabuf_alloc.h | 19 +++ > > pyverbs/libibverbs.pxd | 2 + > > pyverbs/mr.pxd | 6 + > > pyverbs/mr.pyx | 105 ++++++++++++++- > > 9 files changed, 557 insertions(+), 30 deletions(-) > > create mode 100644 pyverbs/dmabuf.pxd > > create mode 100644 pyverbs/dmabuf.pyx > > create mode 100644 pyverbs/dmabuf_alloc.c > > create mode 100644 pyverbs/dmabuf_alloc.h <...> > > index 0000000..05eae75 > > --- /dev/null > > +++ b/pyverbs/dmabuf_alloc.c > > @@ -0,0 +1,278 @@ > > +// SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB > > +/* > > + * Copyright 2020 Intel Corporation. All rights reserved. See COPYING file > > + */ > > + > > +#include <stdio.h> > > +#include <stdlib.h> > > +#include <stdint.h> > > +#include <unistd.h> > > +#include <string.h> > > +#include <errno.h> > > +#include <drm/drm.h> > > +#include <drm/i915_drm.h> > > +#include <drm/amdgpu_drm.h> > > +#include <drm/radeon_drm.h> > > I assume these should come from the kernel headers package, right? This is gross, all kernel headers should be placed in kernel-headers/* and "update" script needs to be extended to take drm/* files too :(. Jianxin, are you fixing it? Thanks _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-02-01 6:34 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-25 19:56 [PATCH rdma-core v7 0/6] Add user space dma-buf support Jianxin Xiong 2021-01-25 19:56 ` Jianxin Xiong 2021-01-25 19:56 ` [PATCH rdma-core v7 1/6] Update kernel headers Jianxin Xiong 2021-01-25 19:56 ` Jianxin Xiong 2021-01-25 19:56 ` [PATCH rdma-core v7 2/6] verbs: Support dma-buf based memory region Jianxin Xiong 2021-01-25 19:56 ` Jianxin Xiong 2021-01-25 19:56 ` [PATCH rdma-core v7 3/6] mlx5: " Jianxin Xiong 2021-01-25 19:56 ` Jianxin Xiong 2021-01-25 19:57 ` [PATCH rdma-core v7 4/6] pyverbs: Add dma-buf based MR support Jianxin Xiong 2021-01-25 19:57 ` Jianxin Xiong 2021-01-31 15:31 ` Gal Pressman 2021-01-31 15:31 ` Gal Pressman 2021-02-01 6:16 ` Leon Romanovsky [this message] 2021-02-01 6:16 ` Leon Romanovsky 2021-02-01 14:10 ` Daniel Vetter 2021-02-01 14:10 ` Daniel Vetter 2021-02-01 15:29 ` Jason Gunthorpe 2021-02-01 15:29 ` Jason Gunthorpe 2021-02-01 17:03 ` Xiong, Jianxin 2021-02-01 17:03 ` Xiong, Jianxin 2021-02-02 15:24 ` Daniel Vetter 2021-02-02 15:24 ` Daniel Vetter 2021-02-03 6:03 ` Leon Romanovsky 2021-02-03 6:03 ` Leon Romanovsky 2021-02-03 16:57 ` Xiong, Jianxin 2021-02-03 16:57 ` Xiong, Jianxin 2021-02-03 17:53 ` Daniel Vetter 2021-02-03 17:53 ` Daniel Vetter 2021-02-03 17:56 ` Jason Gunthorpe 2021-02-03 17:56 ` Jason Gunthorpe 2021-02-03 17:58 ` Xiong, Jianxin 2021-02-03 17:58 ` Xiong, Jianxin 2021-02-03 18:14 ` Emil Velikov 2021-02-03 18:14 ` Emil Velikov 2021-01-25 19:57 ` [PATCH rdma-core v7 5/6] tests: Add tests for dma-buf based memory regions Jianxin Xiong 2021-01-25 19:57 ` Jianxin Xiong 2021-01-31 8:44 ` John Hubbard 2021-01-31 8:44 ` John Hubbard 2021-02-01 17:12 ` Xiong, Jianxin 2021-02-01 17:12 ` Xiong, Jianxin 2021-01-25 19:57 ` [PATCH rdma-core v7 6/6] tests: Bug fix for get_access_flags() Jianxin Xiong 2021-01-25 19:57 ` Jianxin Xiong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210201061603.GC4593@unreal \ --to=leon@kernel.org \ --cc=christian.koenig@amd.com \ --cc=daniel.vetter@intel.com \ --cc=dledford@redhat.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=edwards@nvidia.com \ --cc=galpress@amazon.com \ --cc=jgg@ziepe.ca \ --cc=jianxin.xiong@intel.com \ --cc=linux-rdma@vger.kernel.org \ --cc=sumit.semwal@linaro.org \ --cc=yishaih@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.