Re: [PATCH] mailbox: arm_mhuv2: make remove callback return void

From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "Russell King" <linux+pull@armlinux.org.uk>,
	"Mathieu Poirier" <mathieu.poirier@linaro.org>,
	"Suzuki K Poulose" <suzuki.poulose@arm.com>,
	"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Tushar Khandelwal" <Tushar.Khandelwal@arm.com>,
	"Jassi Brar" <jassisinghbrar@gmail.com>,
	linux-fbdev@vger.kernel.org, "Cornelia Huck" <cohuck@redhat.com>,
	kvm@vger.kernel.org, "David Airlie" <airlied@linux.ie>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Eric Anholt" <eric@anholt.net>,
	"Uwe Kleine-König" <u.kleine-koenig.org@pengutronix.de>,
	linux-i2c@vger.kernel.org, "Jiri Slaby" <jirislaby@kernel.org>,
	linux-stm32@st-md-mailman.stormreply.com,
	"Alexandre Torgue" <alexandre.torgue@st.com>,
	linux-rtc@vger.kernel.org,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	"Takashi Iwai" <tiwai@suse.com>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	linux-serial@vger.kernel.org, linux-input@vger.kernel.org,
	"Ulf Hansson" <ulf.hansson@linaro.org>,
	"Guenter Roeck" <linux@roeck-us.net>,
	"Mike Leach" <mike.leach@linaro.org>,
	linux-watchdog@vger.kernel.org, "Arnd Bergmann" <arnd@arndb.de>,
	"Alessandro Zummo" <a.zummo@towertech.it>,
	coresight@lists.linaro.org, "Vladimir Zapolskiy" <vz@mleia.com>,
	"Eric Auger" <eric.auger@redhat.com>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Matt Mackall" <mpm@selenic.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Wim Van Sebroeck" <wim@linux-watchdog.org>,
	linux-arm-kernel@lists.infradead.org,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-spi@vger.kernel.org, "Vinod Koul" <vkoul@kernel.org>,
	linux-crypto@vger.kernel.org, kernel@pengutronix.de,
	"Leo Yan" <leo.yan@linaro.org>,
	dmaengine@vger.kernel.org
Subject: Re: [PATCH] mailbox: arm_mhuv2: make remove callback return void
Date: Wed, 3 Feb 2021 08:27:43 +0530	[thread overview]
Message-ID: <20210203025743.uffbfdjsubsjbfrc@vireshk-i7> (raw)
In-Reply-To: <20210202194308.jm66vblqjwr5wo6v@pengutronix.de>

On 02-02-21, 20:43, Uwe Kleine-König wrote:
> My build tests failed to catch that amba driver that would have needed
> adaption in commit 3fd269e74f2f ("amba: Make the remove callback return
> void"). Change the remove function to make the driver build again.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 3fd269e74f2f ("amba: Make the remove callback return void")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
> 
> I guess I missed that driver during rebase as it was only introduced in
> the last merge window. Sorry for that.
> 
> I'm unsure what is the right thing to do now. Should I redo the pull
> request (with this patch squashed into 3fd269e74f2f)? Or do we just
> apply this patch on top?
> 
> FTR, the test robot report is at https://lore.kernel.org/r/202102030343.D9j1wukx-lkp@intel.com
> 
> Best regards
> Uwe
> 
>  drivers/mailbox/arm_mhuv2.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/mailbox/arm_mhuv2.c b/drivers/mailbox/arm_mhuv2.c
> index 67fb10885bb4..6cf1991a5c9c 100644
> --- a/drivers/mailbox/arm_mhuv2.c
> +++ b/drivers/mailbox/arm_mhuv2.c
> @@ -1095,14 +1095,12 @@ static int mhuv2_probe(struct amba_device *adev, const struct amba_id *id)
>  	return ret;
>  }
>  
> -static int mhuv2_remove(struct amba_device *adev)
> +static void mhuv2_remove(struct amba_device *adev)
>  {
>  	struct mhuv2 *mhu = amba_get_drvdata(adev);
>  
>  	if (mhu->frame == SENDER_FRAME)
>  		writel_relaxed(0x0, &mhu->send->access_request);
> -
> -	return 0;
>  }
>  
>  static struct amba_id mhuv2_ids[] = {

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh