All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Vasyl Vavrychuk <vasyl.vavrychuk@opensynergy.com>
Cc: virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Henrik Rydberg <rydberg@bitmath.org>,
	Mathias Crombez <mathias.crombez@faurecia.com>
Subject: Re: [PATCH RESEND v3] virtio-input: add multi-touch support
Date: Wed, 3 Feb 2021 15:22:39 +0100	[thread overview]
Message-ID: <20210203142239.7lknkkg4zx5kuaf2@sirius.home.kraxel.org> (raw)
In-Reply-To: <20210115002623.8576-1-vasyl.vavrychuk@opensynergy.com>

On Fri, Jan 15, 2021 at 02:26:23AM +0200, Vasyl Vavrychuk wrote:
> From: Mathias Crombez <mathias.crombez@faurecia.com>
> 
> Without multi-touch slots allocated, ABS_MT_SLOT events will be lost by
> input_handle_abs_event.
> 
> Implementation is based on uinput_create_device.
> 
> Signed-off-by: Mathias Crombez <mathias.crombez@faurecia.com>
> Co-developed-by: Vasyl Vavrychuk <vasyl.vavrychuk@opensynergy.com>
> Signed-off-by: Vasyl Vavrychuk <vasyl.vavrychuk@opensynergy.com>
> ---
> v2: fix patch corrupted by corporate email server
> v3: use number of slots from the host
> 
> Resend since to feedback.
> 
>  drivers/virtio/virtio_input.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)

Have no test hardware, the logic looks sane though.

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd


WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com>
To: Vasyl Vavrychuk <vasyl.vavrychuk@opensynergy.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	Henrik Rydberg <rydberg@bitmath.org>,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	Mathias Crombez <mathias.crombez@faurecia.com>,
	linux-input@vger.kernel.org
Subject: Re: [PATCH RESEND v3] virtio-input: add multi-touch support
Date: Wed, 3 Feb 2021 15:22:39 +0100	[thread overview]
Message-ID: <20210203142239.7lknkkg4zx5kuaf2@sirius.home.kraxel.org> (raw)
In-Reply-To: <20210115002623.8576-1-vasyl.vavrychuk@opensynergy.com>

On Fri, Jan 15, 2021 at 02:26:23AM +0200, Vasyl Vavrychuk wrote:
> From: Mathias Crombez <mathias.crombez@faurecia.com>
> 
> Without multi-touch slots allocated, ABS_MT_SLOT events will be lost by
> input_handle_abs_event.
> 
> Implementation is based on uinput_create_device.
> 
> Signed-off-by: Mathias Crombez <mathias.crombez@faurecia.com>
> Co-developed-by: Vasyl Vavrychuk <vasyl.vavrychuk@opensynergy.com>
> Signed-off-by: Vasyl Vavrychuk <vasyl.vavrychuk@opensynergy.com>
> ---
> v2: fix patch corrupted by corporate email server
> v3: use number of slots from the host
> 
> Resend since to feedback.
> 
>  drivers/virtio/virtio_input.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)

Have no test hardware, the logic looks sane though.

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  parent reply	other threads:[~2021-02-03 14:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-15  0:26 [PATCH RESEND v3] virtio-input: add multi-touch support Vasyl Vavrychuk
2021-01-15  0:26 ` Vasyl Vavrychuk
2021-01-29 12:06 ` Vasyl Vavrychuk
2021-01-29 15:26   ` Michael S. Tsirkin
2021-02-02  0:17     ` Colin Xu
2021-02-02  0:17       ` Colin Xu
2021-02-03 14:22 ` Gerd Hoffmann [this message]
2021-02-03 14:22   ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210203142239.7lknkkg4zx5kuaf2@sirius.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathias.crombez@faurecia.com \
    --cc=mst@redhat.com \
    --cc=rydberg@bitmath.org \
    --cc=vasyl.vavrychuk@opensynergy.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.