From: Lee Jones <lee.jones@linaro.org> To: Hans de Goede <hdegoede@redhat.com> Cc: Cezary Rojewski <cezary.rojewski@intel.com>, Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, Liam Girdwood <liam.r.girdwood@linux.intel.com>, Jie Yang <yang.jie@linux.intel.com>, Mark Brown <broonie@kernel.org>, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, Andy Shevchenko <andy.shevchenko@gmail.com>, Charles Keepax <ckeepax@opensource.cirrus.com>, alsa-devel@alsa-project.org Subject: Re: [PATCH v4 00/13] MFD/extcon/ASoC: Rework arizona codec jack-detect support Date: Thu, 4 Feb 2021 11:05:39 +0000 [thread overview] Message-ID: <20210204110539.GE2789116@dell> (raw) In-Reply-To: <20210123121313.79530-1-hdegoede@redhat.com> On Sat, 23 Jan 2021, Hans de Goede wrote: > Hi all, > > Here is v4 of my series to rework the arizona codec jack-detect support > to use the snd_soc_jack helpers instead of direct extcon reporting. > > This is done by reworking the extcon driver into an arizona-jackdet > library and then modifying the codec drivers to use that directly, > replacing the old separate extcon child-devices and extcon-driver. > > This brings the arizona-codec jack-detect handling inline with how > all other ASoC codec driver do this. This was developed and tested on > a Lenovo Yoga Tablet 1051L with a WM5102 codec. > > There are various interdependencies between the patches in this > series, so IMHO it would be best if this entire series would be merged > through the MFD tree. > > Note this series applies on top of my "[PATCH v4 0/5] MFD/ASoC: Add > support for Intel Bay Trail boards with WM5102 codec" series. > > Changes in v4: > - Add sound/soc/codecs/arizona-jack.c to the WOLFSON MICROELECTRONICS DRIVERS > MAINTAINERS section > - Small codying style tweaks to the "ASoC: arizona-jack: Cleanup logging" patch > > Changes in v3: > - Move the bugfix patches to earlier in the series so that they > apply to drivers/extcon/extcon-arizona.c so that they can be > cherry-picked into the stable series > - Split runtime_pm_get -> runtime_pm_get_sync changes out into their > own patch > - Simply move drivers/extcon/extcon-arizona.c to > sound/soc/codecs/arizona-jack.c instead of first adding arizona-jack.c > as a copy and then later removing extcon-arizona.c > - Some other small tweaks, see individual patch changelogs > > Regards, > > Hans > > > Hans de Goede (13): > mfd: arizona: Drop arizona-extcon cells > extcon: arizona: Fix some issues when HPDET IRQ fires after the jack > has been unplugged > extcon: arizona: Fix various races on driver unbind > extcon: arizona: Fix flags parameter to the gpiod_get("wlf,micd-pol") > call > extcon: arizona: Always use pm_runtime_get_sync() when we need the > device to be awake > ASoC/extcon: arizona: Move arizona jack code to > sound/soc/codecs/arizona-jack.c > ASoC: arizona-jack: Move jack-detect variables to struct arizona_priv > ASoC: arizona-jack: Use arizona->dev for runtime-pm > ASoC: arizona-jack: convert into a helper library for codec drivers > ASoC: arizona-jack: Use snd_soc_jack to report jack events > ASoC: arizona-jack: Cleanup logging > ASoC: arizona: Make the wm5102, wm5110, wm8997 and wm8998 drivers use > the new jack library > ASoC: Intel: bytcr_wm5102: Add jack detect support Can't apply this patch ... > MAINTAINERS | 3 +- > drivers/extcon/Kconfig | 8 - > drivers/extcon/Makefile | 1 - > drivers/mfd/arizona-core.c | 20 - > sound/soc/codecs/Makefile | 2 +- > .../soc/codecs/arizona-jack.c | 577 +++++++----------- > sound/soc/codecs/arizona.h | 44 ++ > sound/soc/codecs/wm5102.c | 12 +- > sound/soc/codecs/wm5110.c | 12 +- > sound/soc/codecs/wm8997.c | 14 +- > sound/soc/codecs/wm8998.c | 9 + > sound/soc/intel/boards/bytcr_wm5102.c | 28 +- ... since this file doesn't exist? > 12 files changed, 325 insertions(+), 405 deletions(-) > rename drivers/extcon/extcon-arizona.c => sound/soc/codecs/arizona-jack.c (76%) > -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org> To: Hans de Goede <hdegoede@redhat.com> Cc: Cezary Rojewski <cezary.rojewski@intel.com>, Charles Keepax <ckeepax@opensource.cirrus.com>, alsa-devel@alsa-project.org, patches@opensource.cirrus.com, Jie Yang <yang.jie@linux.intel.com>, Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, linux-kernel@vger.kernel.org, Liam Girdwood <liam.r.girdwood@linux.intel.com>, Andy Shevchenko <andy.shevchenko@gmail.com>, Mark Brown <broonie@kernel.org> Subject: Re: [PATCH v4 00/13] MFD/extcon/ASoC: Rework arizona codec jack-detect support Date: Thu, 4 Feb 2021 11:05:39 +0000 [thread overview] Message-ID: <20210204110539.GE2789116@dell> (raw) In-Reply-To: <20210123121313.79530-1-hdegoede@redhat.com> On Sat, 23 Jan 2021, Hans de Goede wrote: > Hi all, > > Here is v4 of my series to rework the arizona codec jack-detect support > to use the snd_soc_jack helpers instead of direct extcon reporting. > > This is done by reworking the extcon driver into an arizona-jackdet > library and then modifying the codec drivers to use that directly, > replacing the old separate extcon child-devices and extcon-driver. > > This brings the arizona-codec jack-detect handling inline with how > all other ASoC codec driver do this. This was developed and tested on > a Lenovo Yoga Tablet 1051L with a WM5102 codec. > > There are various interdependencies between the patches in this > series, so IMHO it would be best if this entire series would be merged > through the MFD tree. > > Note this series applies on top of my "[PATCH v4 0/5] MFD/ASoC: Add > support for Intel Bay Trail boards with WM5102 codec" series. > > Changes in v4: > - Add sound/soc/codecs/arizona-jack.c to the WOLFSON MICROELECTRONICS DRIVERS > MAINTAINERS section > - Small codying style tweaks to the "ASoC: arizona-jack: Cleanup logging" patch > > Changes in v3: > - Move the bugfix patches to earlier in the series so that they > apply to drivers/extcon/extcon-arizona.c so that they can be > cherry-picked into the stable series > - Split runtime_pm_get -> runtime_pm_get_sync changes out into their > own patch > - Simply move drivers/extcon/extcon-arizona.c to > sound/soc/codecs/arizona-jack.c instead of first adding arizona-jack.c > as a copy and then later removing extcon-arizona.c > - Some other small tweaks, see individual patch changelogs > > Regards, > > Hans > > > Hans de Goede (13): > mfd: arizona: Drop arizona-extcon cells > extcon: arizona: Fix some issues when HPDET IRQ fires after the jack > has been unplugged > extcon: arizona: Fix various races on driver unbind > extcon: arizona: Fix flags parameter to the gpiod_get("wlf,micd-pol") > call > extcon: arizona: Always use pm_runtime_get_sync() when we need the > device to be awake > ASoC/extcon: arizona: Move arizona jack code to > sound/soc/codecs/arizona-jack.c > ASoC: arizona-jack: Move jack-detect variables to struct arizona_priv > ASoC: arizona-jack: Use arizona->dev for runtime-pm > ASoC: arizona-jack: convert into a helper library for codec drivers > ASoC: arizona-jack: Use snd_soc_jack to report jack events > ASoC: arizona-jack: Cleanup logging > ASoC: arizona: Make the wm5102, wm5110, wm8997 and wm8998 drivers use > the new jack library > ASoC: Intel: bytcr_wm5102: Add jack detect support Can't apply this patch ... > MAINTAINERS | 3 +- > drivers/extcon/Kconfig | 8 - > drivers/extcon/Makefile | 1 - > drivers/mfd/arizona-core.c | 20 - > sound/soc/codecs/Makefile | 2 +- > .../soc/codecs/arizona-jack.c | 577 +++++++----------- > sound/soc/codecs/arizona.h | 44 ++ > sound/soc/codecs/wm5102.c | 12 +- > sound/soc/codecs/wm5110.c | 12 +- > sound/soc/codecs/wm8997.c | 14 +- > sound/soc/codecs/wm8998.c | 9 + > sound/soc/intel/boards/bytcr_wm5102.c | 28 +- ... since this file doesn't exist? > 12 files changed, 325 insertions(+), 405 deletions(-) > rename drivers/extcon/extcon-arizona.c => sound/soc/codecs/arizona-jack.c (76%) > -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-02-04 11:06 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-23 12:13 [PATCH v4 00/13] MFD/extcon/ASoC: Rework arizona codec jack-detect support Hans de Goede 2021-01-23 12:13 ` Hans de Goede 2021-01-23 12:13 ` [PATCH v4 01/13] mfd: arizona: Drop arizona-extcon cells Hans de Goede 2021-01-23 12:13 ` Hans de Goede 2021-01-30 14:41 ` Charles Keepax 2021-01-30 14:41 ` Charles Keepax 2021-01-23 12:13 ` [PATCH v4 02/13] extcon: arizona: Fix some issues when HPDET IRQ fires after the jack has been unplugged Hans de Goede 2021-01-23 12:13 ` Hans de Goede 2021-01-30 14:43 ` Charles Keepax 2021-01-30 14:43 ` Charles Keepax 2021-01-23 12:13 ` [PATCH v4 03/13] extcon: arizona: Fix various races on driver unbind Hans de Goede 2021-01-23 12:13 ` Hans de Goede 2021-01-30 14:56 ` Charles Keepax 2021-01-30 14:56 ` Charles Keepax 2021-01-23 12:13 ` [PATCH v4 04/13] extcon: arizona: Fix flags parameter to the gpiod_get("wlf,micd-pol") call Hans de Goede 2021-01-23 12:13 ` [PATCH v4 04/13] extcon: arizona: Fix flags parameter to the gpiod_get("wlf, micd-pol") call Hans de Goede 2021-01-23 12:13 ` [PATCH v4 05/13] extcon: arizona: Always use pm_runtime_get_sync() when we need the device to be awake Hans de Goede 2021-01-23 12:13 ` Hans de Goede 2021-01-23 16:41 ` Charles Keepax 2021-01-23 16:41 ` Charles Keepax 2021-01-30 14:57 ` Charles Keepax 2021-01-30 14:57 ` Charles Keepax 2021-01-23 12:13 ` [PATCH v4 06/13] ASoC/extcon: arizona: Move arizona jack code to sound/soc/codecs/arizona-jack.c Hans de Goede 2021-01-23 12:13 ` Hans de Goede 2021-01-30 14:58 ` Charles Keepax 2021-01-30 14:58 ` Charles Keepax 2021-01-23 12:13 ` [PATCH v4 07/13] ASoC: arizona-jack: Move jack-detect variables to struct arizona_priv Hans de Goede 2021-01-23 12:13 ` Hans de Goede 2021-01-30 15:15 ` Charles Keepax 2021-01-30 15:15 ` Charles Keepax 2021-01-23 12:13 ` [PATCH v4 08/13] ASoC: arizona-jack: Use arizona->dev for runtime-pm Hans de Goede 2021-01-23 12:13 ` Hans de Goede 2021-01-30 15:16 ` Charles Keepax 2021-01-30 15:16 ` Charles Keepax 2021-01-23 12:13 ` [PATCH v4 09/13] ASoC: arizona-jack: convert into a helper library for codec drivers Hans de Goede 2021-01-23 12:13 ` Hans de Goede 2021-01-30 15:25 ` Charles Keepax 2021-01-30 15:25 ` Charles Keepax 2021-01-23 12:17 ` [PATCH v4 10/13] ASoC: arizona-jack: Use snd_soc_jack to report jack events Hans de Goede 2021-01-23 12:17 ` Hans de Goede 2021-01-23 12:17 ` [PATCH v4 11/13] ASoC: arizona-jack: Cleanup logging Hans de Goede 2021-01-23 12:17 ` Hans de Goede 2021-01-24 19:53 ` Andy Shevchenko 2021-01-24 19:53 ` Andy Shevchenko 2021-01-24 21:13 ` Hans de Goede 2021-01-24 21:13 ` Hans de Goede 2021-01-30 15:30 ` Charles Keepax 2021-01-30 15:30 ` Charles Keepax 2021-01-23 12:17 ` [PATCH v4 12/13] ASoC: arizona: Make the wm5102, wm5110, wm8997 and wm8998 drivers use the new jack library Hans de Goede 2021-01-23 12:17 ` Hans de Goede 2021-01-30 15:32 ` Charles Keepax 2021-01-30 15:32 ` Charles Keepax 2021-01-23 12:17 ` [PATCH v4 13/13] ASoC: Intel: bytcr_wm5102: Add jack detect support Hans de Goede 2021-01-23 12:17 ` Hans de Goede 2021-01-30 15:40 ` Charles Keepax 2021-01-30 15:40 ` Charles Keepax 2021-01-30 18:26 ` Hans de Goede 2021-01-30 18:26 ` Hans de Goede 2021-01-30 15:28 ` [PATCH v4 10/13] ASoC: arizona-jack: Use snd_soc_jack to report jack events Charles Keepax 2021-01-30 15:28 ` Charles Keepax 2021-02-04 11:05 ` Lee Jones [this message] 2021-02-04 11:05 ` [PATCH v4 00/13] MFD/extcon/ASoC: Rework arizona codec jack-detect support Lee Jones 2021-02-04 11:09 ` Hans de Goede 2021-02-04 11:09 ` Hans de Goede 2021-02-04 11:13 ` Lee Jones 2021-02-04 11:13 ` Lee Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210204110539.GE2789116@dell \ --to=lee.jones@linaro.org \ --cc=alsa-devel@alsa-project.org \ --cc=andy.shevchenko@gmail.com \ --cc=broonie@kernel.org \ --cc=cezary.rojewski@intel.com \ --cc=ckeepax@opensource.cirrus.com \ --cc=hdegoede@redhat.com \ --cc=liam.r.girdwood@linux.intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=patches@opensource.cirrus.com \ --cc=pierre-louis.bossart@linux.intel.com \ --cc=yang.jie@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.