From: Nathan Chancellor <nathan@kernel.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Nathan Chancellor <natechancellor@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org, Nicolas Pitre <npitre@baylibre.com>,
clang-built-linux@googlegroups.com,
linux-i3c@lists.infradead.org
Subject: Re: [PATCH] i3c/master/mipi-i3c-hci: Fix position of __maybe_unused in i3c_hci_of_match
Date: Mon, 8 Feb 2021 20:59:58 -0700 [thread overview]
Message-ID: <20210209035958.GA2059815@ubuntu-m3-large-x86> (raw)
In-Reply-To: <160943653614.132002.12499200411415721355.b4-ty@bootlin.com>
On Thu, Dec 31, 2020 at 06:42:23PM +0100, Alexandre Belloni wrote:
> On Mon, 21 Dec 2020 19:59:31 -0700, Nathan Chancellor wrote:
> > Clang warns:
> >
> > ../drivers/i3c/master/mipi-i3c-hci/core.c:780:21: warning: attribute
> > declaration must precede definition [-Wignored-attributes]
> > static const struct __maybe_unused of_device_id i3c_hci_of_match[] = {
> > ^
> > ../include/linux/compiler_attributes.h:267:56: note: expanded from macro
> > '__maybe_unused'
> > #define __maybe_unused __attribute__((__unused__))
> > ^
> > ../include/linux/mod_devicetable.h:262:8: note: previous definition is
> > here
> > struct of_device_id {
> > ^
> > 1 warning generated.
> >
> > [...]
>
> Applied, thanks!
>
> [1/1] i3c/master/mipi-i3c-hci: Fix position of __maybe_unused in i3c_hci_of_match
> commit: 291b5c9870fc546376d69cf792b7885cd0c9c1b3
>
> Best regards,
> --
> Alexandre Belloni <alexandre.belloni@bootlin.com>
>
Hi Alexandre,
I see as of v5.11-rc7 that this is still an issue even though it has
been applied to the fixes branch. Is it possible for this to make it in
to 5.11 final?
Cheers,
Nathan
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <nathan@kernel.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org, Nicolas Pitre <npitre@baylibre.com>,
clang-built-linux@googlegroups.com,
Nathan Chancellor <natechancellor@gmail.com>,
linux-i3c@lists.infradead.org
Subject: Re: [PATCH] i3c/master/mipi-i3c-hci: Fix position of __maybe_unused in i3c_hci_of_match
Date: Mon, 8 Feb 2021 20:59:58 -0700 [thread overview]
Message-ID: <20210209035958.GA2059815@ubuntu-m3-large-x86> (raw)
In-Reply-To: <160943653614.132002.12499200411415721355.b4-ty@bootlin.com>
On Thu, Dec 31, 2020 at 06:42:23PM +0100, Alexandre Belloni wrote:
> On Mon, 21 Dec 2020 19:59:31 -0700, Nathan Chancellor wrote:
> > Clang warns:
> >
> > ../drivers/i3c/master/mipi-i3c-hci/core.c:780:21: warning: attribute
> > declaration must precede definition [-Wignored-attributes]
> > static const struct __maybe_unused of_device_id i3c_hci_of_match[] = {
> > ^
> > ../include/linux/compiler_attributes.h:267:56: note: expanded from macro
> > '__maybe_unused'
> > #define __maybe_unused __attribute__((__unused__))
> > ^
> > ../include/linux/mod_devicetable.h:262:8: note: previous definition is
> > here
> > struct of_device_id {
> > ^
> > 1 warning generated.
> >
> > [...]
>
> Applied, thanks!
>
> [1/1] i3c/master/mipi-i3c-hci: Fix position of __maybe_unused in i3c_hci_of_match
> commit: 291b5c9870fc546376d69cf792b7885cd0c9c1b3
>
> Best regards,
> --
> Alexandre Belloni <alexandre.belloni@bootlin.com>
>
Hi Alexandre,
I see as of v5.11-rc7 that this is still an issue even though it has
been applied to the fixes branch. Is it possible for this to make it in
to 5.11 final?
Cheers,
Nathan
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2021-02-09 4:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 2:59 [PATCH] i3c/master/mipi-i3c-hci: Fix position of __maybe_unused in i3c_hci_of_match Nathan Chancellor
2020-12-22 2:59 ` Nathan Chancellor
2020-12-22 3:13 ` Nicolas Pitre
2020-12-22 3:13 ` Nicolas Pitre
2020-12-31 17:42 ` Alexandre Belloni
2020-12-31 17:42 ` Alexandre Belloni
2021-02-09 3:59 ` Nathan Chancellor [this message]
2021-02-09 3:59 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210209035958.GA2059815@ubuntu-m3-large-x86 \
--to=nathan@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=npitre@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.