From: Rob Herring <robh@kernel.org>
To: Liu Ying <victor.liu@nxp.com>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
airlied@linux.ie, daniel@ffwll.ch, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com, mchehab@kernel.org,
a.hajda@samsung.com, narmstrong@baylibre.com,
Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
jernej.skrabec@siol.net, kishon@ti.com, vkoul@kernel.org
Subject: Re: [PATCH v3 09/14] drm/bridge: imx: Add i.MX8qxp pixel link to DPI support
Date: Tue, 9 Feb 2021 12:15:10 -0600 [thread overview]
Message-ID: <20210209181510.GA4045547@robh.at.kernel.org> (raw)
In-Reply-To: <1611737488-2791-10-git-send-email-victor.liu@nxp.com>
On Wed, Jan 27, 2021 at 04:51:23PM +0800, Liu Ying wrote:
> This patch adds a drm bridge driver for i.MX8qxp pixel link to display
> pixel interface(PXL2DPI). The PXL2DPI interfaces the pixel link 36-bit
> data output and the DSI controller’s MIPI-DPI 24-bit data input, and
> inputs of LVDS Display Bridge(LDB) module used in LVDS mode, to remap
> the pixel color codings between those modules. The PXL2DPI is purely
> combinatorial.
>
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
> v2->v3:
> * Call syscon_node_to_regmap() to get regmap instead of
> syscon_regmap_lookup_by_phandle().
>
> v1->v2:
> * Drop unnecessary port availability check.
>
> drivers/gpu/drm/bridge/imx/Kconfig | 8 +
> drivers/gpu/drm/bridge/imx/Makefile | 1 +
> drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c | 488 +++++++++++++++++++++++++++
> 3 files changed, 497 insertions(+)
> create mode 100644 drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c
> + p2d->regmap = syscon_node_to_regmap(np->parent);
> + if (IS_ERR(p2d->regmap)) {
> + ret = PTR_ERR(p2d->regmap);
> + if (ret != -EPROBE_DEFER)
> + DRM_DEV_ERROR(dev, "failed to get regmap: %d\n", ret);
> + return ret;
> + }
> +
> + p2d->id = of_alias_get_id(np, "pxl2dpi");
Don't add random aliases. I'd rather see a property in this node as long
as it is specific to what this is used for (and not a generic index).
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Liu Ying <victor.liu@nxp.com>
Cc: devicetree@vger.kernel.org, jernej.skrabec@siol.net,
Laurent.pinchart@ideasonboard.com, kernel@pengutronix.de,
narmstrong@baylibre.com, airlied@linux.ie, festevam@gmail.com,
s.hauer@pengutronix.de, jonas@kwiboo.se,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
kishon@ti.com, a.hajda@samsung.com, vkoul@kernel.org,
linux-imx@nxp.com, daniel@ffwll.ch, mchehab@kernel.org,
shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v3 09/14] drm/bridge: imx: Add i.MX8qxp pixel link to DPI support
Date: Tue, 9 Feb 2021 12:15:10 -0600 [thread overview]
Message-ID: <20210209181510.GA4045547@robh.at.kernel.org> (raw)
In-Reply-To: <1611737488-2791-10-git-send-email-victor.liu@nxp.com>
On Wed, Jan 27, 2021 at 04:51:23PM +0800, Liu Ying wrote:
> This patch adds a drm bridge driver for i.MX8qxp pixel link to display
> pixel interface(PXL2DPI). The PXL2DPI interfaces the pixel link 36-bit
> data output and the DSI controller’s MIPI-DPI 24-bit data input, and
> inputs of LVDS Display Bridge(LDB) module used in LVDS mode, to remap
> the pixel color codings between those modules. The PXL2DPI is purely
> combinatorial.
>
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
> v2->v3:
> * Call syscon_node_to_regmap() to get regmap instead of
> syscon_regmap_lookup_by_phandle().
>
> v1->v2:
> * Drop unnecessary port availability check.
>
> drivers/gpu/drm/bridge/imx/Kconfig | 8 +
> drivers/gpu/drm/bridge/imx/Makefile | 1 +
> drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c | 488 +++++++++++++++++++++++++++
> 3 files changed, 497 insertions(+)
> create mode 100644 drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c
> + p2d->regmap = syscon_node_to_regmap(np->parent);
> + if (IS_ERR(p2d->regmap)) {
> + ret = PTR_ERR(p2d->regmap);
> + if (ret != -EPROBE_DEFER)
> + DRM_DEV_ERROR(dev, "failed to get regmap: %d\n", ret);
> + return ret;
> + }
> +
> + p2d->id = of_alias_get_id(np, "pxl2dpi");
Don't add random aliases. I'd rather see a property in this node as long
as it is specific to what this is used for (and not a generic index).
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Liu Ying <victor.liu@nxp.com>
Cc: devicetree@vger.kernel.org, jernej.skrabec@siol.net,
Laurent.pinchart@ideasonboard.com, kernel@pengutronix.de,
narmstrong@baylibre.com, airlied@linux.ie,
s.hauer@pengutronix.de, jonas@kwiboo.se,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
kishon@ti.com, a.hajda@samsung.com, vkoul@kernel.org,
linux-imx@nxp.com, mchehab@kernel.org, shawnguo@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v3 09/14] drm/bridge: imx: Add i.MX8qxp pixel link to DPI support
Date: Tue, 9 Feb 2021 12:15:10 -0600 [thread overview]
Message-ID: <20210209181510.GA4045547@robh.at.kernel.org> (raw)
In-Reply-To: <1611737488-2791-10-git-send-email-victor.liu@nxp.com>
On Wed, Jan 27, 2021 at 04:51:23PM +0800, Liu Ying wrote:
> This patch adds a drm bridge driver for i.MX8qxp pixel link to display
> pixel interface(PXL2DPI). The PXL2DPI interfaces the pixel link 36-bit
> data output and the DSI controller’s MIPI-DPI 24-bit data input, and
> inputs of LVDS Display Bridge(LDB) module used in LVDS mode, to remap
> the pixel color codings between those modules. The PXL2DPI is purely
> combinatorial.
>
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
> v2->v3:
> * Call syscon_node_to_regmap() to get regmap instead of
> syscon_regmap_lookup_by_phandle().
>
> v1->v2:
> * Drop unnecessary port availability check.
>
> drivers/gpu/drm/bridge/imx/Kconfig | 8 +
> drivers/gpu/drm/bridge/imx/Makefile | 1 +
> drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c | 488 +++++++++++++++++++++++++++
> 3 files changed, 497 insertions(+)
> create mode 100644 drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c
> + p2d->regmap = syscon_node_to_regmap(np->parent);
> + if (IS_ERR(p2d->regmap)) {
> + ret = PTR_ERR(p2d->regmap);
> + if (ret != -EPROBE_DEFER)
> + DRM_DEV_ERROR(dev, "failed to get regmap: %d\n", ret);
> + return ret;
> + }
> +
> + p2d->id = of_alias_get_id(np, "pxl2dpi");
Don't add random aliases. I'd rather see a property in this node as long
as it is specific to what this is used for (and not a generic index).
Rob
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-02-09 19:40 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 8:51 [PATCH v3 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs Liu Ying
2021-01-27 8:51 ` Liu Ying
2021-01-27 8:51 ` Liu Ying
2021-01-27 8:51 ` [PATCH v3 01/14] phy: Add LVDS configuration options Liu Ying
2021-01-27 8:51 ` Liu Ying
2021-01-27 8:51 ` Liu Ying
2021-01-27 8:51 ` [PATCH v3 02/14] media: uapi: Add some RGB bus formats for i.MX8qm/qxp pixel combiner Liu Ying
2021-01-27 8:51 ` Liu Ying
2021-01-27 8:51 ` Liu Ying
2021-01-27 8:51 ` [PATCH v3 03/14] media: docs: " Liu Ying
2021-01-27 8:51 ` Liu Ying
2021-01-27 8:51 ` Liu Ying
2021-01-27 8:51 ` [PATCH v3 04/14] dt-bindings: display: bridge: Add i.MX8qm/qxp pixel combiner binding Liu Ying
2021-01-27 8:51 ` Liu Ying
2021-01-27 8:51 ` Liu Ying
2021-01-27 8:51 ` [PATCH v3 05/14] drm/bridge: imx: Add i.MX8qm/qxp pixel combiner support Liu Ying
2021-01-27 8:51 ` Liu Ying
2021-01-27 8:51 ` Liu Ying
2021-01-27 8:51 ` [PATCH v3 06/14] dt-bindings: display: bridge: Add i.MX8qm/qxp display pixel link binding Liu Ying
2021-01-27 8:51 ` Liu Ying
2021-01-27 8:51 ` Liu Ying
2021-01-27 8:51 ` [PATCH v3 07/14] drm/bridge: imx: Add i.MX8qm/qxp display pixel link support Liu Ying
2021-01-27 8:51 ` Liu Ying
2021-01-27 8:51 ` Liu Ying
2021-01-27 8:51 ` [PATCH v3 08/14] dt-bindings: display: bridge: Add i.MX8qxp pixel link to DPI binding Liu Ying
2021-01-27 8:51 ` Liu Ying
2021-01-27 8:51 ` Liu Ying
2021-01-27 8:51 ` [PATCH v3 09/14] drm/bridge: imx: Add i.MX8qxp pixel link to DPI support Liu Ying
2021-01-27 8:51 ` Liu Ying
2021-01-27 8:51 ` Liu Ying
2021-02-09 18:15 ` Rob Herring [this message]
2021-02-09 18:15 ` Rob Herring
2021-02-09 18:15 ` Rob Herring
2021-02-18 2:56 ` Liu Ying
2021-02-18 2:56 ` Liu Ying
2021-02-18 2:56 ` Liu Ying
2021-01-27 8:51 ` [PATCH v3 10/14] drm/bridge: imx: Add LDB driver helper support Liu Ying
2021-01-27 8:51 ` Liu Ying
2021-01-27 8:51 ` Liu Ying
2021-01-27 8:51 ` [PATCH v3 11/14] dt-bindings: display: bridge: Add i.MX8qm/qxp LVDS display bridge binding Liu Ying
2021-01-27 8:51 ` Liu Ying
2021-01-27 8:51 ` Liu Ying
2021-02-09 18:31 ` Rob Herring
2021-02-09 18:31 ` Rob Herring
2021-02-09 18:31 ` Rob Herring
2021-01-27 8:51 ` [PATCH v3 12/14] drm/bridge: imx: Add LDB support for i.MX8qxp Liu Ying
2021-01-27 8:51 ` Liu Ying
2021-01-27 8:51 ` Liu Ying
2021-01-27 8:51 ` [PATCH v3 13/14] drm/bridge: imx: Add LDB support for i.MX8qm Liu Ying
2021-01-27 8:51 ` Liu Ying
2021-01-27 8:51 ` Liu Ying
2021-01-27 8:51 ` [PATCH v3 14/14] MAINTAINERS: add maintainer for DRM bridge drivers for i.MX SoCs Liu Ying
2021-01-27 8:51 ` Liu Ying
2021-01-27 8:51 ` Liu Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210209181510.GA4045547@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=kernel@pengutronix.de \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=narmstrong@baylibre.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=victor.liu@nxp.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.