From: Mark Brown <broonie@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Shengjiu Wang <shengjiu.wang@nxp.com>,
lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: soc-pcm: change error message to debug message
Date: Tue, 9 Feb 2021 22:23:31 +0000 [thread overview]
Message-ID: <20210209222331.GD4916@sirena.org.uk> (raw)
In-Reply-To: <b7f5442d-ad21-eb8a-7d90-7a8207320541@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 486 bytes --]
On Mon, Feb 08, 2021 at 09:06:44AM -0600, Pierre-Louis Bossart wrote:
> If you demote this to dev_dbg, we'll have to ask every single user who
> reports 'sound is broken' to enable dynamic debug traces. I really don't see
> the benefit, this is a clear case of 'fail big and fail early', partly
> concealing the problem doesn't make it go away but harder to diagnose.
Don't you also get the same information out of the DAPM debugfs or did
I misread where the error is generated from?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com,
Shengjiu Wang <shengjiu.wang@nxp.com>,
linux-kernel@vger.kernel.org, tiwai@suse.com
Subject: Re: [PATCH] ASoC: soc-pcm: change error message to debug message
Date: Tue, 9 Feb 2021 22:23:31 +0000 [thread overview]
Message-ID: <20210209222331.GD4916@sirena.org.uk> (raw)
In-Reply-To: <b7f5442d-ad21-eb8a-7d90-7a8207320541@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 486 bytes --]
On Mon, Feb 08, 2021 at 09:06:44AM -0600, Pierre-Louis Bossart wrote:
> If you demote this to dev_dbg, we'll have to ask every single user who
> reports 'sound is broken' to enable dynamic debug traces. I really don't see
> the benefit, this is a clear case of 'fail big and fail early', partly
> concealing the problem doesn't make it go away but harder to diagnose.
Don't you also get the same information out of the DAPM debugfs or did
I misread where the error is generated from?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-02-10 1:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 8:12 [PATCH] ASoC: soc-pcm: change error message to debug message Shengjiu Wang
2021-02-08 15:06 ` Pierre-Louis Bossart
2021-02-09 7:37 ` Shengjiu Wang
2021-02-09 7:37 ` Shengjiu Wang
2021-02-09 22:23 ` Mark Brown [this message]
2021-02-09 22:23 ` Mark Brown
2021-02-09 23:05 ` Pierre-Louis Bossart
2021-02-09 23:05 ` Pierre-Louis Bossart
2021-02-10 20:11 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210209222331.GD4916@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=shengjiu.wang@nxp.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.