From: kernel test robot <lkp@intel.com>
To: Mike Christie <michael.christie@oracle.com>,
Chaitanya.Kulkarni@wdc.com, loberman@redhat.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org, mst@redhat.com,
stefanha@redhat.com, virtualization@lists.linux-foundation.org
Cc: kbuild-all@lists.01.org, Mike Christie <michael.christie@oracle.com>
Subject: Re: [PATCH 02/13] target: split target_submit_cmd_map_sgls
Date: Wed, 10 Feb 2021 00:15:42 +0800 [thread overview]
Message-ID: <202102100043.iwcq44PC-lkp@intel.com> (raw)
In-Reply-To: <20210209123845.4856-3-michael.christie@oracle.com>
[-- Attachment #1: Type: text/plain, Size: 4737 bytes --]
Hi Mike,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on vhost/linux-next v5.11-rc7 next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Mike-Christie/target-move-t_task_cdb-initialization/20210209-213926
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: h8300-randconfig-s031-20210209 (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-215-g0fb77bb6-dirty
# https://github.com/0day-ci/linux/commit/3382952197b63f11c166ff293f819ce6ac4d52ae
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mike-Christie/target-move-t_task_cdb-initialization/20210209-213926
git checkout 3382952197b63f11c166ff293f819ce6ac4d52ae
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=h8300
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
"sparse warnings: (new ones prefixed by >>)"
>> drivers/target/target_core_transport.c:1695:12: sparse: sparse: incorrect type in assignment (different base types) @@ expected int rc @@ got restricted sense_reason_t @@
drivers/target/target_core_transport.c:1695:12: sparse: expected int rc
drivers/target/target_core_transport.c:1695:12: sparse: got restricted sense_reason_t
drivers/target/target_core_transport.c:1699:12: sparse: sparse: incorrect type in assignment (different base types) @@ expected int rc @@ got restricted sense_reason_t @@
drivers/target/target_core_transport.c:1699:12: sparse: expected int rc
drivers/target/target_core_transport.c:1699:12: sparse: got restricted sense_reason_t
>> drivers/target/target_core_transport.c:1736:51: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected restricted sense_reason_t [usertype] @@ got int rc @@
drivers/target/target_core_transport.c:1736:51: sparse: expected restricted sense_reason_t [usertype]
drivers/target/target_core_transport.c:1736:51: sparse: got int rc
vim +1695 drivers/target/target_core_transport.c
1678
1679 /**
1680 * target_submit - perform final initialization and submit cmd to LIO core
1681 * @se_cmd: command descriptor to submit
1682 * @cdb: pointer to SCSI CDB
1683 *
1684 * target_submit_prep must have been called on the cmd, and this must be
1685 * called from process context.
1686 */
1687 static void target_submit(struct se_cmd *se_cmd, unsigned char *cdb)
1688 {
1689 struct scatterlist *sgl = se_cmd->t_data_sg;
1690 unsigned char *buf = NULL;
1691 int rc;
1692
1693 might_sleep();
1694
> 1695 rc = target_cmd_init_cdb(se_cmd, cdb);
1696 if (rc)
1697 goto fail;
1698
1699 rc = target_cmd_parse_cdb(se_cmd);
1700 if (rc != 0)
1701 goto fail;
1702
1703 if (se_cmd->t_data_nents != 0) {
1704 BUG_ON(!sgl);
1705 /*
1706 * A work-around for tcm_loop as some userspace code via
1707 * scsi-generic do not memset their associated read buffers,
1708 * so go ahead and do that here for type non-data CDBs. Also
1709 * note that this is currently guaranteed to be a single SGL
1710 * for this case by target core in target_setup_cmd_from_cdb()
1711 * -> transport_generic_cmd_sequencer().
1712 */
1713 if (!(se_cmd->se_cmd_flags & SCF_SCSI_DATA_CDB) &&
1714 se_cmd->data_direction == DMA_FROM_DEVICE) {
1715 if (sgl)
1716 buf = kmap(sg_page(sgl)) + sgl->offset;
1717
1718 if (buf) {
1719 memset(buf, 0, sgl->length);
1720 kunmap(sg_page(sgl));
1721 }
1722 }
1723
1724 }
1725
1726 /*
1727 * Check if we need to delay processing because of ALUA
1728 * Active/NonOptimized primary access state..
1729 */
1730 core_alua_check_nonop_delay(se_cmd);
1731
1732 transport_handle_cdb_direct(se_cmd);
1733 return;
1734
1735 fail:
> 1736 transport_generic_request_failure(se_cmd, rc);
1737 }
1738
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 23129 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Mike Christie <michael.christie@oracle.com>,
Chaitanya.Kulkarni@wdc.com, loberman@redhat.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org, mst@redhat.com,
stefanha@redhat.com, virtualization@lists.linux-foundation.org
Cc: kbuild-all@lists.01.org, Mike Christie <michael.christie@oracle.com>
Subject: Re: [PATCH 02/13] target: split target_submit_cmd_map_sgls
Date: Wed, 10 Feb 2021 00:15:42 +0800 [thread overview]
Message-ID: <202102100043.iwcq44PC-lkp@intel.com> (raw)
In-Reply-To: <20210209123845.4856-3-michael.christie@oracle.com>
[-- Attachment #1: Type: text/plain, Size: 4737 bytes --]
Hi Mike,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on vhost/linux-next v5.11-rc7 next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Mike-Christie/target-move-t_task_cdb-initialization/20210209-213926
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: h8300-randconfig-s031-20210209 (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-215-g0fb77bb6-dirty
# https://github.com/0day-ci/linux/commit/3382952197b63f11c166ff293f819ce6ac4d52ae
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mike-Christie/target-move-t_task_cdb-initialization/20210209-213926
git checkout 3382952197b63f11c166ff293f819ce6ac4d52ae
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=h8300
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
"sparse warnings: (new ones prefixed by >>)"
>> drivers/target/target_core_transport.c:1695:12: sparse: sparse: incorrect type in assignment (different base types) @@ expected int rc @@ got restricted sense_reason_t @@
drivers/target/target_core_transport.c:1695:12: sparse: expected int rc
drivers/target/target_core_transport.c:1695:12: sparse: got restricted sense_reason_t
drivers/target/target_core_transport.c:1699:12: sparse: sparse: incorrect type in assignment (different base types) @@ expected int rc @@ got restricted sense_reason_t @@
drivers/target/target_core_transport.c:1699:12: sparse: expected int rc
drivers/target/target_core_transport.c:1699:12: sparse: got restricted sense_reason_t
>> drivers/target/target_core_transport.c:1736:51: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected restricted sense_reason_t [usertype] @@ got int rc @@
drivers/target/target_core_transport.c:1736:51: sparse: expected restricted sense_reason_t [usertype]
drivers/target/target_core_transport.c:1736:51: sparse: got int rc
vim +1695 drivers/target/target_core_transport.c
1678
1679 /**
1680 * target_submit - perform final initialization and submit cmd to LIO core
1681 * @se_cmd: command descriptor to submit
1682 * @cdb: pointer to SCSI CDB
1683 *
1684 * target_submit_prep must have been called on the cmd, and this must be
1685 * called from process context.
1686 */
1687 static void target_submit(struct se_cmd *se_cmd, unsigned char *cdb)
1688 {
1689 struct scatterlist *sgl = se_cmd->t_data_sg;
1690 unsigned char *buf = NULL;
1691 int rc;
1692
1693 might_sleep();
1694
> 1695 rc = target_cmd_init_cdb(se_cmd, cdb);
1696 if (rc)
1697 goto fail;
1698
1699 rc = target_cmd_parse_cdb(se_cmd);
1700 if (rc != 0)
1701 goto fail;
1702
1703 if (se_cmd->t_data_nents != 0) {
1704 BUG_ON(!sgl);
1705 /*
1706 * A work-around for tcm_loop as some userspace code via
1707 * scsi-generic do not memset their associated read buffers,
1708 * so go ahead and do that here for type non-data CDBs. Also
1709 * note that this is currently guaranteed to be a single SGL
1710 * for this case by target core in target_setup_cmd_from_cdb()
1711 * -> transport_generic_cmd_sequencer().
1712 */
1713 if (!(se_cmd->se_cmd_flags & SCF_SCSI_DATA_CDB) &&
1714 se_cmd->data_direction == DMA_FROM_DEVICE) {
1715 if (sgl)
1716 buf = kmap(sg_page(sgl)) + sgl->offset;
1717
1718 if (buf) {
1719 memset(buf, 0, sgl->length);
1720 kunmap(sg_page(sgl));
1721 }
1722 }
1723
1724 }
1725
1726 /*
1727 * Check if we need to delay processing because of ALUA
1728 * Active/NonOptimized primary access state..
1729 */
1730 core_alua_check_nonop_delay(se_cmd);
1731
1732 transport_handle_cdb_direct(se_cmd);
1733 return;
1734
1735 fail:
> 1736 transport_generic_request_failure(se_cmd, rc);
1737 }
1738
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 23129 bytes --]
[-- Attachment #3: Type: text/plain, Size: 183 bytes --]
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 02/13] target: split target_submit_cmd_map_sgls
Date: Wed, 10 Feb 2021 00:15:42 +0800 [thread overview]
Message-ID: <202102100043.iwcq44PC-lkp@intel.com> (raw)
In-Reply-To: <20210209123845.4856-3-michael.christie@oracle.com>
[-- Attachment #1: Type: text/plain, Size: 4847 bytes --]
Hi Mike,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on vhost/linux-next v5.11-rc7 next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Mike-Christie/target-move-t_task_cdb-initialization/20210209-213926
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: h8300-randconfig-s031-20210209 (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-215-g0fb77bb6-dirty
# https://github.com/0day-ci/linux/commit/3382952197b63f11c166ff293f819ce6ac4d52ae
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mike-Christie/target-move-t_task_cdb-initialization/20210209-213926
git checkout 3382952197b63f11c166ff293f819ce6ac4d52ae
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=h8300
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
"sparse warnings: (new ones prefixed by >>)"
>> drivers/target/target_core_transport.c:1695:12: sparse: sparse: incorrect type in assignment (different base types) @@ expected int rc @@ got restricted sense_reason_t @@
drivers/target/target_core_transport.c:1695:12: sparse: expected int rc
drivers/target/target_core_transport.c:1695:12: sparse: got restricted sense_reason_t
drivers/target/target_core_transport.c:1699:12: sparse: sparse: incorrect type in assignment (different base types) @@ expected int rc @@ got restricted sense_reason_t @@
drivers/target/target_core_transport.c:1699:12: sparse: expected int rc
drivers/target/target_core_transport.c:1699:12: sparse: got restricted sense_reason_t
>> drivers/target/target_core_transport.c:1736:51: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected restricted sense_reason_t [usertype] @@ got int rc @@
drivers/target/target_core_transport.c:1736:51: sparse: expected restricted sense_reason_t [usertype]
drivers/target/target_core_transport.c:1736:51: sparse: got int rc
vim +1695 drivers/target/target_core_transport.c
1678
1679 /**
1680 * target_submit - perform final initialization and submit cmd to LIO core
1681 * @se_cmd: command descriptor to submit
1682 * @cdb: pointer to SCSI CDB
1683 *
1684 * target_submit_prep must have been called on the cmd, and this must be
1685 * called from process context.
1686 */
1687 static void target_submit(struct se_cmd *se_cmd, unsigned char *cdb)
1688 {
1689 struct scatterlist *sgl = se_cmd->t_data_sg;
1690 unsigned char *buf = NULL;
1691 int rc;
1692
1693 might_sleep();
1694
> 1695 rc = target_cmd_init_cdb(se_cmd, cdb);
1696 if (rc)
1697 goto fail;
1698
1699 rc = target_cmd_parse_cdb(se_cmd);
1700 if (rc != 0)
1701 goto fail;
1702
1703 if (se_cmd->t_data_nents != 0) {
1704 BUG_ON(!sgl);
1705 /*
1706 * A work-around for tcm_loop as some userspace code via
1707 * scsi-generic do not memset their associated read buffers,
1708 * so go ahead and do that here for type non-data CDBs. Also
1709 * note that this is currently guaranteed to be a single SGL
1710 * for this case by target core in target_setup_cmd_from_cdb()
1711 * -> transport_generic_cmd_sequencer().
1712 */
1713 if (!(se_cmd->se_cmd_flags & SCF_SCSI_DATA_CDB) &&
1714 se_cmd->data_direction == DMA_FROM_DEVICE) {
1715 if (sgl)
1716 buf = kmap(sg_page(sgl)) + sgl->offset;
1717
1718 if (buf) {
1719 memset(buf, 0, sgl->length);
1720 kunmap(sg_page(sgl));
1721 }
1722 }
1723
1724 }
1725
1726 /*
1727 * Check if we need to delay processing because of ALUA
1728 * Active/NonOptimized primary access state..
1729 */
1730 core_alua_check_nonop_delay(se_cmd);
1731
1732 transport_handle_cdb_direct(se_cmd);
1733 return;
1734
1735 fail:
> 1736 transport_generic_request_failure(se_cmd, rc);
1737 }
1738
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 23129 bytes --]
next prev parent reply other threads:[~2021-02-09 16:17 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 12:38 [PATCH 00/12 V2] target: fix cmd plugging and completion Mike Christie
2021-02-09 12:38 ` [PATCH 01/13] target: move t_task_cdb initialization Mike Christie
2021-02-10 8:35 ` Christoph Hellwig
2021-02-10 8:35 ` Christoph Hellwig
2021-02-09 12:38 ` [PATCH 02/13] target: split target_submit_cmd_map_sgls Mike Christie
2021-02-09 16:15 ` kernel test robot [this message]
2021-02-09 16:15 ` kernel test robot
2021-02-09 16:15 ` kernel test robot
2021-02-09 18:40 ` Mike Christie
2021-02-09 18:40 ` Mike Christie
2021-02-10 8:36 ` Christoph Hellwig
2021-02-10 8:36 ` Christoph Hellwig
2021-02-09 12:38 ` [PATCH 03/13] target: add workqueue based cmd submission Mike Christie
2021-02-09 15:48 ` Bodo Stroesser
2021-02-09 18:43 ` Mike Christie
2021-02-09 19:10 ` Mike Christie
2021-02-09 12:38 ` [PATCH 04/13] vhost scsi: use lio wq cmd submission helper Mike Christie
2021-02-09 12:38 ` [PATCH 05/13] tcm loop: use blk cmd allocator for se_cmds Mike Christie
2021-02-10 8:37 ` Christoph Hellwig
2021-02-10 8:37 ` Christoph Hellwig
2021-02-09 12:38 ` [PATCH 06/13] tcm loop: use lio wq cmd submission helper Mike Christie
2021-02-09 15:59 ` Bodo Stroesser
2021-02-09 18:44 ` Mike Christie
2021-02-09 17:39 ` kernel test robot
2021-02-09 17:39 ` kernel test robot
2021-02-09 12:38 ` [PATCH 07/13] target: cleanup cmd flag bits Mike Christie
2021-02-10 8:38 ` Christoph Hellwig
2021-02-10 8:38 ` Christoph Hellwig
2021-02-09 12:38 ` [PATCH 08/13] target: fix backend plugging Mike Christie
2021-02-09 12:38 ` [PATCH 09/13] target iblock: add backend plug/unplug callouts Mike Christie
2021-02-09 12:38 ` [PATCH 10/13] target_core_user: " Mike Christie
2021-02-09 16:32 ` Bodo Stroesser
2021-02-09 18:59 ` Mike Christie
2021-02-09 12:38 ` [PATCH 11/13] target: replace work per cmd in completion path Mike Christie
2021-02-09 17:01 ` Bodo Stroesser
2021-02-09 18:50 ` Mike Christie
2021-02-10 8:42 ` Christoph Hellwig
2021-02-10 8:42 ` Christoph Hellwig
2021-02-10 18:33 ` Mike Christie
2021-02-09 12:38 ` [PATCH 12/13] target, vhost-scsi: don't switch cpus on completion Mike Christie
2021-02-10 8:44 ` Christoph Hellwig
2021-02-10 8:44 ` Christoph Hellwig
2021-02-10 18:43 ` Mike Christie
2021-02-10 18:45 ` Mike Christie
2021-02-09 12:38 ` [PATCH 13/13] target: flush submission work during TMR processing Mike Christie
2021-02-09 14:31 ` Laurence Oberman
2021-02-10 14:25 ` Laurence Oberman
2021-02-09 17:05 ` Bodo Stroesser
2021-02-09 18:49 ` Mike Christie
2021-02-10 4:55 [PATCH 00/13 V3] target: fix cmd plugging and completion Mike Christie
2021-02-10 4:55 ` [PATCH 02/13] target: split target_submit_cmd_map_sgls Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202102100043.iwcq44PC-lkp@intel.com \
--to=lkp@intel.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-scsi@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=mst@redhat.com \
--cc=stefanha@redhat.com \
--cc=target-devel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.