From: Mark Brown <broonie@kernel.org> To: Shengjiu Wang <shengjiu.wang@gmail.com> Cc: Shengjiu Wang <shengjiu.wang@nxp.com>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, alsa-devel@alsa-project.org, Timur Tabi <timur@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>, linuxppc-dev@lists.ozlabs.org, Xiubo Li <Xiubo.Lee@gmail.com>, linux-kernel <linux-kernel@vger.kernel.org>, Takashi Iwai <tiwai@suse.com>, Nicolin Chen <nicoleotsuka@gmail.com>, Rob Herring <robh+dt@kernel.org>, Fabio Estevam <festevam@gmail.com> Subject: Re: [PATCH v2 2/7] ASoC: fsl_rpmsg: Add CPU DAI driver for audio base on rpmsg Date: Wed, 10 Feb 2021 15:38:08 +0000 [thread overview] Message-ID: <20210210153808.GB4748@sirena.org.uk> (raw) In-Reply-To: <CAA+D8AN=SDMLhuNbstzHL_H2p_L6cr+oCXbauNB0gGs2BW5tmA@mail.gmail.com> [-- Attachment #1: Type: text/plain, Size: 1056 bytes --] On Wed, Feb 10, 2021 at 02:35:29PM +0800, Shengjiu Wang wrote: > On Wed, Feb 10, 2021 at 6:30 AM Mark Brown <broonie@kernel.org> wrote: > > Like I say I'd actually recommend moving this control to DAPM. > I may understand your point, you suggest to use the .set_bias_level > interface. But in my case I need to enable the clock in earlier stage > and keep the clock on when system go to suspend. The device can be kept alive over system suspend if that's needed, or possibly it sounds like runtime PM is a better fit? There's callbacks in the core to keep the device runtime PM enabled while it's open which is probably about the time range you're looking for. > I am not sure .set_bias_level can met my requirement. we start > the Chinese new year holiday now, so currently I can't do test for this > recommendation. > Maybe we can keep current implementation, can we? > Later after I do the test, I can submit another patch for it. Well, the current version is clearly going to leak clock enables with valid userspace so [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org> To: Shengjiu Wang <shengjiu.wang@gmail.com> Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, alsa-devel@alsa-project.org, Timur Tabi <timur@kernel.org>, Xiubo Li <Xiubo.Lee@gmail.com>, Fabio Estevam <festevam@gmail.com>, Shengjiu Wang <shengjiu.wang@nxp.com>, Takashi Iwai <tiwai@suse.com>, Liam Girdwood <lgirdwood@gmail.com>, linux-kernel <linux-kernel@vger.kernel.org>, Nicolin Chen <nicoleotsuka@gmail.com>, Rob Herring <robh+dt@kernel.org>, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v2 2/7] ASoC: fsl_rpmsg: Add CPU DAI driver for audio base on rpmsg Date: Wed, 10 Feb 2021 15:38:08 +0000 [thread overview] Message-ID: <20210210153808.GB4748@sirena.org.uk> (raw) In-Reply-To: <CAA+D8AN=SDMLhuNbstzHL_H2p_L6cr+oCXbauNB0gGs2BW5tmA@mail.gmail.com> [-- Attachment #1: Type: text/plain, Size: 1056 bytes --] On Wed, Feb 10, 2021 at 02:35:29PM +0800, Shengjiu Wang wrote: > On Wed, Feb 10, 2021 at 6:30 AM Mark Brown <broonie@kernel.org> wrote: > > Like I say I'd actually recommend moving this control to DAPM. > I may understand your point, you suggest to use the .set_bias_level > interface. But in my case I need to enable the clock in earlier stage > and keep the clock on when system go to suspend. The device can be kept alive over system suspend if that's needed, or possibly it sounds like runtime PM is a better fit? There's callbacks in the core to keep the device runtime PM enabled while it's open which is probably about the time range you're looking for. > I am not sure .set_bias_level can met my requirement. we start > the Chinese new year holiday now, so currently I can't do test for this > recommendation. > Maybe we can keep current implementation, can we? > Later after I do the test, I can submit another patch for it. Well, the current version is clearly going to leak clock enables with valid userspace so [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-02-10 15:40 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-07 10:23 [PATCH v2 0/7] Add audio driver base on rpmsg on i.MX platform Shengjiu Wang 2021-02-07 10:23 ` [PATCH v2 1/7] ASoC: soc-component: Add snd_soc_pcm_component_ack Shengjiu Wang 2021-02-07 10:23 ` [PATCH v2 2/7] ASoC: fsl_rpmsg: Add CPU DAI driver for audio base on rpmsg Shengjiu Wang 2021-02-08 11:51 ` Mark Brown 2021-02-08 11:51 ` Mark Brown 2021-02-08 11:51 ` Mark Brown 2021-02-09 9:16 ` Shengjiu Wang 2021-02-09 9:16 ` Shengjiu Wang 2021-02-09 22:29 ` Mark Brown 2021-02-09 22:29 ` Mark Brown 2021-02-10 6:35 ` Shengjiu Wang 2021-02-10 6:35 ` Shengjiu Wang 2021-02-10 15:38 ` Mark Brown [this message] 2021-02-10 15:38 ` Mark Brown 2021-02-18 7:57 ` Shengjiu Wang 2021-02-18 7:57 ` Shengjiu Wang 2021-02-22 13:46 ` Mark Brown 2021-02-22 13:46 ` Mark Brown 2021-02-07 10:23 ` [PATCH v2 3/7] ASoC: dt-bindings: fsl_rpmsg: Add binding doc for rpmsg cpu dai driver Shengjiu Wang 2021-02-10 22:12 ` Rob Herring 2021-02-10 22:12 ` Rob Herring 2021-02-10 22:12 ` Rob Herring 2021-02-18 7:21 ` Shengjiu Wang 2021-02-18 7:21 ` Shengjiu Wang 2021-02-25 3:10 ` Fabio Estevam 2021-02-25 3:10 ` Fabio Estevam 2021-02-07 10:23 ` [PATCH v2 4/7] ASoC: imx-audio-rpmsg: Add rpmsg_driver for audio channel Shengjiu Wang 2021-02-07 10:23 ` [PATCH v2 5/7] ASoC: imx-pcm-rpmsg: Add platform driver for audio base on rpmsg Shengjiu Wang 2021-02-07 10:23 ` [PATCH v2 6/7] ASoC: imx-rpmsg: Add machine " Shengjiu Wang 2021-02-07 10:23 ` [PATCH v2 7/7] ASoC: dt-bindings: imx-rpmsg: Add binding doc for rpmsg machine driver Shengjiu Wang 2021-02-10 22:17 ` Rob Herring 2021-02-10 22:17 ` Rob Herring 2021-02-10 22:17 ` Rob Herring 2021-02-18 7:23 ` Shengjiu Wang 2021-02-18 7:23 ` Shengjiu Wang 2021-03-04 20:04 ` Rob Herring 2021-03-04 20:04 ` Rob Herring 2021-03-05 2:55 ` Shengjiu Wang 2021-03-05 2:55 ` Shengjiu Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210210153808.GB4748@sirena.org.uk \ --to=broonie@kernel.org \ --cc=Xiubo.Lee@gmail.com \ --cc=alsa-devel@alsa-project.org \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=nicoleotsuka@gmail.com \ --cc=robh+dt@kernel.org \ --cc=shengjiu.wang@gmail.com \ --cc=shengjiu.wang@nxp.com \ --cc=timur@kernel.org \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.