From: Serge Semin <Sergey.Semin@baikalelectronics.ru> To: Russell King - ARM Linux admin <linux@armlinux.org.uk> Cc: Serge Semin <fancer.lancer@gmail.com>, Heiner Kallweit <hkallweit1@gmail.com>, Jose Abreu <Jose.Abreu@synopsys.com>, Andrew Lunn <andrew@lunn.ch>, Joao Pinto <Joao.Pinto@synopsys.com>, <linux-kernel@vger.kernel.org>, Alexandre Torgue <alexandre.torgue@st.com>, <netdev@vger.kernel.org>, <linux-stm32@st-md-mailman.stormreply.com>, Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>, Jose Abreu <joabreu@synopsys.com>, Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Jakub Kicinski <kuba@kernel.org>, Giuseppe Cavallaro <peppe.cavallaro@st.com>, Vyacheslav Mitrofanov <Vyacheslav.Mitrofanov@baikalelectronics.ru>, "David S. Miller" <davem@davemloft.net>, <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode Date: Wed, 10 Feb 2021 19:47:20 +0300 [thread overview] Message-ID: <20210210164720.migzigazyqsuxwc6@mobilestation> (raw) In-Reply-To: <20210209105646.GP1463@shell.armlinux.org.uk> On Tue, Feb 09, 2021 at 10:56:46AM +0000, Russell King - ARM Linux admin wrote: > On Tue, Feb 09, 2021 at 11:37:29AM +0100, Heiner Kallweit wrote: > > Right, adding something like a genphy_{read,write}_mmd() doesn't make > > too much sense for now. What I meant is just exporting mmd_phy_indirect(). > > Then you don't have to open-code the first three steps of a mmd read/write. > > And it requires no additional code in phylib. > > ... but at the cost that the compiler can no longer inline that code, > as I mentioned in my previous reply. (However, the cost of the accesses > will be higher.) On the plus side, less I-cache footprint, and smaller > kernel code. Just to note mmd_phy_indirect() isn't defined with inline specifier, but just as static and it's used twice in the drivers/net/phy/phy-core.c unit. So most likely the compiler won't inline the function code in there. Anyway it's up to the PHY library maintainers to decide. Please settle the issue with Heiner and Andrew then. I am ok with both solutions and will do as you decide. -Sergey > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
WARNING: multiple messages have this Message-ID (diff)
From: Serge Semin <Sergey.Semin@baikalelectronics.ru> To: Russell King - ARM Linux admin <linux@armlinux.org.uk> Cc: Jose Abreu <Jose.Abreu@synopsys.com>, Andrew Lunn <andrew@lunn.ch>, Joao Pinto <Joao.Pinto@synopsys.com>, Alexandre Torgue <alexandre.torgue@st.com>, "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Serge Semin <fancer.lancer@gmail.com>, Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>, Jose Abreu <joabreu@synopsys.com>, Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Giuseppe Cavallaro <peppe.cavallaro@st.com>, Jakub Kicinski <kuba@kernel.org>, Vyacheslav Mitrofanov <Vyacheslav.Mitrofanov@baikalelectronics.ru>, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Heiner Kallweit <hkallweit1@gmail.com> Subject: Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode Date: Wed, 10 Feb 2021 19:47:20 +0300 [thread overview] Message-ID: <20210210164720.migzigazyqsuxwc6@mobilestation> (raw) In-Reply-To: <20210209105646.GP1463@shell.armlinux.org.uk> On Tue, Feb 09, 2021 at 10:56:46AM +0000, Russell King - ARM Linux admin wrote: > On Tue, Feb 09, 2021 at 11:37:29AM +0100, Heiner Kallweit wrote: > > Right, adding something like a genphy_{read,write}_mmd() doesn't make > > too much sense for now. What I meant is just exporting mmd_phy_indirect(). > > Then you don't have to open-code the first three steps of a mmd read/write. > > And it requires no additional code in phylib. > > ... but at the cost that the compiler can no longer inline that code, > as I mentioned in my previous reply. (However, the cost of the accesses > will be higher.) On the plus side, less I-cache footprint, and smaller > kernel code. Just to note mmd_phy_indirect() isn't defined with inline specifier, but just as static and it's used twice in the drivers/net/phy/phy-core.c unit. So most likely the compiler won't inline the function code in there. Anyway it's up to the PHY library maintainers to decide. Please settle the issue with Heiner and Andrew then. I am ok with both solutions and will do as you decide. -Sergey > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-10 16:49 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-08 14:03 [PATCH 00/20] net: stmmac: Obvious cleanups and several fixes Serge Semin 2021-02-08 14:03 ` Serge Semin 2021-02-08 14:03 ` [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode Serge Semin 2021-02-08 14:03 ` Serge Semin 2021-02-08 15:27 ` Andrew Lunn 2021-02-08 15:27 ` Andrew Lunn 2021-02-08 17:44 ` Serge Semin 2021-02-08 17:44 ` Serge Semin 2021-02-08 19:03 ` Andrew Lunn 2021-02-08 19:03 ` Andrew Lunn 2021-02-08 20:14 ` Heiner Kallweit 2021-02-08 20:14 ` Heiner Kallweit 2021-02-09 10:15 ` Serge Semin 2021-02-09 10:15 ` Serge Semin 2021-02-09 10:37 ` Heiner Kallweit 2021-02-09 10:37 ` Heiner Kallweit 2021-02-09 10:56 ` Russell King - ARM Linux admin 2021-02-09 10:56 ` Russell King - ARM Linux admin 2021-02-10 16:47 ` Serge Semin [this message] 2021-02-10 16:47 ` Serge Semin 2021-02-11 10:39 ` Russell King - ARM Linux admin 2021-02-11 10:39 ` Russell King - ARM Linux admin 2021-02-11 10:52 ` Serge Semin 2021-02-11 10:52 ` Serge Semin 2021-02-20 9:02 ` Serge Semin 2021-02-20 9:02 ` Serge Semin 2021-02-20 12:51 ` Heiner Kallweit 2021-02-20 12:51 ` Heiner Kallweit 2021-02-20 15:49 ` Andrew Lunn 2021-02-20 15:49 ` Andrew Lunn 2021-02-21 13:51 ` Serge Semin 2021-02-21 13:51 ` Serge Semin 2021-02-09 10:54 ` Russell King - ARM Linux admin 2021-02-09 10:54 ` Russell King - ARM Linux admin 2021-02-08 14:03 ` [PATCH 02/20] net: stmmac: Free Rx descs on Tx allocation failure Serge Semin 2021-02-08 14:03 ` Serge Semin 2021-02-08 14:03 ` [PATCH 03/20] net: stmmac: Fix false MTL RX overflow handling for higher queues Serge Semin 2021-02-08 14:03 ` Serge Semin 2021-02-08 14:03 ` [PATCH 04/20] net: stmmac: Assert reset control after MDIO de-registration Serge Semin 2021-02-08 14:03 ` Serge Semin 2021-02-08 14:03 ` [PATCH 05/20] net: stmmac: Use dwmac410_disable_dma_irq for DW MAC v4.10 DMA Serge Semin 2021-02-08 14:03 ` Serge Semin 2021-02-08 14:03 ` [PATCH 06/20] net: stmmac: Use LPI IRQ status-related macro in DW MAC1000 isr Serge Semin 2021-02-08 14:03 ` Serge Semin 2021-02-08 14:03 ` [PATCH 07/20] net: stmmac: Clear descriptors before initializing them Serge Semin 2021-02-08 14:03 ` Serge Semin 2021-02-08 14:03 ` [PATCH 08/20] net: stmmac: Fix typo in the XGMAC_L3_ADDR3 macro name Serge Semin 2021-02-08 14:03 ` Serge Semin 2021-02-08 14:03 ` [PATCH 09/20] net: stmmac: Discard mii_irq array from private data Serge Semin 2021-02-08 14:03 ` Serge Semin 2021-02-08 19:13 ` Andrew Lunn 2021-02-08 19:13 ` Andrew Lunn 2021-02-08 14:03 ` [PATCH 10/20] net: stmmac: Discard Rx copybreak ethtool setting Serge Semin 2021-02-08 14:03 ` Serge Semin 2021-02-08 14:03 ` [PATCH 11/20] net: stmmac: Discard index usage in the dirty_rx init Serge Semin 2021-02-08 14:03 ` Serge Semin 2021-02-08 14:03 ` [PATCH 12/20] net: stmmac: Discard dwmac1000_dma_ops declaration from dwmac100.h Serge Semin 2021-02-08 14:03 ` Serge Semin 2021-02-08 14:03 ` [PATCH 13/20] net: stmmac: Move DMA Tx/Rx init methods to DW MAC lib Serge Semin 2021-02-08 14:03 ` Serge Semin 2021-02-08 14:03 ` [PATCH 14/20] net: stmmac: Add DW GMAC disable LPI IRQ mask macro Serge Semin 2021-02-08 14:03 ` Serge Semin 2021-02-08 14:03 ` [PATCH 15/20] net: stmmac: Discard STMMAC_RESETING flag Serge Semin 2021-02-08 14:03 ` Serge Semin 2021-02-08 14:03 ` [PATCH 16/20] net: stmmac: Discard conditional service task execution Serge Semin 2021-02-08 14:03 ` Serge Semin 2021-02-08 14:03 ` [PATCH 17/20] net: stmmac: Add 'cause' arg to the service task executioner Serge Semin 2021-02-08 14:03 ` Serge Semin 2021-02-08 14:03 ` [PATCH 18/20] net: stmmac: Move PTP clock enabling to PTP-init method Serge Semin 2021-02-08 14:03 ` Serge Semin 2021-02-08 14:03 ` [PATCH 19/20] net: stmmac: Move DMA stop procedure to HW-setup antagonist Serge Semin 2021-02-08 14:03 ` Serge Semin 2021-02-08 14:03 ` [PATCH 20/20] net: stmmac: Move MAC Tx/Rx disabling " Serge Semin 2021-02-08 14:03 ` Serge Semin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210210164720.migzigazyqsuxwc6@mobilestation \ --to=sergey.semin@baikalelectronics.ru \ --cc=Alexey.Malahov@baikalelectronics.ru \ --cc=Joao.Pinto@synopsys.com \ --cc=Jose.Abreu@synopsys.com \ --cc=Pavel.Parkhomenko@baikalelectronics.ru \ --cc=Vyacheslav.Mitrofanov@baikalelectronics.ru \ --cc=alexandre.torgue@st.com \ --cc=andrew@lunn.ch \ --cc=davem@davemloft.net \ --cc=fancer.lancer@gmail.com \ --cc=hkallweit1@gmail.com \ --cc=joabreu@synopsys.com \ --cc=kuba@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=linux@armlinux.org.uk \ --cc=mcoquelin.stm32@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=peppe.cavallaro@st.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.