From: Mike Christie <michael.christie@oracle.com>
To: hch@lst.de, loberman@redhat.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
mst@redhat.com, stefanha@redhat.com
Subject: [PATCH 01/14] target: remove target_submit_cmd_map_sgls
Date: Thu, 11 Feb 2021 06:27:14 -0600 [thread overview]
Message-ID: <20210211122728.31721-1-michael.christie@oracle.com> (raw)
Thsee patches have some conflicts with some in_interrupt changes
so the following patches were made over Martin's 5.12 branches.
The patches handle Christoph's review comment to remove
target_submit_cmd_map_sgls in this thread:
https://www.spinics.net/lists/linux-scsi/msg154443.html
which is for the "target: fix cmd plugging and completion"
patchset:
https://patchwork.kernel.org/project/linux-scsi/list/?series=431163
The patches actually do a little more than just kill the
function and the set was getting longer, so I'm sending
it separately now. These patches do:
1. Breaks up target_submit_cmd_map_sgls into 3 helpers:
-------------------------------------------------------
- target_init_cmd: Do the basic general setup and get a refcount to
the session to make sure the caller can execute the cmd.
- target_submit_prep: Do the mapping, cdb processing and get a ref
to the lun.
- target_submit: Pass the cmd to LIO core for execution.
The above functions must be used by drivers that either:
- rely on lio for session shutdown synchronization by calling
target_stop_session.
- need to map sgls
2. Make target_submit_cmd easier to use.
----------------------------------------
It seems a lot of drivers were not handling target_submit_cmd*
errors correctly, or were handling it but it would never return a
failure for them. The only way target_submit_cmd* would fail is if
the driver also used target_stop_session, but a lot of drivers
did their own session sync up, so I simplified the API.
target_submit_cmd never returns a failure so callers do not have
worry about it.
next reply other threads:[~2021-02-11 12:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 12:27 Mike Christie [this message]
2021-02-11 12:27 ` [PATCH 01/14] target: move t_task_cdb initialization Mike Christie
2021-02-11 12:27 ` [PATCH 02/14] target: drop kref_get_unless_zero in target_get_sess_cmd Mike Christie
2021-02-11 15:09 ` Christoph Hellwig
2021-02-11 12:27 ` [PATCH 03/14] target: rename transport_init_se_cmd Mike Christie
2021-02-11 15:10 ` Christoph Hellwig
2021-02-11 12:27 ` [PATCH 04/14] target: break up target_submit_cmd_map_sgls Mike Christie
2021-02-11 15:12 ` Christoph Hellwig
2021-02-11 12:27 ` [PATCH 05/14] srpt: Convert to new submission API Mike Christie
2021-02-11 15:13 ` Christoph Hellwig
2021-02-11 12:27 ` [PATCH 06/14] ibmvscsi_tgt: " Mike Christie
2021-02-11 15:14 ` Christoph Hellwig
2021-02-11 12:27 ` [PATCH 07/14] qla2xxx: " Mike Christie
2021-02-11 15:14 ` Christoph Hellwig
2021-02-11 12:27 ` [PATCH 08/14] tcm_loop: " Mike Christie
2021-02-11 15:14 ` Christoph Hellwig
2021-02-11 12:27 ` [PATCH 09/14] sbp_target: " Mike Christie
2021-02-11 15:15 ` Christoph Hellwig
2021-02-11 12:27 ` [PATCH 10/14] usb gadget: " Mike Christie
2021-02-11 15:15 ` Christoph Hellwig
2021-02-11 12:27 ` [PATCH 11/14] vhost-scsi: " Mike Christie
2021-02-11 12:27 ` [PATCH 12/14] xen-scsiback: " Mike Christie
2021-02-11 15:16 ` Christoph Hellwig
2021-02-11 12:27 ` [PATCH 13/14] tcm_fc: " Mike Christie
2021-02-11 15:16 ` Christoph Hellwig
2021-02-11 12:27 ` [PATCH 14/14] target: remove target_submit_cmd_map_sgls Mike Christie
2021-02-11 15:17 ` Christoph Hellwig
2021-02-11 18:11 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210211122728.31721-1-michael.christie@oracle.com \
--to=michael.christie@oracle.com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=martin.petersen@oracle.com \
--cc=mst@redhat.com \
--cc=stefanha@redhat.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.