From: Christoph Hellwig <hch@lst.de>
To: Mike Christie <michael.christie@oracle.com>
Cc: hch@lst.de, loberman@redhat.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
mst@redhat.com, stefanha@redhat.com
Subject: Re: [PATCH 14/14] target: remove target_submit_cmd_map_sgls
Date: Thu, 11 Feb 2021 16:17:50 +0100 [thread overview]
Message-ID: <20210211151750.GL22082@lst.de> (raw)
In-Reply-To: <20210211122728.31721-15-michael.christie@oracle.com>
> + * This function must only be used by drivers that do their own
> + * sync during shutdown and does not use target_stop_session. If there
> + * is a failure this function will call into the fabric driver's
> + * queue_status with a CHECK_CONDITION.
> */
> -int target_submit_cmd(struct se_cmd *se_cmd, struct se_session *se_sess,
> +void target_submit_cmd(struct se_cmd *se_cmd, struct se_session *se_sess,
> unsigned char *cdb, unsigned char *sense, u64 unpacked_lun,
> u32 data_length, int task_attr, int data_dir, int flags)
> {
> + target_init_cmd(se_cmd, se_sess, sense, unpacked_lun, data_length,
> + task_attr, data_dir, flags);
> + target_submit_prep(se_cmd, cdb, NULL, 0, NULL, 0, NULL, 0);
Do we want a WARN_ON_ONCE here to catch the case where the API is
misued?
next prev parent reply other threads:[~2021-02-11 15:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 12:27 [PATCH 01/14] target: remove target_submit_cmd_map_sgls Mike Christie
2021-02-11 12:27 ` [PATCH 01/14] target: move t_task_cdb initialization Mike Christie
2021-02-11 12:27 ` [PATCH 02/14] target: drop kref_get_unless_zero in target_get_sess_cmd Mike Christie
2021-02-11 15:09 ` Christoph Hellwig
2021-02-11 12:27 ` [PATCH 03/14] target: rename transport_init_se_cmd Mike Christie
2021-02-11 15:10 ` Christoph Hellwig
2021-02-11 12:27 ` [PATCH 04/14] target: break up target_submit_cmd_map_sgls Mike Christie
2021-02-11 15:12 ` Christoph Hellwig
2021-02-11 12:27 ` [PATCH 05/14] srpt: Convert to new submission API Mike Christie
2021-02-11 15:13 ` Christoph Hellwig
2021-02-11 12:27 ` [PATCH 06/14] ibmvscsi_tgt: " Mike Christie
2021-02-11 15:14 ` Christoph Hellwig
2021-02-11 12:27 ` [PATCH 07/14] qla2xxx: " Mike Christie
2021-02-11 15:14 ` Christoph Hellwig
2021-02-11 12:27 ` [PATCH 08/14] tcm_loop: " Mike Christie
2021-02-11 15:14 ` Christoph Hellwig
2021-02-11 12:27 ` [PATCH 09/14] sbp_target: " Mike Christie
2021-02-11 15:15 ` Christoph Hellwig
2021-02-11 12:27 ` [PATCH 10/14] usb gadget: " Mike Christie
2021-02-11 15:15 ` Christoph Hellwig
2021-02-11 12:27 ` [PATCH 11/14] vhost-scsi: " Mike Christie
2021-02-11 12:27 ` [PATCH 12/14] xen-scsiback: " Mike Christie
2021-02-11 15:16 ` Christoph Hellwig
2021-02-11 12:27 ` [PATCH 13/14] tcm_fc: " Mike Christie
2021-02-11 15:16 ` Christoph Hellwig
2021-02-11 12:27 ` [PATCH 14/14] target: remove target_submit_cmd_map_sgls Mike Christie
2021-02-11 15:17 ` Christoph Hellwig [this message]
2021-02-11 18:11 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210211151750.GL22082@lst.de \
--to=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=mst@redhat.com \
--cc=stefanha@redhat.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.