All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Pierre Morel <pmorel@linux.ibm.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
	frankja@linux.ibm.com, david@redhat.com, thuth@redhat.com,
	imbrenda@linux.ibm.com
Subject: Re: [kvm-unit-tests PATCH v2 1/5] s390x: css: Store CSS Characteristics
Date: Fri, 12 Feb 2021 11:32:59 +0100	[thread overview]
Message-ID: <20210212113259.32fe6906.cohuck@redhat.com> (raw)
In-Reply-To: <1612963214-30397-2-git-send-email-pmorel@linux.ibm.com>

On Wed, 10 Feb 2021 14:20:10 +0100
Pierre Morel <pmorel@linux.ibm.com> wrote:

> CSS characteristics exposes the features of the Channel SubSystem.
> Let's use Store Channel Subsystem Characteristics to retrieve
> the features of the CSS.
> 
> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> ---
>  lib/s390x/css.h     |  69 +++++++++++++++++++++++++++
>  lib/s390x/css_lib.c | 112 +++++++++++++++++++++++++++++++++++++++++++-
>  s390x/css.c         |  12 +++++
>  3 files changed, 192 insertions(+), 1 deletion(-)
> 

(...)

> +static const char *chsc_rsp_description[] = {
> +	"CHSC unknown error",
> +	"Command executed",
> +	"Invalid command",
> +	"Request-block error",
> +	"Command not installed",
> +	"Data not available",
> +		"Absolute address of channel-subsystem"
> +	"communication block exceeds 2 - 1.",

"2G - 1", I think?

> +	"Invalid command format",
> +	"Invalid channel-subsystem identification (CSSID)",
> +	"The command-request block specified an invalid format"
> +		"for the command response block.",
> +	"Invalid subchannel-set identification (SSID)",
> +	"A busy condition precludes execution.",
> +};

(...)

This matches both the Linux implementation and my memories, so

Reviewed-by: Cornelia Huck <cohuck@redhat.com>


  reply	other threads:[~2021-02-12 10:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10 13:20 [kvm-unit-tests PATCH v2 0/5] CSS Mesurement Block Pierre Morel
2021-02-10 13:20 ` [kvm-unit-tests PATCH v2 1/5] s390x: css: Store CSS Characteristics Pierre Morel
2021-02-12 10:32   ` Cornelia Huck [this message]
2021-02-12 15:35     ` Pierre Morel
2021-02-10 13:20 ` [kvm-unit-tests PATCH v2 2/5] s390x: css: simplifications of the tests Pierre Morel
2021-02-12 10:36   ` Cornelia Huck
2021-02-12 15:36     ` Pierre Morel
2021-02-10 13:20 ` [kvm-unit-tests PATCH v2 3/5] s390x: css: implementing Set CHannel Monitor Pierre Morel
2021-02-12 10:53   ` Cornelia Huck
2021-02-12 15:51     ` Pierre Morel
2021-02-10 13:20 ` [kvm-unit-tests PATCH v2 4/5] s390x: css: testing measurement block format 0 Pierre Morel
2021-02-12 11:12   ` Cornelia Huck
2021-02-12 15:59     ` Pierre Morel
2021-02-10 13:20 ` [kvm-unit-tests PATCH v2 5/5] s390x: css: testing measurement block format 1 Pierre Morel
2021-02-12 11:15   ` Cornelia Huck
2021-02-12 16:04     ` Pierre Morel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210212113259.32fe6906.cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=pmorel@linux.ibm.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.