Re: [PATCH] Revert "ARM: dts: bcm2711: Add the BSC interrupt controller"

From: Maxime Ripard <maxime@cerno.tech>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
	dave.stevenson@raspberrypi.com, maz@kernel.org, eric@anholt.net,
	tzimmermann@suse.de, linux-rpi-kernel@lists.infradead.org,
	hverkuil-cisco@xs4all.nl, nsaenzjulienne@suse.de,
	mchehab@kernel.org, linux-media@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	dri-devel@lists.freedesktop.org, Rob Herring <robh+dt@kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Revert "ARM: dts: bcm2711: Add the BSC interrupt controller"
Date: Tue, 16 Feb 2021 08:55:30 +0100	[thread overview]
Message-ID: <20210216075530.knleci6sv4m667vv@gilmour> (raw)
In-Reply-To: <20210212191104.2365912-1-f.fainelli@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 841 bytes --]

On Fri, Feb 12, 2021 at 11:11:04AM -0800, Florian Fainelli wrote:
> As Dave reported:
> 
> This seems to have unintended side effects.  GIC interrupt 117 is shared
> between the standard I2C controllers (i2c-bcm2835) and the l2-intc block
> handling the HDMI I2C interrupts.
> 
> There is not a great way to share an interrupt between an interrupt
> controller using the chained IRQ handler which is an interrupt flow and
> another driver like i2c-bcm2835 which uses an interrupt handler
> (although it specifies IRQF_SHARED).
> 
> Simply revert this change for now which will mean that HDMI I2C will be
> polled, like it was before.
> 
> Reported-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Acked-by: Maxime Ripard <mripard@kernel.org>

Thanks!
Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]