From: Atul Gopinathan <atulgopinathan@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: comedi: cast to (unsigned int *)
Date: Wed, 17 Feb 2021 23:40:00 +0530 [thread overview]
Message-ID: <20210217181000.GB10124@atulu-ubuntu> (raw)
In-Reply-To: <YC1T06VCh0K2BBW5@kroah.com>
On Wed, Feb 17, 2021 at 06:35:15PM +0100, Greg KH wrote:
> On Wed, Feb 17, 2021 at 10:29:08PM +0530, Atul Gopinathan wrote:
> > Resolve the following warning generated by sparse:
> >
> > drivers/staging//comedi/comedi_fops.c:2956:23: warning: incorrect type in assignment (different address spaces)
> > drivers/staging//comedi/comedi_fops.c:2956:23: expected unsigned int *chanlist
> > drivers/staging//comedi/comedi_fops.c:2956:23: got void [noderef] <asn:1> *
> >
> > compat_ptr() has a return type of "void __user *"
> > as defined in "include/linux/compat.h"
> >
> > cmd->chanlist is of type "unsigned int *" as defined
> > in drivers/staging/comedi/comedi.h" in struct
> > comedi_cmd.
> >
> > Signed-off-by: Atul Gopinathan <atulgopinathan@gmail.com>
> > ---
> > drivers/staging/comedi/comedi_fops.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> > index e85a99b68f31..fc4ec38012b4 100644
> > --- a/drivers/staging/comedi/comedi_fops.c
> > +++ b/drivers/staging/comedi/comedi_fops.c
> > @@ -2953,7 +2953,7 @@ static int get_compat_cmd(struct comedi_cmd *cmd,
> > cmd->scan_end_arg = v32.scan_end_arg;
> > cmd->stop_src = v32.stop_src;
> > cmd->stop_arg = v32.stop_arg;
> > - cmd->chanlist = compat_ptr(v32.chanlist);
> > + cmd->chanlist = (unsigned int __force *)compat_ptr(v32.chanlist);
>
> __force? That feels wrong, something is odd if that is ever needed.
>
> Are you _sure_ this is correct?
The same file has instances of "(usigned int __force *)" cast being
used on the same "cmd->chanlist". For reference:
At line 1797 of comedi_fops.c:
1796 /* restore chanlist pointer before copying back */
1797 cmd->chanlist = (unsigned int __force *)user_chanlist;
1798 cmd->data = NULL;
At line 1880:
1879 /* restore chanlist pointer before copying back */
1880 cmd->chanlist = (unsigned int __force *)user_chanlist;
1881 *copy = true;
Here "user_chanlist" is of type "unsigned int __user *".
Or perhaps, I shouldn't be relying on them?
Thanks!
Atul
WARNING: multiple messages have this Message-ID (diff)
From: Atul Gopinathan <atulgopinathan@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, abbotti@mev.co.uk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: comedi: cast to (unsigned int *)
Date: Wed, 17 Feb 2021 23:40:00 +0530 [thread overview]
Message-ID: <20210217181000.GB10124@atulu-ubuntu> (raw)
In-Reply-To: <YC1T06VCh0K2BBW5@kroah.com>
On Wed, Feb 17, 2021 at 06:35:15PM +0100, Greg KH wrote:
> On Wed, Feb 17, 2021 at 10:29:08PM +0530, Atul Gopinathan wrote:
> > Resolve the following warning generated by sparse:
> >
> > drivers/staging//comedi/comedi_fops.c:2956:23: warning: incorrect type in assignment (different address spaces)
> > drivers/staging//comedi/comedi_fops.c:2956:23: expected unsigned int *chanlist
> > drivers/staging//comedi/comedi_fops.c:2956:23: got void [noderef] <asn:1> *
> >
> > compat_ptr() has a return type of "void __user *"
> > as defined in "include/linux/compat.h"
> >
> > cmd->chanlist is of type "unsigned int *" as defined
> > in drivers/staging/comedi/comedi.h" in struct
> > comedi_cmd.
> >
> > Signed-off-by: Atul Gopinathan <atulgopinathan@gmail.com>
> > ---
> > drivers/staging/comedi/comedi_fops.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> > index e85a99b68f31..fc4ec38012b4 100644
> > --- a/drivers/staging/comedi/comedi_fops.c
> > +++ b/drivers/staging/comedi/comedi_fops.c
> > @@ -2953,7 +2953,7 @@ static int get_compat_cmd(struct comedi_cmd *cmd,
> > cmd->scan_end_arg = v32.scan_end_arg;
> > cmd->stop_src = v32.stop_src;
> > cmd->stop_arg = v32.stop_arg;
> > - cmd->chanlist = compat_ptr(v32.chanlist);
> > + cmd->chanlist = (unsigned int __force *)compat_ptr(v32.chanlist);
>
> __force? That feels wrong, something is odd if that is ever needed.
>
> Are you _sure_ this is correct?
The same file has instances of "(usigned int __force *)" cast being
used on the same "cmd->chanlist". For reference:
At line 1797 of comedi_fops.c:
1796 /* restore chanlist pointer before copying back */
1797 cmd->chanlist = (unsigned int __force *)user_chanlist;
1798 cmd->data = NULL;
At line 1880:
1879 /* restore chanlist pointer before copying back */
1880 cmd->chanlist = (unsigned int __force *)user_chanlist;
1881 *copy = true;
Here "user_chanlist" is of type "unsigned int __user *".
Or perhaps, I shouldn't be relying on them?
Thanks!
Atul
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2021-02-17 18:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 16:59 [PATCH] staging: comedi: cast to (unsigned int *) Atul Gopinathan
2021-02-17 16:59 ` Atul Gopinathan
2021-02-17 17:35 ` Greg KH
2021-02-17 17:35 ` Greg KH
2021-02-17 18:10 ` Atul Gopinathan [this message]
2021-02-17 18:10 ` Atul Gopinathan
2021-02-17 18:26 ` Greg KH
2021-02-17 18:26 ` Greg KH
2021-02-18 11:04 ` Ian Abbott
2021-02-18 11:04 ` Ian Abbott
2021-02-19 9:03 ` David Laight
2021-02-19 9:03 ` David Laight
2021-02-19 9:26 ` Dan Carpenter
2021-02-19 9:26 ` Dan Carpenter
2021-02-19 9:36 ` David Laight
2021-02-19 9:36 ` David Laight
2021-02-19 9:31 ` Ian Abbott
2021-02-19 9:31 ` Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210217181000.GB10124@atulu-ubuntu \
--to=atulgopinathan@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.