All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Anton Yakovlev <anton.yakovlev@opensynergy.com>
Cc: virtio-dev@lists.oasis-open.org, alsa-devel@alsa-project.org,
	Takashi Iwai <tiwai@suse.com>,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v5 0/9] ALSA: add virtio sound driver
Date: Tue, 23 Feb 2021 07:09:01 -0500	[thread overview]
Message-ID: <20210223070839-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20210222153444.348390-1-anton.yakovlev@opensynergy.com>

On Mon, Feb 22, 2021 at 04:34:35PM +0100, Anton Yakovlev wrote:
> This series implements a driver part of the virtio sound device
> specification v8 [1].
> 
> The driver supports PCM playback and capture substreams, jack and
> channel map controls. A message-based transport is used to write/read
> PCM frames to/from a device.
> 
> As a device part was used OpenSynergy proprietary implementation.
> 
> v5 changes:
>  - Fixed another bunch of sparse warnings
>    (replaced virtio_cread() -> virtio_cread_le()), no functional changes.
> (Sorry, I didn't know how to run sparse locally, now everything should be fixed)
> 
> [1] https://lists.oasis-open.org/archives/virtio-dev/202003/msg00185.html


In the future please number patches from 1, not from 2.
thanks!

> 
> Anton Yakovlev (9):
>   uapi: virtio_ids: add a sound device type ID from OASIS spec
>   ALSA: virtio: add virtio sound driver
>   ALSA: virtio: handling control messages
>   ALSA: virtio: build PCM devices and substream hardware descriptors
>   ALSA: virtio: handling control and I/O messages for the PCM device
>   ALSA: virtio: PCM substream operators
>   ALSA: virtio: introduce jack support
>   ALSA: virtio: introduce PCM channel map support
>   ALSA: virtio: introduce device suspend/resume support
> 
>  MAINTAINERS                     |   9 +
>  include/uapi/linux/virtio_ids.h |   1 +
>  include/uapi/linux/virtio_snd.h | 334 +++++++++++++++++++++
>  sound/Kconfig                   |   2 +
>  sound/Makefile                  |   3 +-
>  sound/virtio/Kconfig            |  10 +
>  sound/virtio/Makefile           |  13 +
>  sound/virtio/virtio_card.c      | 462 +++++++++++++++++++++++++++++
>  sound/virtio/virtio_card.h      | 113 ++++++++
>  sound/virtio/virtio_chmap.c     | 219 ++++++++++++++
>  sound/virtio/virtio_ctl_msg.c   | 310 ++++++++++++++++++++
>  sound/virtio/virtio_ctl_msg.h   |  78 +++++
>  sound/virtio/virtio_jack.c      | 233 +++++++++++++++
>  sound/virtio/virtio_pcm.c       | 498 ++++++++++++++++++++++++++++++++
>  sound/virtio/virtio_pcm.h       | 120 ++++++++
>  sound/virtio/virtio_pcm_msg.c   | 392 +++++++++++++++++++++++++
>  sound/virtio/virtio_pcm_ops.c   | 491 +++++++++++++++++++++++++++++++
>  17 files changed, 3287 insertions(+), 1 deletion(-)
>  create mode 100644 include/uapi/linux/virtio_snd.h
>  create mode 100644 sound/virtio/Kconfig
>  create mode 100644 sound/virtio/Makefile
>  create mode 100644 sound/virtio/virtio_card.c
>  create mode 100644 sound/virtio/virtio_card.h
>  create mode 100644 sound/virtio/virtio_chmap.c
>  create mode 100644 sound/virtio/virtio_ctl_msg.c
>  create mode 100644 sound/virtio/virtio_ctl_msg.h
>  create mode 100644 sound/virtio/virtio_jack.c
>  create mode 100644 sound/virtio/virtio_pcm.c
>  create mode 100644 sound/virtio/virtio_pcm.h
>  create mode 100644 sound/virtio/virtio_pcm_msg.c
>  create mode 100644 sound/virtio/virtio_pcm_ops.c
> 
> -- 
> 2.30.0
> 


WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Anton Yakovlev <anton.yakovlev@opensynergy.com>
Cc: virtio-dev@lists.oasis-open.org, alsa-devel@alsa-project.org,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v5 0/9] ALSA: add virtio sound driver
Date: Tue, 23 Feb 2021 07:09:01 -0500	[thread overview]
Message-ID: <20210223070839-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20210222153444.348390-1-anton.yakovlev@opensynergy.com>

On Mon, Feb 22, 2021 at 04:34:35PM +0100, Anton Yakovlev wrote:
> This series implements a driver part of the virtio sound device
> specification v8 [1].
> 
> The driver supports PCM playback and capture substreams, jack and
> channel map controls. A message-based transport is used to write/read
> PCM frames to/from a device.
> 
> As a device part was used OpenSynergy proprietary implementation.
> 
> v5 changes:
>  - Fixed another bunch of sparse warnings
>    (replaced virtio_cread() -> virtio_cread_le()), no functional changes.
> (Sorry, I didn't know how to run sparse locally, now everything should be fixed)
> 
> [1] https://lists.oasis-open.org/archives/virtio-dev/202003/msg00185.html


In the future please number patches from 1, not from 2.
thanks!

> 
> Anton Yakovlev (9):
>   uapi: virtio_ids: add a sound device type ID from OASIS spec
>   ALSA: virtio: add virtio sound driver
>   ALSA: virtio: handling control messages
>   ALSA: virtio: build PCM devices and substream hardware descriptors
>   ALSA: virtio: handling control and I/O messages for the PCM device
>   ALSA: virtio: PCM substream operators
>   ALSA: virtio: introduce jack support
>   ALSA: virtio: introduce PCM channel map support
>   ALSA: virtio: introduce device suspend/resume support
> 
>  MAINTAINERS                     |   9 +
>  include/uapi/linux/virtio_ids.h |   1 +
>  include/uapi/linux/virtio_snd.h | 334 +++++++++++++++++++++
>  sound/Kconfig                   |   2 +
>  sound/Makefile                  |   3 +-
>  sound/virtio/Kconfig            |  10 +
>  sound/virtio/Makefile           |  13 +
>  sound/virtio/virtio_card.c      | 462 +++++++++++++++++++++++++++++
>  sound/virtio/virtio_card.h      | 113 ++++++++
>  sound/virtio/virtio_chmap.c     | 219 ++++++++++++++
>  sound/virtio/virtio_ctl_msg.c   | 310 ++++++++++++++++++++
>  sound/virtio/virtio_ctl_msg.h   |  78 +++++
>  sound/virtio/virtio_jack.c      | 233 +++++++++++++++
>  sound/virtio/virtio_pcm.c       | 498 ++++++++++++++++++++++++++++++++
>  sound/virtio/virtio_pcm.h       | 120 ++++++++
>  sound/virtio/virtio_pcm_msg.c   | 392 +++++++++++++++++++++++++
>  sound/virtio/virtio_pcm_ops.c   | 491 +++++++++++++++++++++++++++++++
>  17 files changed, 3287 insertions(+), 1 deletion(-)
>  create mode 100644 include/uapi/linux/virtio_snd.h
>  create mode 100644 sound/virtio/Kconfig
>  create mode 100644 sound/virtio/Makefile
>  create mode 100644 sound/virtio/virtio_card.c
>  create mode 100644 sound/virtio/virtio_card.h
>  create mode 100644 sound/virtio/virtio_chmap.c
>  create mode 100644 sound/virtio/virtio_ctl_msg.c
>  create mode 100644 sound/virtio/virtio_ctl_msg.h
>  create mode 100644 sound/virtio/virtio_jack.c
>  create mode 100644 sound/virtio/virtio_pcm.c
>  create mode 100644 sound/virtio/virtio_pcm.h
>  create mode 100644 sound/virtio/virtio_pcm_msg.c
>  create mode 100644 sound/virtio/virtio_pcm_ops.c
> 
> -- 
> 2.30.0
> 

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Anton Yakovlev <anton.yakovlev@opensynergy.com>
Cc: virtualization@lists.linux-foundation.org,
	alsa-devel@alsa-project.org, virtio-dev@lists.oasis-open.org,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Subject: [virtio-dev] Re: [PATCH v5 0/9] ALSA: add virtio sound driver
Date: Tue, 23 Feb 2021 07:09:01 -0500	[thread overview]
Message-ID: <20210223070839-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20210222153444.348390-1-anton.yakovlev@opensynergy.com>

On Mon, Feb 22, 2021 at 04:34:35PM +0100, Anton Yakovlev wrote:
> This series implements a driver part of the virtio sound device
> specification v8 [1].
> 
> The driver supports PCM playback and capture substreams, jack and
> channel map controls. A message-based transport is used to write/read
> PCM frames to/from a device.
> 
> As a device part was used OpenSynergy proprietary implementation.
> 
> v5 changes:
>  - Fixed another bunch of sparse warnings
>    (replaced virtio_cread() -> virtio_cread_le()), no functional changes.
> (Sorry, I didn't know how to run sparse locally, now everything should be fixed)
> 
> [1] https://lists.oasis-open.org/archives/virtio-dev/202003/msg00185.html


In the future please number patches from 1, not from 2.
thanks!

> 
> Anton Yakovlev (9):
>   uapi: virtio_ids: add a sound device type ID from OASIS spec
>   ALSA: virtio: add virtio sound driver
>   ALSA: virtio: handling control messages
>   ALSA: virtio: build PCM devices and substream hardware descriptors
>   ALSA: virtio: handling control and I/O messages for the PCM device
>   ALSA: virtio: PCM substream operators
>   ALSA: virtio: introduce jack support
>   ALSA: virtio: introduce PCM channel map support
>   ALSA: virtio: introduce device suspend/resume support
> 
>  MAINTAINERS                     |   9 +
>  include/uapi/linux/virtio_ids.h |   1 +
>  include/uapi/linux/virtio_snd.h | 334 +++++++++++++++++++++
>  sound/Kconfig                   |   2 +
>  sound/Makefile                  |   3 +-
>  sound/virtio/Kconfig            |  10 +
>  sound/virtio/Makefile           |  13 +
>  sound/virtio/virtio_card.c      | 462 +++++++++++++++++++++++++++++
>  sound/virtio/virtio_card.h      | 113 ++++++++
>  sound/virtio/virtio_chmap.c     | 219 ++++++++++++++
>  sound/virtio/virtio_ctl_msg.c   | 310 ++++++++++++++++++++
>  sound/virtio/virtio_ctl_msg.h   |  78 +++++
>  sound/virtio/virtio_jack.c      | 233 +++++++++++++++
>  sound/virtio/virtio_pcm.c       | 498 ++++++++++++++++++++++++++++++++
>  sound/virtio/virtio_pcm.h       | 120 ++++++++
>  sound/virtio/virtio_pcm_msg.c   | 392 +++++++++++++++++++++++++
>  sound/virtio/virtio_pcm_ops.c   | 491 +++++++++++++++++++++++++++++++
>  17 files changed, 3287 insertions(+), 1 deletion(-)
>  create mode 100644 include/uapi/linux/virtio_snd.h
>  create mode 100644 sound/virtio/Kconfig
>  create mode 100644 sound/virtio/Makefile
>  create mode 100644 sound/virtio/virtio_card.c
>  create mode 100644 sound/virtio/virtio_card.h
>  create mode 100644 sound/virtio/virtio_chmap.c
>  create mode 100644 sound/virtio/virtio_ctl_msg.c
>  create mode 100644 sound/virtio/virtio_ctl_msg.h
>  create mode 100644 sound/virtio/virtio_jack.c
>  create mode 100644 sound/virtio/virtio_pcm.c
>  create mode 100644 sound/virtio/virtio_pcm.h
>  create mode 100644 sound/virtio/virtio_pcm_msg.c
>  create mode 100644 sound/virtio/virtio_pcm_ops.c
> 
> -- 
> 2.30.0
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  parent reply	other threads:[~2021-02-23 12:10 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-22 15:34 [PATCH v5 0/9] ALSA: add virtio sound driver Anton Yakovlev
2021-02-22 15:34 ` [virtio-dev] " Anton Yakovlev
2021-02-22 15:34 ` Anton Yakovlev
2021-02-22 15:34 ` [PATCH v5 1/9] uapi: virtio_ids: add a sound device type ID from OASIS spec Anton Yakovlev
2021-02-22 15:34   ` [virtio-dev] " Anton Yakovlev
2021-02-22 15:34   ` Anton Yakovlev
2021-02-22 15:34   ` Anton Yakovlev
2021-02-22 15:34 ` [PATCH v5 2/9] ALSA: virtio: add virtio sound driver Anton Yakovlev
2021-02-22 15:34   ` [virtio-dev] " Anton Yakovlev
2021-02-22 15:34   ` Anton Yakovlev
2021-02-22 15:34   ` Anton Yakovlev
2021-02-25 10:38   ` Takashi Iwai
2021-02-25 10:38     ` Takashi Iwai
2021-02-25 10:39     ` Takashi Iwai
2021-02-25 10:39       ` Takashi Iwai
2021-02-25 11:51     ` Anton Yakovlev
2021-02-25 11:51       ` [virtio-dev] " Anton Yakovlev
2021-02-25 11:51       ` Anton Yakovlev
2021-02-25 11:51       ` Anton Yakovlev
2021-02-25 12:08       ` Takashi Iwai
2021-02-25 12:08         ` Takashi Iwai
2021-02-22 15:34 ` [PATCH v5 3/9] ALSA: virtio: handling control messages Anton Yakovlev
2021-02-22 15:34   ` [virtio-dev] " Anton Yakovlev
2021-02-22 15:34   ` Anton Yakovlev
2021-02-22 15:34   ` Anton Yakovlev
2021-02-22 15:34 ` [PATCH v5 4/9] ALSA: virtio: build PCM devices and substream hardware descriptors Anton Yakovlev
2021-02-22 15:34   ` [virtio-dev] " Anton Yakovlev
2021-02-22 15:34   ` Anton Yakovlev
2021-02-22 15:34   ` Anton Yakovlev
2021-02-22 15:34 ` [PATCH v5 5/9] ALSA: virtio: handling control and I/O messages for the PCM device Anton Yakovlev
2021-02-22 15:34   ` [virtio-dev] " Anton Yakovlev
2021-02-22 15:34   ` Anton Yakovlev
2021-02-22 15:34   ` Anton Yakovlev
2021-02-25 10:45   ` Takashi Iwai
2021-02-25 10:45     ` Takashi Iwai
2021-02-22 15:34 ` [PATCH v5 6/9] ALSA: virtio: PCM substream operators Anton Yakovlev
2021-02-22 15:34   ` [virtio-dev] " Anton Yakovlev
2021-02-22 15:34   ` Anton Yakovlev
2021-02-22 15:34   ` Anton Yakovlev
2021-02-25 10:55   ` Takashi Iwai
2021-02-25 10:55     ` Takashi Iwai
2021-02-25 12:14     ` Anton Yakovlev
2021-02-25 12:14       ` [virtio-dev] " Anton Yakovlev
2021-02-25 12:14       ` Anton Yakovlev
2021-02-25 12:14       ` Anton Yakovlev
2021-02-25 12:51       ` Takashi Iwai
2021-02-25 12:51         ` Takashi Iwai
2021-02-25 19:02         ` Michael S. Tsirkin
2021-02-25 19:02           ` [virtio-dev] " Michael S. Tsirkin
2021-02-25 19:02           ` Michael S. Tsirkin
2021-02-25 19:02           ` Michael S. Tsirkin
2021-02-25 20:30           ` Takashi Iwai
2021-02-25 20:30             ` Takashi Iwai
2021-02-25 22:19             ` Anton Yakovlev
2021-02-25 22:19               ` [virtio-dev] " Anton Yakovlev
2021-02-25 22:19               ` Anton Yakovlev
2021-02-25 22:19               ` Anton Yakovlev
2021-02-26 14:23               ` Takashi Iwai
2021-02-26 14:23                 ` Takashi Iwai
2021-02-26 20:16                 ` Anton Yakovlev
2021-02-26 20:16                   ` [virtio-dev] " Anton Yakovlev
2021-02-26 20:16                   ` Anton Yakovlev
2021-02-26 20:16                   ` Anton Yakovlev
2021-02-26 20:19             ` Anton Yakovlev
2021-02-26 20:19               ` [virtio-dev] " Anton Yakovlev
2021-02-26 20:19               ` Anton Yakovlev
2021-02-26 20:19               ` Anton Yakovlev
2021-02-27  7:50               ` Takashi Iwai
2021-02-27  7:50                 ` Takashi Iwai
2021-02-22 15:34 ` [PATCH v5 7/9] ALSA: virtio: introduce jack support Anton Yakovlev
2021-02-22 15:34   ` [virtio-dev] " Anton Yakovlev
2021-02-22 15:34   ` Anton Yakovlev
2021-02-22 15:34   ` Anton Yakovlev
2021-02-22 15:34 ` [PATCH v5 8/9] ALSA: virtio: introduce PCM channel map support Anton Yakovlev
2021-02-22 15:34   ` [virtio-dev] " Anton Yakovlev
2021-02-22 15:34   ` Anton Yakovlev
2021-02-22 15:34   ` Anton Yakovlev
2021-02-22 15:34 ` [PATCH v5 9/9] ALSA: virtio: introduce device suspend/resume support Anton Yakovlev
2021-02-22 15:34   ` [virtio-dev] " Anton Yakovlev
2021-02-22 15:34   ` Anton Yakovlev
2021-02-22 15:34   ` Anton Yakovlev
2021-02-23 12:09 ` Michael S. Tsirkin [this message]
2021-02-23 12:09   ` [virtio-dev] Re: [PATCH v5 0/9] ALSA: add virtio sound driver Michael S. Tsirkin
2021-02-23 12:09   ` Michael S. Tsirkin
2021-02-23 12:33   ` [virtio-dev] " Anton Yakovlev
2021-02-23 12:33     ` Anton Yakovlev
2021-02-23 12:33     ` Anton Yakovlev
2021-02-23 12:59     ` Michael S. Tsirkin
2021-02-23 12:59       ` Michael S. Tsirkin
2021-02-23 12:59       ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210223070839-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=anton.yakovlev@opensynergy.com \
    --cc=tiwai@suse.com \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.