From: Maxime Ripard <maxime@cerno.tech>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: DRI Development <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
stable@vger.kernel.org,
syzbot+620cf21140fc7e772a5d@syzkaller.appspotmail.com
Subject: Re: [PATCH] drm/compat: Clear bounce structures
Date: Thu, 25 Feb 2021 17:49:11 +0100 [thread overview]
Message-ID: <20210225164911.k2bwswyivied36i5@gilmour> (raw)
In-Reply-To: <20210222100643.400935-1-daniel.vetter@ffwll.ch>
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
On Mon, Feb 22, 2021 at 11:06:43AM +0100, Daniel Vetter wrote:
> Some of them have gaps, or fields we don't clear. Native ioctl code
> does full copies plus zero-extends on size mismatch, so nothing can
> leak. But compat is more hand-rolled so need to be careful.
>
> None of these matter for performance, so just memset.
>
> Also I didn't fix up the CONFIG_DRM_LEGACY or CONFIG_DRM_AGP ioctl, those
> are security holes anyway.
>
> Reported-by: syzbot+620cf21140fc7e772a5d@syzkaller.appspotmail.com # vblank ioctl
> Cc: syzbot+620cf21140fc7e772a5d@syzkaller.appspotmail.com
> Cc: stable@vger.kernel.org
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Acked-by: Maxime Ripard <mripard@kernel.org>
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
stable@vger.kernel.org,
DRI Development <dri-devel@lists.freedesktop.org>,
syzbot+620cf21140fc7e772a5d@syzkaller.appspotmail.com
Subject: Re: [PATCH] drm/compat: Clear bounce structures
Date: Thu, 25 Feb 2021 17:49:11 +0100 [thread overview]
Message-ID: <20210225164911.k2bwswyivied36i5@gilmour> (raw)
In-Reply-To: <20210222100643.400935-1-daniel.vetter@ffwll.ch>
[-- Attachment #1.1: Type: text/plain, Size: 737 bytes --]
On Mon, Feb 22, 2021 at 11:06:43AM +0100, Daniel Vetter wrote:
> Some of them have gaps, or fields we don't clear. Native ioctl code
> does full copies plus zero-extends on size mismatch, so nothing can
> leak. But compat is more hand-rolled so need to be careful.
>
> None of these matter for performance, so just memset.
>
> Also I didn't fix up the CONFIG_DRM_LEGACY or CONFIG_DRM_AGP ioctl, those
> are security holes anyway.
>
> Reported-by: syzbot+620cf21140fc7e772a5d@syzkaller.appspotmail.com # vblank ioctl
> Cc: syzbot+620cf21140fc7e772a5d@syzkaller.appspotmail.com
> Cc: stable@vger.kernel.org
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Acked-by: Maxime Ripard <mripard@kernel.org>
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
stable@vger.kernel.org,
DRI Development <dri-devel@lists.freedesktop.org>,
syzbot+620cf21140fc7e772a5d@syzkaller.appspotmail.com
Subject: Re: [Intel-gfx] [PATCH] drm/compat: Clear bounce structures
Date: Thu, 25 Feb 2021 17:49:11 +0100 [thread overview]
Message-ID: <20210225164911.k2bwswyivied36i5@gilmour> (raw)
In-Reply-To: <20210222100643.400935-1-daniel.vetter@ffwll.ch>
[-- Attachment #1.1: Type: text/plain, Size: 737 bytes --]
On Mon, Feb 22, 2021 at 11:06:43AM +0100, Daniel Vetter wrote:
> Some of them have gaps, or fields we don't clear. Native ioctl code
> does full copies plus zero-extends on size mismatch, so nothing can
> leak. But compat is more hand-rolled so need to be careful.
>
> None of these matter for performance, so just memset.
>
> Also I didn't fix up the CONFIG_DRM_LEGACY or CONFIG_DRM_AGP ioctl, those
> are security holes anyway.
>
> Reported-by: syzbot+620cf21140fc7e772a5d@syzkaller.appspotmail.com # vblank ioctl
> Cc: syzbot+620cf21140fc7e772a5d@syzkaller.appspotmail.com
> Cc: stable@vger.kernel.org
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Acked-by: Maxime Ripard <mripard@kernel.org>
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-02-25 16:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 10:06 [PATCH] drm/compat: Clear bounce structures Daniel Vetter
2021-02-22 10:06 ` [Intel-gfx] " Daniel Vetter
2021-02-22 10:06 ` Daniel Vetter
2021-02-22 11:51 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2021-02-22 12:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-02-22 14:55 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-02-25 16:49 ` Maxime Ripard [this message]
2021-02-25 16:49 ` [Intel-gfx] [PATCH] " Maxime Ripard
2021-02-25 16:49 ` Maxime Ripard
2021-02-26 13:45 ` Daniel Vetter
2021-02-26 13:45 ` [Intel-gfx] " Daniel Vetter
2021-02-26 13:45 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210225164911.k2bwswyivied36i5@gilmour \
--to=maxime@cerno.tech \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+620cf21140fc7e772a5d@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.