From: Steven Rostedt <rostedt@goodmis.org> To: kernel test robot <oliver.sang@intel.com> Cc: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>, 0day robot <lkp@intel.com>, LKML <linux-kernel@vger.kernel.org>, lkp@lists.01.org, axboe@kernel.dk, viro@zeniv.linux.org.uk, mingo@redhat.com, johannes.thumshirn@wdc.com, damien.lemoal@wdc.com, bvanassche@acm.org, dongli.zhang@oracle.com, aravind.ramesh@wdc.com, joshi.k@samsung.com, niklas.cassel@wdc.com, hch@lst.de, osandov@fb.com, martin.petersen@oracle.com, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [blktrace] c055908abe: WARNING:at_kernel/trace/trace.c:#create_trace_option_files Date: Sat, 27 Feb 2021 09:49:16 -0500 [thread overview] Message-ID: <20210227094916.701a8a50@oasis.local.home> (raw) In-Reply-To: <20210227114440.GA22871@xsang-OptiPlex-9020> On Sat, 27 Feb 2021 19:44:40 +0800 kernel test robot <oliver.sang@intel.com> wrote: > [ 20.216017] WARNING: CPU: 0 PID: 1 at kernel/trace/trace.c:8370 create_trace_option_files (kbuild/src/consumer/kernel/trace/trace.c:8370 (discriminator 1)) > [ 20.218480] Modules linked in: > [ 20.219395] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.11.0-09341-gc055908abe0d #1 > [ 20.221182] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014 > [ 20.224540] EIP: create_trace_option_files (kbuild/src/consumer/kernel/trace/trace.c:8370 (discriminator 1)) > [ 20.225816] Code: d5 01 83 15 2c b7 08 d5 00 83 c0 01 39 c8 0f 84 c7 00 00 00 8b 14 c7 39 72 44 75 df 83 05 10 b7 08 d5 01 83 15 14 b7 08 d5 00 <0f> 0b 83 05 18 b7 08 d5 01 83 15 1c b7 08 d5 00 83 05 20 b7 08 d5 Looks to be from this: > +static struct tracer blk_tracer_ext __read_mostly = { > + .name = "blkext", > + .init = blk_tracer_init, > + .reset = blk_tracer_reset, > + .start = blk_tracer_start, > + .stop = blk_tracer_stop, > + .print_header = blk_tracer_print_header, > + .print_line = blk_tracer_print_line_ext, > + .flags = &blk_tracer_flags, ^^^ As blk_tracer already registers those flags, when it gets registered as a tracer, and flag names can not be duplicated. I could fix the infrastructure to detect the same set of flags being registered by two different tracers, but in the mean time, it may still work to use the blk_trace_flags from blk_tracer, and keep .flags NULL here. -- Steve > + .set_flag = blk_tracer_set_flag, > +}; > +
WARNING: multiple messages have this Message-ID (diff)
From: Steven Rostedt <rostedt@goodmis.org> To: lkp@lists.01.org Subject: Re: [blktrace] c055908abe: WARNING:at_kernel/trace/trace.c:#create_trace_option_files Date: Sat, 27 Feb 2021 09:49:16 -0500 [thread overview] Message-ID: <20210227094916.701a8a50@oasis.local.home> (raw) In-Reply-To: <20210227114440.GA22871@xsang-OptiPlex-9020> [-- Attachment #1: Type: text/plain, Size: 1616 bytes --] On Sat, 27 Feb 2021 19:44:40 +0800 kernel test robot <oliver.sang@intel.com> wrote: > [ 20.216017] WARNING: CPU: 0 PID: 1 at kernel/trace/trace.c:8370 create_trace_option_files (kbuild/src/consumer/kernel/trace/trace.c:8370 (discriminator 1)) > [ 20.218480] Modules linked in: > [ 20.219395] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.11.0-09341-gc055908abe0d #1 > [ 20.221182] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014 > [ 20.224540] EIP: create_trace_option_files (kbuild/src/consumer/kernel/trace/trace.c:8370 (discriminator 1)) > [ 20.225816] Code: d5 01 83 15 2c b7 08 d5 00 83 c0 01 39 c8 0f 84 c7 00 00 00 8b 14 c7 39 72 44 75 df 83 05 10 b7 08 d5 01 83 15 14 b7 08 d5 00 <0f> 0b 83 05 18 b7 08 d5 01 83 15 1c b7 08 d5 00 83 05 20 b7 08 d5 Looks to be from this: > +static struct tracer blk_tracer_ext __read_mostly = { > + .name = "blkext", > + .init = blk_tracer_init, > + .reset = blk_tracer_reset, > + .start = blk_tracer_start, > + .stop = blk_tracer_stop, > + .print_header = blk_tracer_print_header, > + .print_line = blk_tracer_print_line_ext, > + .flags = &blk_tracer_flags, ^^^ As blk_tracer already registers those flags, when it gets registered as a tracer, and flag names can not be duplicated. I could fix the infrastructure to detect the same set of flags being registered by two different tracers, but in the mean time, it may still work to use the blk_trace_flags from blk_tracer, and keep .flags NULL here. -- Steve > + .set_flag = blk_tracer_set_flag, > +}; > +
next prev parent reply other threads:[~2021-02-27 14:50 UTC|newest] Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-25 7:01 [RFC PATCH 00/39] blktrace: add block trace extension support Chaitanya Kulkarni 2021-02-25 7:01 ` [RFC PATCH 01/39] blktrace_api: add new trace definitions Chaitanya Kulkarni 2021-02-26 4:31 ` Damien Le Moal 2021-02-25 7:01 ` [RFC PATCH 02/39] blktrace_api: add new trace definition Chaitanya Kulkarni 2021-02-26 4:33 ` Damien Le Moal 2021-02-25 7:01 ` [RFC PATCH 03/39] blkdev.h: add new trace ext as a queue member Chaitanya Kulkarni 2021-02-26 4:35 ` Damien Le Moal 2021-02-25 7:01 ` [RFC PATCH 04/39] blktrace: add a new global list Chaitanya Kulkarni 2021-02-26 4:36 ` Damien Le Moal 2021-02-25 7:01 ` [RFC PATCH 05/39] blktrace: add trace note APIs Chaitanya Kulkarni 2021-02-25 9:07 ` kernel test robot 2021-02-25 12:12 ` kernel test robot 2021-02-26 4:39 ` Damien Le Moal 2021-02-25 7:01 ` [RFC PATCH 06/39] blktrace: add act and prio check helpers Chaitanya Kulkarni 2021-02-26 4:41 ` Damien Le Moal 2021-02-25 7:01 ` [RFC PATCH 07/39] blktrace: add core trace API Chaitanya Kulkarni 2021-02-26 4:44 ` Damien Le Moal 2021-02-25 7:02 ` [RFC PATCH 08/39] blktrace: update blk_add_trace_rq() Chaitanya Kulkarni 2021-02-26 4:46 ` Damien Le Moal 2021-02-25 7:02 ` [RFC PATCH 09/39] blktrace: update blk_add_trace_rq_insert() Chaitanya Kulkarni 2021-02-26 4:48 ` Damien Le Moal 2021-02-25 7:02 ` [RFC PATCH 10/39] blktrace: update blk_add_trace_rq_issue() Chaitanya Kulkarni 2021-02-25 13:14 ` kernel test robot 2021-02-26 4:48 ` Damien Le Moal 2021-02-25 7:02 ` [RFC PATCH 11/39] blktrace: update blk_add_trace_rq_requeue() Chaitanya Kulkarni 2021-02-26 4:48 ` Damien Le Moal 2021-02-25 7:02 ` [RFC PATCH 12/39] blktrace: update blk_add_trace_rq_complete() Chaitanya Kulkarni 2021-02-26 4:48 ` Damien Le Moal 2021-02-25 7:02 ` [RFC PATCH 13/39] blktrace: update blk_add_trace_bio() Chaitanya Kulkarni 2021-02-26 4:49 ` Damien Le Moal 2021-02-25 7:02 ` [RFC PATCH 14/39] blktrace: update blk_add_trace_bio_bounce() Chaitanya Kulkarni 2021-02-25 7:02 ` [RFC PATCH 15/39] blktrace: update blk_add_trace_bio_complete() Chaitanya Kulkarni 2021-02-25 7:02 ` [RFC PATCH 16/39] blktrace: update blk_add_trace_bio_backmerge() Chaitanya Kulkarni 2021-02-25 7:02 ` [RFC PATCH 17/39] blktrace: update blk_add_trace_bio_frontmerge() Chaitanya Kulkarni 2021-02-25 7:02 ` [RFC PATCH 18/39] blktrace: update blk_add_trace_bio_queue() Chaitanya Kulkarni 2021-02-25 7:02 ` [RFC PATCH 19/39] blktrace: update blk_add_trace_getrq() Chaitanya Kulkarni 2021-02-25 7:02 ` [RFC PATCH 20/39] blktrace: update blk_add_trace_plug() Chaitanya Kulkarni 2021-02-25 7:02 ` [RFC PATCH 21/39] blktrace: update blk_add_trace_unplug() Chaitanya Kulkarni 2021-02-25 7:02 ` [RFC PATCH 22/39] blktrace: update blk_add_trace_split() Chaitanya Kulkarni 2021-02-25 7:02 ` [RFC PATCH 23/39] blktrace: update blk_add_trace_bio_remap() Chaitanya Kulkarni 2021-02-25 7:02 ` [RFC PATCH 24/39] blktrace: update blk_add_trace_rq_remap() Chaitanya Kulkarni 2021-02-25 7:02 ` [RFC PATCH 25/39] blktrace: update blk_add_driver_data() Chaitanya Kulkarni 2021-02-25 7:02 ` [RFC PATCH 26/39] blktrace: add trace entry & pdu helpers Chaitanya Kulkarni 2021-02-25 7:02 ` [RFC PATCH 27/39] blktrace: add a new formatting routine Chaitanya Kulkarni 2021-02-25 7:02 ` [RFC PATCH 28/39] blktrace: add blk_log_xxx helpers() Chaitanya Kulkarni 2021-02-25 7:02 ` [RFC PATCH 29/39] blktrace: link blk_log_xxx() to trace action Chaitanya Kulkarni 2021-02-25 7:02 ` [RFC PATCH 30/39] blktrace: add trace event print helper Chaitanya Kulkarni 2021-02-25 7:02 ` [RFC PATCH 31/39] blktrace: add trace_synthesize helper Chaitanya Kulkarni 2021-02-25 7:02 ` [RFC PATCH 32/39] blktrace: add trace print helpers Chaitanya Kulkarni 2021-02-25 7:02 ` [RFC PATCH 33/39] blktrace: add blkext tracer Chaitanya Kulkarni 2021-02-27 11:44 ` [blktrace] c055908abe: WARNING:at_kernel/trace/trace.c:#create_trace_option_files kernel test robot 2021-02-27 11:44 ` kernel test robot 2021-02-27 14:49 ` Steven Rostedt [this message] 2021-02-27 14:49 ` Steven Rostedt 2021-02-27 19:51 ` Chaitanya Kulkarni 2021-02-27 19:51 ` Chaitanya Kulkarni 2021-02-25 7:02 ` [RFC PATCH 34/39] blktrace: implement setup-start-stop ioclts Chaitanya Kulkarni 2021-02-25 7:02 ` [RFC PATCH 35/39] block: update blkdev_ioctl with new trace ioctls Chaitanya Kulkarni 2021-02-25 7:02 ` [RFC PATCH 36/39] blktrace: add integrity tracking support Chaitanya Kulkarni 2021-02-25 7:02 ` [RFC PATCH 37/39] blktrace: update blk_fill_rwbs() with new requests Chaitanya Kulkarni 2021-02-25 7:02 ` [RFC PATCH 38/39] blktrace: track zone appaend completion sector Chaitanya Kulkarni 2021-02-25 7:02 ` [RFC PATCH 39/39] blktrace: debug patch for the demo Chaitanya Kulkarni 2021-02-26 4:25 ` [RFC PATCH 00/39] blktrace: add block trace extension support Damien Le Moal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210227094916.701a8a50@oasis.local.home \ --to=rostedt@goodmis.org \ --cc=aravind.ramesh@wdc.com \ --cc=axboe@kernel.dk \ --cc=bvanassche@acm.org \ --cc=chaitanya.kulkarni@wdc.com \ --cc=damien.lemoal@wdc.com \ --cc=dongli.zhang@oracle.com \ --cc=hch@lst.de \ --cc=johannes.thumshirn@wdc.com \ --cc=joshi.k@samsung.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lkp@intel.com \ --cc=lkp@lists.01.org \ --cc=martin.petersen@oracle.com \ --cc=mingo@redhat.com \ --cc=niklas.cassel@wdc.com \ --cc=oliver.sang@intel.com \ --cc=osandov@fb.com \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.