All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Fei Shao <fshao@chromium.org>,
	Eddie Huang <eddie.huang@mediatek.com>,
	Sean Wang <sean.wang@mediatek.com>,
	Yuchen Huang <yuchen.huang@mediatek.com>,
	Ran Bi <ran.bi@mediatek.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-rtc@vger.kernel.org, srv_heupstream@mediatek.com,
	Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH RESEND v5 7/8] regulator: mt6359: Add support for MT6359P regulator
Date: Mon, 1 Mar 2021 10:21:56 +0000	[thread overview]
Message-ID: <20210301102156.GJ641347@dell> (raw)
In-Reply-To: <1611913781-23460-8-git-send-email-hsin-hsiung.wang@mediatek.com>

On Fri, 29 Jan 2021, Hsin-Hsiung Wang wrote:

> The MT6359P is a eco version for MT6359 regulator.
> We add support based on MT6359 regulator driver.
> 
> Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
> ---
> changes since v4:
> - add the regulators_node support.
> ---
>  drivers/regulator/mt6359-regulator.c       | 379 ++++++++++++++++++++-

>  include/linux/mfd/mt6359p/registers.h      | 249 ++++++++++++++

Although the code is fine, just be aware that Linus can get grumpy
having 100s and 100s of unused register defines in the kernel.

>  include/linux/regulator/mt6359-regulator.h |   1 +
>  3 files changed, 623 insertions(+), 6 deletions(-)
>  create mode 100644 include/linux/mfd/mt6359p/registers.h

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
Cc: linux-rtc@vger.kernel.org,
	Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	srv_heupstream@mediatek.com, Fei Shao <fshao@chromium.org>,
	Ran Bi <ran.bi@mediatek.com>, Sean Wang <sean.wang@mediatek.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-kernel@vger.kernel.org,
	Project_Global_Chrome_Upstream_Group@mediatek.com,
	devicetree@vger.kernel.org, Mark Brown <broonie@kernel.org>,
	linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Eddie Huang <eddie.huang@mediatek.com>,
	Yuchen Huang <yuchen.huang@mediatek.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RESEND v5 7/8] regulator: mt6359: Add support for MT6359P regulator
Date: Mon, 1 Mar 2021 10:21:56 +0000	[thread overview]
Message-ID: <20210301102156.GJ641347@dell> (raw)
In-Reply-To: <1611913781-23460-8-git-send-email-hsin-hsiung.wang@mediatek.com>

On Fri, 29 Jan 2021, Hsin-Hsiung Wang wrote:

> The MT6359P is a eco version for MT6359 regulator.
> We add support based on MT6359 regulator driver.
> 
> Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
> ---
> changes since v4:
> - add the regulators_node support.
> ---
>  drivers/regulator/mt6359-regulator.c       | 379 ++++++++++++++++++++-

>  include/linux/mfd/mt6359p/registers.h      | 249 ++++++++++++++

Although the code is fine, just be aware that Linus can get grumpy
having 100s and 100s of unused register defines in the kernel.

>  include/linux/regulator/mt6359-regulator.h |   1 +
>  3 files changed, 623 insertions(+), 6 deletions(-)
>  create mode 100644 include/linux/mfd/mt6359p/registers.h

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
Cc: linux-rtc@vger.kernel.org,
	Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	srv_heupstream@mediatek.com, Fei Shao <fshao@chromium.org>,
	Ran Bi <ran.bi@mediatek.com>, Sean Wang <sean.wang@mediatek.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-kernel@vger.kernel.org,
	Project_Global_Chrome_Upstream_Group@mediatek.com,
	devicetree@vger.kernel.org, Mark Brown <broonie@kernel.org>,
	linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Eddie Huang <eddie.huang@mediatek.com>,
	Yuchen Huang <yuchen.huang@mediatek.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RESEND v5 7/8] regulator: mt6359: Add support for MT6359P regulator
Date: Mon, 1 Mar 2021 10:21:56 +0000	[thread overview]
Message-ID: <20210301102156.GJ641347@dell> (raw)
In-Reply-To: <1611913781-23460-8-git-send-email-hsin-hsiung.wang@mediatek.com>

On Fri, 29 Jan 2021, Hsin-Hsiung Wang wrote:

> The MT6359P is a eco version for MT6359 regulator.
> We add support based on MT6359 regulator driver.
> 
> Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
> ---
> changes since v4:
> - add the regulators_node support.
> ---
>  drivers/regulator/mt6359-regulator.c       | 379 ++++++++++++++++++++-

>  include/linux/mfd/mt6359p/registers.h      | 249 ++++++++++++++

Although the code is fine, just be aware that Linus can get grumpy
having 100s and 100s of unused register defines in the kernel.

>  include/linux/regulator/mt6359-regulator.h |   1 +
>  3 files changed, 623 insertions(+), 6 deletions(-)
>  create mode 100644 include/linux/mfd/mt6359p/registers.h

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-03-01 10:25 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-29  9:49 [PATCH RESEND v5 0/8] Add Support for MediaTek PMIC MT6359 Hsin-Hsiung Wang
2021-01-29  9:49 ` Hsin-Hsiung Wang
2021-01-29  9:49 ` [PATCH RESEND v5 1/8] mfd: mt6358: refine interrupt code Hsin-Hsiung Wang
2021-01-29  9:49   ` Hsin-Hsiung Wang
2021-01-29  9:49 ` [PATCH RESEND v5 2/8] rtc: mt6397: refine RTC_TC_MTH Hsin-Hsiung Wang
2021-01-29  9:49   ` Hsin-Hsiung Wang
2021-01-29  9:49 ` [PATCH RESEND v5 3/8] dt-bindings: mfd: Add compatible for the MediaTek MT6359 PMIC Hsin-Hsiung Wang
2021-01-29  9:49   ` Hsin-Hsiung Wang
2021-01-29  9:49   ` Hsin-Hsiung Wang
2021-02-05 22:04   ` Rob Herring
2021-02-05 22:04     ` Rob Herring
2021-02-05 22:04     ` Rob Herring
2021-01-29  9:49 ` [PATCH RESEND v5 4/8] dt-bindings: regulator: Add document for MT6359 regulator Hsin-Hsiung Wang
2021-01-29  9:49   ` Hsin-Hsiung Wang
2021-01-29  9:49   ` Hsin-Hsiung Wang
2021-01-30 17:23   ` Rob Herring
2021-01-30 17:23     ` Rob Herring
2021-01-30 17:23     ` Rob Herring
2021-01-29  9:49 ` [PATCH RESEND v5 5/8] mfd: Add support for the MediaTek MT6359 PMIC Hsin-Hsiung Wang
2021-01-29  9:49   ` Hsin-Hsiung Wang
2021-03-01 10:20   ` Lee Jones
2021-03-01 10:20     ` Lee Jones
2021-03-01 10:20     ` Lee Jones
2021-03-12 16:13     ` Hsin-hsiung Wang
2021-03-12 16:13       ` Hsin-hsiung Wang
2021-03-12 16:13       ` Hsin-hsiung Wang
2021-01-29  9:49 ` [PATCH RESEND v5 6/8] regulator: mt6359: Add support for MT6359 regulator Hsin-Hsiung Wang
2021-01-29  9:49   ` Hsin-Hsiung Wang
2021-01-29  9:49   ` Hsin-Hsiung Wang
2021-01-29  9:49 ` [PATCH RESEND v5 7/8] regulator: mt6359: Add support for MT6359P regulator Hsin-Hsiung Wang
2021-01-29  9:49   ` Hsin-Hsiung Wang
2021-03-01 10:21   ` Lee Jones [this message]
2021-03-01 10:21     ` Lee Jones
2021-03-01 10:21     ` Lee Jones
2021-03-12 16:20     ` Hsin-hsiung Wang
2021-03-12 16:20       ` Hsin-hsiung Wang
2021-03-12 16:20       ` Hsin-hsiung Wang
2021-01-29  9:49 ` [PATCH RESEND v5 8/8] arm64: dts: mt6359: add PMIC MT6359 related nodes Hsin-Hsiung Wang
2021-01-29  9:49   ` Hsin-Hsiung Wang
2021-01-29  9:49   ` Hsin-Hsiung Wang
2021-01-31 11:06   ` Matthias Brugger
2021-02-02  3:51     ` Tzung-Bi Shih
2021-02-02  3:51       ` Tzung-Bi Shih
2021-02-02  3:51       ` Tzung-Bi Shih
2021-02-07 18:48       ` Matthias Brugger
2021-02-07 18:48         ` Matthias Brugger
2021-02-07 18:48         ` Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210301102156.GJ641347@dell \
    --to=lee.jones@linaro.org \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=eddie.huang@mediatek.com \
    --cc=fshao@chromium.org \
    --cc=hsin-hsiung.wang@mediatek.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=ran.bi@mediatek.com \
    --cc=robh+dt@kernel.org \
    --cc=sean.wang@mediatek.com \
    --cc=srv_heupstream@mediatek.com \
    --cc=yuchen.huang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.