From: Tong Zhang <ztong0001@gmail.com>
To: Ian Abbott <abbotti@mev.co.uk>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Alexander A. Klimov" <grandmaster@al2klimov.de>,
Tong Zhang <ztong0001@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH] staging: comedi: replace slash in name
Date: Sat, 13 Mar 2021 22:57:57 -0500 [thread overview]
Message-ID: <20210314035757.2740146-1-ztong0001@gmail.com> (raw)
request_irq() wont accept a name which contains slash so we need to
repalce it with something else -- otherwise it will trigger a warning
and the entry in /proc/irq/ will not be created
[ 1.565966] name 'pci-das6402/16'
[ 1.566149] WARNING: CPU: 0 PID: 184 at fs/proc/generic.c:180 __xlate_proc_name+0x93/0xb0
[ 1.568923] RIP: 0010:__xlate_proc_name+0x93/0xb0
[ 1.574200] Call Trace:
[ 1.574722] proc_mkdir+0x18/0x20
[ 1.576629] request_threaded_irq+0xfe/0x160
[ 1.576859] auto_attach+0x60a/0xc40 [cb_pcidas64]
Signed-off-by: Tong Zhang <ztong0001@gmail.com>
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
index fa987bb0e7cd..662d6ffb8f60 100644
--- a/drivers/staging/comedi/drivers/cb_pcidas64.c
+++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
@@ -677,7 +677,7 @@ static const int bytes_in_sample = 2;
static const struct pcidas64_board pcidas64_boards[] = {
[BOARD_PCIDAS6402_16] = {
- .name = "pci-das6402/16",
+ .name = "pci-das6402-16",
.ai_se_chans = 64,
.ai_bits = 16,
.ai_speed = 5000,
@@ -693,7 +693,7 @@ static const struct pcidas64_board pcidas64_boards[] = {
.has_8255 = 1,
},
[BOARD_PCIDAS6402_12] = {
- .name = "pci-das6402/12", /* XXX check */
+ .name = "pci-das6402-12", /* XXX check */
.ai_se_chans = 64,
.ai_bits = 12,
.ai_speed = 5000,
@@ -709,7 +709,7 @@ static const struct pcidas64_board pcidas64_boards[] = {
.has_8255 = 1,
},
[BOARD_PCIDAS64_M1_16] = {
- .name = "pci-das64/m1/16",
+ .name = "pci-das64-m1-16",
.ai_se_chans = 64,
.ai_bits = 16,
.ai_speed = 1000,
@@ -725,7 +725,7 @@ static const struct pcidas64_board pcidas64_boards[] = {
.has_8255 = 1,
},
[BOARD_PCIDAS64_M2_16] = {
- .name = "pci-das64/m2/16",
+ .name = "pci-das64-m2-16",
.ai_se_chans = 64,
.ai_bits = 16,
.ai_speed = 500,
@@ -741,7 +741,7 @@ static const struct pcidas64_board pcidas64_boards[] = {
.has_8255 = 1,
},
[BOARD_PCIDAS64_M3_16] = {
- .name = "pci-das64/m3/16",
+ .name = "pci-das64-m3-16",
.ai_se_chans = 64,
.ai_bits = 16,
.ai_speed = 333,
@@ -984,7 +984,7 @@ static const struct pcidas64_board pcidas64_boards[] = {
.has_8255 = 0,
},
[BOARD_PCIDAS4020_12] = {
- .name = "pci-das4020/12",
+ .name = "pci-das4020-12",
.ai_se_chans = 4,
.ai_bits = 12,
.ai_speed = 50,
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Tong Zhang <ztong0001@gmail.com>
To: Ian Abbott <abbotti@mev.co.uk>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Alexander A. Klimov" <grandmaster@al2klimov.de>,
Tong Zhang <ztong0001@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH] staging: comedi: replace slash in name
Date: Sat, 13 Mar 2021 22:57:57 -0500 [thread overview]
Message-ID: <20210314035757.2740146-1-ztong0001@gmail.com> (raw)
request_irq() wont accept a name which contains slash so we need to
repalce it with something else -- otherwise it will trigger a warning
and the entry in /proc/irq/ will not be created
[ 1.565966] name 'pci-das6402/16'
[ 1.566149] WARNING: CPU: 0 PID: 184 at fs/proc/generic.c:180 __xlate_proc_name+0x93/0xb0
[ 1.568923] RIP: 0010:__xlate_proc_name+0x93/0xb0
[ 1.574200] Call Trace:
[ 1.574722] proc_mkdir+0x18/0x20
[ 1.576629] request_threaded_irq+0xfe/0x160
[ 1.576859] auto_attach+0x60a/0xc40 [cb_pcidas64]
Signed-off-by: Tong Zhang <ztong0001@gmail.com>
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
index fa987bb0e7cd..662d6ffb8f60 100644
--- a/drivers/staging/comedi/drivers/cb_pcidas64.c
+++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
@@ -677,7 +677,7 @@ static const int bytes_in_sample = 2;
static const struct pcidas64_board pcidas64_boards[] = {
[BOARD_PCIDAS6402_16] = {
- .name = "pci-das6402/16",
+ .name = "pci-das6402-16",
.ai_se_chans = 64,
.ai_bits = 16,
.ai_speed = 5000,
@@ -693,7 +693,7 @@ static const struct pcidas64_board pcidas64_boards[] = {
.has_8255 = 1,
},
[BOARD_PCIDAS6402_12] = {
- .name = "pci-das6402/12", /* XXX check */
+ .name = "pci-das6402-12", /* XXX check */
.ai_se_chans = 64,
.ai_bits = 12,
.ai_speed = 5000,
@@ -709,7 +709,7 @@ static const struct pcidas64_board pcidas64_boards[] = {
.has_8255 = 1,
},
[BOARD_PCIDAS64_M1_16] = {
- .name = "pci-das64/m1/16",
+ .name = "pci-das64-m1-16",
.ai_se_chans = 64,
.ai_bits = 16,
.ai_speed = 1000,
@@ -725,7 +725,7 @@ static const struct pcidas64_board pcidas64_boards[] = {
.has_8255 = 1,
},
[BOARD_PCIDAS64_M2_16] = {
- .name = "pci-das64/m2/16",
+ .name = "pci-das64-m2-16",
.ai_se_chans = 64,
.ai_bits = 16,
.ai_speed = 500,
@@ -741,7 +741,7 @@ static const struct pcidas64_board pcidas64_boards[] = {
.has_8255 = 1,
},
[BOARD_PCIDAS64_M3_16] = {
- .name = "pci-das64/m3/16",
+ .name = "pci-das64-m3-16",
.ai_se_chans = 64,
.ai_bits = 16,
.ai_speed = 333,
@@ -984,7 +984,7 @@ static const struct pcidas64_board pcidas64_boards[] = {
.has_8255 = 0,
},
[BOARD_PCIDAS4020_12] = {
- .name = "pci-das4020/12",
+ .name = "pci-das4020-12",
.ai_se_chans = 4,
.ai_bits = 12,
.ai_speed = 50,
--
2.25.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next reply other threads:[~2021-03-14 3:58 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-14 3:57 Tong Zhang [this message]
2021-03-14 3:57 ` [PATCH] staging: comedi: replace slash in name Tong Zhang
2021-03-15 10:44 ` Ian Abbott
2021-03-15 10:44 ` Ian Abbott
2021-03-15 10:48 ` Ian Abbott
2021-03-15 10:48 ` Ian Abbott
2021-03-15 19:58 ` [PATCH v2] staging: comedi: cb_pcidas64: fix request_irq() warn Tong Zhang
2021-03-15 19:58 ` Tong Zhang
2021-03-16 10:31 ` Ian Abbott
2021-03-16 10:31 ` Ian Abbott
2021-03-15 20:00 ` [PATCH] staging: comedi: replace slash in name Tong Zhang
2021-03-15 20:00 ` Tong Zhang
2021-03-16 10:37 ` Ian Abbott
2021-03-16 10:37 ` Ian Abbott
2021-03-16 22:42 ` [PATCH] staging: comedi: das800: fix request_irq() warn Tong Zhang
2021-03-16 22:42 ` Tong Zhang
2021-03-17 5:14 ` Dan Carpenter
2021-03-17 5:14 ` Dan Carpenter
[not found] ` <CAA5qM4BcQ6+aa1C3_28zLVojwLduK-WZwsEftuasJgo8z0t0ew@mail.gmail.com>
2021-03-17 6:52 ` Dan Carpenter
2021-03-17 6:52 ` Dan Carpenter
2021-03-17 22:43 ` Tong Zhang
2021-03-17 22:43 ` Tong Zhang
2021-03-17 12:48 ` Ian Abbott
2021-03-17 12:48 ` Ian Abbott
2021-03-19 3:47 ` [PATCH v2] " Tong Zhang
2021-03-19 3:47 ` Tong Zhang
2021-03-19 3:48 ` [PATCH] " Tong Zhang
2021-03-19 3:48 ` Tong Zhang
2021-03-16 22:42 ` [PATCH] staging: comedi: replace slash in name Tong Zhang
2021-03-16 22:42 ` Tong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210314035757.2740146-1-ztong0001@gmail.com \
--to=ztong0001@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=grandmaster@al2klimov.de \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.