From: Marco Felsch <m.felsch@pengutronix.de>
To: Alistair Francis <alistair@alistair23.me>
Cc: arnd@arndb.de, olof@lixom.net, robh+dt@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, alistair23@gmail.com
Subject: Re: [PATCH v5 3/3] ARM: imx7d-remarkable2.dts: Initial device tree for reMarkable2
Date: Fri, 19 Mar 2021 14:06:15 +0100 [thread overview]
Message-ID: <20210319130615.k2y6u7otnzbs3hpx@pengutronix.de> (raw)
In-Reply-To: <20210316022740.132-3-alistair@alistair23.me>
Hi Alistair,
the patch looks quite good only a few notes inline.
PS: It would be cool to have a log to previous patch versions.
On 21-03-15 22:27, Alistair Francis wrote:
...
> +&crypto {
> + status = "disabled";
> +};
Why do you disable the crypto subsystem?
> +&dma_apbh {
> + status = "disabled";
> +};
Why do you disable this dma controller?
> +
> +&sdma {
> + status = "okay";
> +};
This is the default state so you can drop this node.
Regards,
Marco
WARNING: multiple messages have this Message-ID (diff)
From: Marco Felsch <m.felsch@pengutronix.de>
To: Alistair Francis <alistair@alistair23.me>
Cc: arnd@arndb.de, olof@lixom.net, robh+dt@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, alistair23@gmail.com
Subject: Re: [PATCH v5 3/3] ARM: imx7d-remarkable2.dts: Initial device tree for reMarkable2
Date: Fri, 19 Mar 2021 14:06:15 +0100 [thread overview]
Message-ID: <20210319130615.k2y6u7otnzbs3hpx@pengutronix.de> (raw)
In-Reply-To: <20210316022740.132-3-alistair@alistair23.me>
Hi Alistair,
the patch looks quite good only a few notes inline.
PS: It would be cool to have a log to previous patch versions.
On 21-03-15 22:27, Alistair Francis wrote:
...
> +&crypto {
> + status = "disabled";
> +};
Why do you disable the crypto subsystem?
> +&dma_apbh {
> + status = "disabled";
> +};
Why do you disable this dma controller?
> +
> +&sdma {
> + status = "okay";
> +};
This is the default state so you can drop this node.
Regards,
Marco
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-19 13:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 2:27 [PATCH v5 1/3] dt-bindings: Add vendor prefix for reMarkable Alistair Francis
2021-03-16 2:27 ` Alistair Francis
2021-03-16 2:27 ` [PATCH v5 2/3] dt-bindings: arm: fsl: Add the reMarkable 2 e-Ink tablet Alistair Francis
2021-03-16 2:27 ` Alistair Francis
2021-03-16 2:27 ` [PATCH v5 3/3] ARM: imx7d-remarkable2.dts: Initial device tree for reMarkable2 Alistair Francis
2021-03-16 2:27 ` Alistair Francis
2021-03-19 13:06 ` Marco Felsch [this message]
2021-03-19 13:06 ` Marco Felsch
2021-03-21 1:40 ` Alistair Francis
2021-03-21 1:40 ` Alistair Francis
2021-03-21 13:15 ` Fabio Estevam
2021-03-21 13:15 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210319130615.k2y6u7otnzbs3hpx@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.