From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>, Jens Axboe <axboe@kernel.dk>,
Chao Leng <lengchao@huawei.com>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH 1/2] blk-mq: add a blk_mq_submit_bio_direct API
Date: Tue, 23 Mar 2021 00:30:13 +0900 [thread overview]
Message-ID: <20210322153013.GA17311@redsun51.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <20210322073726.788347-2-hch@lst.de>
Looks good. Just a couple minor typo's in the commit message.
Reviewed-by: Keith Busch <kbusch@kernel.org>
On Mon, Mar 22, 2021 at 08:37:25AM +0100, Christoph Hellwig wrote:
> This adds (back) and API for simple stacking drivers to submit a bio to
an API
> blk-mq queue. The prime aim is to avoid blocking on the queue freeze
> percpu ref, as a multipath driver really does not want to get blocked
> on that when an underlying device is undergoing error recovery. It also
> happens to optimize away the small overhead of the curren->bio_list based
current->bio_list
WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>, Jens Axboe <axboe@kernel.dk>,
Chao Leng <lengchao@huawei.com>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH 1/2] blk-mq: add a blk_mq_submit_bio_direct API
Date: Tue, 23 Mar 2021 00:30:13 +0900 [thread overview]
Message-ID: <20210322153013.GA17311@redsun51.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <20210322073726.788347-2-hch@lst.de>
Looks good. Just a couple minor typo's in the commit message.
Reviewed-by: Keith Busch <kbusch@kernel.org>
On Mon, Mar 22, 2021 at 08:37:25AM +0100, Christoph Hellwig wrote:
> This adds (back) and API for simple stacking drivers to submit a bio to
an API
> blk-mq queue. The prime aim is to avoid blocking on the queue freeze
> percpu ref, as a multipath driver really does not want to get blocked
> on that when an underlying device is undergoing error recovery. It also
> happens to optimize away the small overhead of the curren->bio_list based
current->bio_list
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-03-22 15:31 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 7:37 fix nvme-tcp and nvme-rdma controller reset hangs when using multipath Christoph Hellwig
2021-03-22 7:37 ` Christoph Hellwig
2021-03-22 7:37 ` [PATCH 1/2] blk-mq: add a blk_mq_submit_bio_direct API Christoph Hellwig
2021-03-22 7:37 ` Christoph Hellwig
2021-03-22 11:23 ` Hannes Reinecke
2021-03-22 11:23 ` Hannes Reinecke
2021-03-22 15:30 ` Keith Busch [this message]
2021-03-22 15:30 ` Keith Busch
2021-03-22 7:37 ` [PATCH 2/2] nvme-multipath: don't block on blk_queue_enter of the underlying device Christoph Hellwig
2021-03-22 7:37 ` Christoph Hellwig
2021-03-22 11:22 ` Hannes Reinecke
2021-03-22 11:22 ` Hannes Reinecke
2021-03-22 15:31 ` Keith Busch
2021-03-22 15:31 ` Keith Busch
2021-03-23 2:57 ` Sagi Grimberg
2021-03-23 2:57 ` Sagi Grimberg
2021-03-23 3:23 ` Sagi Grimberg
2021-03-23 3:23 ` Sagi Grimberg
2021-03-23 7:04 ` Chao Leng
2021-03-23 7:04 ` Chao Leng
2021-03-23 7:36 ` Sagi Grimberg
2021-03-23 7:36 ` Sagi Grimberg
2021-03-23 8:13 ` Chao Leng
2021-03-23 8:13 ` Chao Leng
2021-03-23 16:17 ` Christoph Hellwig
2021-03-23 16:17 ` Christoph Hellwig
2021-03-23 16:15 ` Christoph Hellwig
2021-03-23 16:15 ` Christoph Hellwig
2021-03-23 18:13 ` Sagi Grimberg
2021-03-23 18:13 ` Sagi Grimberg
2021-03-23 18:22 ` Christoph Hellwig
2021-03-23 18:22 ` Christoph Hellwig
2021-03-23 19:00 ` Sagi Grimberg
2021-03-23 19:00 ` Sagi Grimberg
2021-03-23 19:01 ` Christoph Hellwig
2021-03-23 19:01 ` Christoph Hellwig
2021-03-23 19:10 ` Sagi Grimberg
2021-03-23 19:10 ` Sagi Grimberg
2021-03-23 7:28 ` Hannes Reinecke
2021-03-23 7:28 ` Hannes Reinecke
2021-03-23 7:31 ` Sagi Grimberg
2021-03-23 7:31 ` Sagi Grimberg
2021-03-23 8:36 ` Hannes Reinecke
2021-03-23 8:36 ` Hannes Reinecke
2021-03-23 14:53 ` Keith Busch
2021-03-23 14:53 ` Keith Busch
2021-03-23 16:19 ` Christoph Hellwig
2021-03-23 16:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210322153013.GA17311@redsun51.ssa.fujisawa.hgst.com \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=lengchao@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.