From: Christian Brauner <christian.brauner@ubuntu.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Kees Cook <keescook@chromium.org>,
Andy Lutomirski <luto@amacapital.net>,
Will Drewry <wad@chromium.org>
Subject: Re: split receive_fd_replace from __receive_fd
Date: Thu, 25 Mar 2021 09:30:16 +0100 [thread overview]
Message-ID: <20210325083016.nwn2dbtuyearrxfd@wittgenstein> (raw)
In-Reply-To: <20210325082209.1067987-1-hch@lst.de>
On Thu, Mar 25, 2021 at 09:22:08AM +0100, Christoph Hellwig wrote:
> The receive_fd_replace case shares almost no logic with the more general
> __receive_fd case, so split it into a separate function.
>
> BTW, I'm not sure if receive_fd_replace is such a useful primitive to
> start with, why not just open code it in seccomp?
I tend to agree and argued in a similar fashion back when we added this
but we ultimately decided to add it. So now we're back to the original
argument. :)
Christian
prev parent reply other threads:[~2021-03-25 8:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 8:22 split receive_fd_replace from __receive_fd Christoph Hellwig
2021-03-25 8:22 ` [PATCH] fs: " Christoph Hellwig
2021-03-29 7:19 ` [fs] d7b0df2133: kernel-selftests.seccomp.seccomp_bpf.fail kernel test robot
2021-03-29 7:19 ` kernel test robot
2021-04-02 19:01 ` [PATCH] fs: split receive_fd_replace from __receive_fd Kees Cook
2021-04-16 4:15 ` Al Viro
2021-04-16 13:46 ` Christian Brauner
2021-04-16 3:38 ` Al Viro
2021-03-25 8:30 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210325083016.nwn2dbtuyearrxfd@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=hch@lst.de \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=viro@zeniv.linux.org.uk \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.