From: Kees Cook <keescook@chromium.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Lutomirski <luto@amacapital.net>,
Will Drewry <wad@chromium.org>
Subject: Re: [PATCH] fs: split receive_fd_replace from __receive_fd
Date: Fri, 2 Apr 2021 12:01:05 -0700 [thread overview]
Message-ID: <202104021157.7B388D1B2@keescook> (raw)
In-Reply-To: <20210325082209.1067987-2-hch@lst.de>
On Thu, Mar 25, 2021 at 09:22:09AM +0100, Christoph Hellwig wrote:
> receive_fd_replace shares almost no code with the general case, so split
> it out. Also remove the "Bump the sock usage counts" comment from
> both copies, as that is now what __receive_sock actually does.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
I'm okay with repeating code in fs/file.c. What I wanted to avoid was
open coded combinations in various callers.
So, sure, this can be split, but as-is the patch breaks SECCOMP_IOCTL_NOTIF_ADDFD:
https://lore.kernel.org/linux-fsdevel/20210329071939.GC3633@xsang-OptiPlex-9020/
-Kees
--
Kees Cook
next prev parent reply other threads:[~2021-04-02 19:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 8:22 split receive_fd_replace from __receive_fd Christoph Hellwig
2021-03-25 8:22 ` [PATCH] fs: " Christoph Hellwig
2021-03-29 7:19 ` [fs] d7b0df2133: kernel-selftests.seccomp.seccomp_bpf.fail kernel test robot
2021-03-29 7:19 ` kernel test robot
2021-04-02 19:01 ` Kees Cook [this message]
2021-04-16 4:15 ` [PATCH] fs: split receive_fd_replace from __receive_fd Al Viro
2021-04-16 13:46 ` Christian Brauner
2021-04-16 3:38 ` Al Viro
2021-03-25 8:30 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202104021157.7B388D1B2@keescook \
--to=keescook@chromium.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=viro@zeniv.linux.org.uk \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.