From: Mark Brown <broonie@kernel.org>
To: Ryan Lee <ryans.lee@maximintegrated.com>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
pierre-louis.bossart@linux.intel.com,
kai.vehmanen@linux.intel.com, yung-chuan.liao@linux.intel.com,
rander.wang@linux.intel.com,
guennadi.liakhovetski@linux.intel.com, vkoul@kernel.org,
yong.zhi@intel.com, judyhsiao@google.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
ryan.lee.maxim@gmail.com
Subject: Re: [PATCH 1/3] ASoC:codec:max98373: Changed amp shutdown register as volatile
Date: Thu, 25 Mar 2021 13:56:13 +0000 [thread overview]
Message-ID: <20210325135613.GA7767@sirena.org.uk> (raw)
In-Reply-To: <20210325033555.29377-1-ryans.lee@maximintegrated.com>
[-- Attachment #1: Type: text/plain, Size: 535 bytes --]
On Wed, Mar 24, 2021 at 08:35:53PM -0700, Ryan Lee wrote:
> 0x20FF(amp global enable) register was defined as non-volatile,
> but it is not. Overheating, overcurrent can cause amp shutdown
> in hardware.
Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Ryan Lee <ryans.lee@maximintegrated.com>
Cc: alsa-devel@alsa-project.org,
guennadi.liakhovetski@linux.intel.com, judyhsiao@google.com,
ryan.lee.maxim@gmail.com, kai.vehmanen@linux.intel.com,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
pierre-louis.bossart@linux.intel.com, tiwai@suse.com,
vkoul@kernel.org, yung-chuan.liao@linux.intel.com,
rander.wang@linux.intel.com, yong.zhi@intel.com
Subject: Re: [PATCH 1/3] ASoC:codec:max98373: Changed amp shutdown register as volatile
Date: Thu, 25 Mar 2021 13:56:13 +0000 [thread overview]
Message-ID: <20210325135613.GA7767@sirena.org.uk> (raw)
In-Reply-To: <20210325033555.29377-1-ryans.lee@maximintegrated.com>
[-- Attachment #1: Type: text/plain, Size: 535 bytes --]
On Wed, Mar 24, 2021 at 08:35:53PM -0700, Ryan Lee wrote:
> 0x20FF(amp global enable) register was defined as non-volatile,
> but it is not. Overheating, overcurrent can cause amp shutdown
> in hardware.
Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-03-25 13:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 3:35 [PATCH 1/3] ASoC:codec:max98373: Changed amp shutdown register as volatile Ryan Lee
2021-03-25 3:35 ` [PATCH 2/3] ASoC:codec:max98373: Added 30ms turn on/off time delay Ryan Lee
2021-03-25 3:35 ` [PATCH 3/3] ASoC:codec:max98373: Added controls for autorestart config Ryan Lee
2021-03-25 13:56 ` Mark Brown [this message]
2021-03-25 13:56 ` [PATCH 1/3] ASoC:codec:max98373: Changed amp shutdown register as volatile Mark Brown
2021-03-25 17:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210325135613.GA7767@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=judyhsiao@google.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@linux.intel.com \
--cc=ryan.lee.maxim@gmail.com \
--cc=ryans.lee@maximintegrated.com \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
--cc=yong.zhi@intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.