From: Jonathan Cameron <jic23@kernel.org> To: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: Mugilraj Dhavachelvan <dmugil2000@gmail.com>, Hartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>, Peter Meerwald-Stadler <pmeerw@pmeerw.net>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Alexandre Torgue <alexandre.torgue@st.com>, linux-iio <linux-iio@vger.kernel.org>, linux-stm32@st-md-mailman.stormreply.com, linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] iio: adc: stm32-dfsdm: drop __func__ while using Dynamic debug Date: Fri, 2 Apr 2021 10:53:35 +0100 [thread overview] Message-ID: <20210402105335.1bfbaf2e@jic23-huawei> (raw) In-Reply-To: <CAHp75VfkCQpfUrVcWHUnD4DLMp9iZJBL8mYfsYOCsESm_y068A@mail.gmail.com> On Thu, 1 Apr 2021 21:05:58 +0300 Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Thu, Apr 1, 2021 at 8:48 PM Mugilraj Dhavachelvan > <dmugil2000@gmail.com> wrote: > > > > dropped __func__ while using dev_dbg() and pr_debug() > > The commit message may be amended, from code perspective LGTM! > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> I added a note to the commit message to observe that the function name printing can be configured using dynamic debug. Applied to the togreg branch of iio.git and pushed out as testing to let the autobuilder bots like 0-day check if they can find any problems that we've missed. Thanks, Jonathan > > > Signed-off-by: Mugilraj Dhavachelvan <dmugil2000@gmail.com> > > --- > > drivers/iio/adc/stm32-dfsdm-adc.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c > > index 76a60d93fe23..95ec5f3c3126 100644 > > --- a/drivers/iio/adc/stm32-dfsdm-adc.c > > +++ b/drivers/iio/adc/stm32-dfsdm-adc.c > > @@ -198,7 +198,7 @@ static int stm32_dfsdm_compute_osrs(struct stm32_dfsdm_filter *fl, > > unsigned int p = fl->ford; /* filter order (ford) */ > > struct stm32_dfsdm_filter_osr *flo = &fl->flo[fast]; > > > > - pr_debug("%s: Requested oversampling: %d\n", __func__, oversamp); > > + pr_debug("Requested oversampling: %d\n", oversamp); > > /* > > * This function tries to compute filter oversampling and integrator > > * oversampling, base on oversampling ratio requested by user. > > @@ -294,8 +294,8 @@ static int stm32_dfsdm_compute_osrs(struct stm32_dfsdm_filter *fl, > > } > > flo->max = (s32)max; > > > > - pr_debug("%s: fast %d, fosr %d, iosr %d, res 0x%llx/%d bits, rshift %d, lshift %d\n", > > - __func__, fast, flo->fosr, flo->iosr, > > + pr_debug("fast %d, fosr %d, iosr %d, res 0x%llx/%d bits, rshift %d, lshift %d\n", > > + fast, flo->fosr, flo->iosr, > > flo->res, bits, flo->rshift, > > flo->lshift); > > } > > @@ -858,7 +858,7 @@ static void stm32_dfsdm_dma_buffer_done(void *data) > > * support in IIO. > > */ > > > > - dev_dbg(&indio_dev->dev, "%s: pos = %d, available = %d\n", __func__, > > + dev_dbg(&indio_dev->dev, "pos = %d, available = %d\n", > > adc->bufi, available); > > old_pos = adc->bufi; > > > > @@ -912,7 +912,7 @@ static int stm32_dfsdm_adc_dma_start(struct iio_dev *indio_dev) > > if (!adc->dma_chan) > > return -EINVAL; > > > > - dev_dbg(&indio_dev->dev, "%s size=%d watermark=%d\n", __func__, > > + dev_dbg(&indio_dev->dev, "size=%d watermark=%d\n", > > adc->buf_sz, adc->buf_sz / 2); > > > > if (adc->nconv == 1 && !indio_dev->trig) > > -- > > 2.25.1 > > > >
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org> To: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: Mugilraj Dhavachelvan <dmugil2000@gmail.com>, Hartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>, Peter Meerwald-Stadler <pmeerw@pmeerw.net>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Alexandre Torgue <alexandre.torgue@st.com>, linux-iio <linux-iio@vger.kernel.org>, linux-stm32@st-md-mailman.stormreply.com, linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] iio: adc: stm32-dfsdm: drop __func__ while using Dynamic debug Date: Fri, 2 Apr 2021 10:53:35 +0100 [thread overview] Message-ID: <20210402105335.1bfbaf2e@jic23-huawei> (raw) In-Reply-To: <CAHp75VfkCQpfUrVcWHUnD4DLMp9iZJBL8mYfsYOCsESm_y068A@mail.gmail.com> On Thu, 1 Apr 2021 21:05:58 +0300 Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Thu, Apr 1, 2021 at 8:48 PM Mugilraj Dhavachelvan > <dmugil2000@gmail.com> wrote: > > > > dropped __func__ while using dev_dbg() and pr_debug() > > The commit message may be amended, from code perspective LGTM! > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> I added a note to the commit message to observe that the function name printing can be configured using dynamic debug. Applied to the togreg branch of iio.git and pushed out as testing to let the autobuilder bots like 0-day check if they can find any problems that we've missed. Thanks, Jonathan > > > Signed-off-by: Mugilraj Dhavachelvan <dmugil2000@gmail.com> > > --- > > drivers/iio/adc/stm32-dfsdm-adc.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c > > index 76a60d93fe23..95ec5f3c3126 100644 > > --- a/drivers/iio/adc/stm32-dfsdm-adc.c > > +++ b/drivers/iio/adc/stm32-dfsdm-adc.c > > @@ -198,7 +198,7 @@ static int stm32_dfsdm_compute_osrs(struct stm32_dfsdm_filter *fl, > > unsigned int p = fl->ford; /* filter order (ford) */ > > struct stm32_dfsdm_filter_osr *flo = &fl->flo[fast]; > > > > - pr_debug("%s: Requested oversampling: %d\n", __func__, oversamp); > > + pr_debug("Requested oversampling: %d\n", oversamp); > > /* > > * This function tries to compute filter oversampling and integrator > > * oversampling, base on oversampling ratio requested by user. > > @@ -294,8 +294,8 @@ static int stm32_dfsdm_compute_osrs(struct stm32_dfsdm_filter *fl, > > } > > flo->max = (s32)max; > > > > - pr_debug("%s: fast %d, fosr %d, iosr %d, res 0x%llx/%d bits, rshift %d, lshift %d\n", > > - __func__, fast, flo->fosr, flo->iosr, > > + pr_debug("fast %d, fosr %d, iosr %d, res 0x%llx/%d bits, rshift %d, lshift %d\n", > > + fast, flo->fosr, flo->iosr, > > flo->res, bits, flo->rshift, > > flo->lshift); > > } > > @@ -858,7 +858,7 @@ static void stm32_dfsdm_dma_buffer_done(void *data) > > * support in IIO. > > */ > > > > - dev_dbg(&indio_dev->dev, "%s: pos = %d, available = %d\n", __func__, > > + dev_dbg(&indio_dev->dev, "pos = %d, available = %d\n", > > adc->bufi, available); > > old_pos = adc->bufi; > > > > @@ -912,7 +912,7 @@ static int stm32_dfsdm_adc_dma_start(struct iio_dev *indio_dev) > > if (!adc->dma_chan) > > return -EINVAL; > > > > - dev_dbg(&indio_dev->dev, "%s size=%d watermark=%d\n", __func__, > > + dev_dbg(&indio_dev->dev, "size=%d watermark=%d\n", > > adc->buf_sz, adc->buf_sz / 2); > > > > if (adc->nconv == 1 && !indio_dev->trig) > > -- > > 2.25.1 > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-02 9:53 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-01 15:43 [PATCH] iio: adc: stm32-dfsdm: drop __func__ while using Dynamic debug Mugilraj Dhavachelvan 2021-04-01 15:43 ` Mugilraj Dhavachelvan 2021-04-01 18:05 ` Andy Shevchenko 2021-04-01 18:05 ` Andy Shevchenko 2021-04-02 9:53 ` Jonathan Cameron [this message] 2021-04-02 9:53 ` Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210402105335.1bfbaf2e@jic23-huawei \ --to=jic23@kernel.org \ --cc=alexandre.torgue@st.com \ --cc=andy.shevchenko@gmail.com \ --cc=dmugil2000@gmail.com \ --cc=knaack.h@gmx.de \ --cc=lars@metafoo.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=pmeerw@pmeerw.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.