From: kernel test robot <lkp@intel.com>
To: Rex-BC Chen <rex-bc.chen@mediatek.com>,
thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de,
lee.jones@linaro.org, matthias.bgg@gmail.com
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
Rex-BC Chen <rex-bc.chen@mediatek.com>
Subject: Re: [v3,PATCH 2/3] pwm: mtk_disp: convert the driver to atomic API
Date: Tue, 6 Apr 2021 22:37:08 +0800 [thread overview]
Message-ID: <202104062217.1uJvXdY2-lkp@intel.com> (raw)
In-Reply-To: <1617703062-4251-3-git-send-email-rex-bc.chen@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 11583 bytes --]
Hi Rex-BC,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on v5.12-rc6]
[also build test WARNING on next-20210406]
[cannot apply to pwm/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Rex-BC-Chen/Convert-the-mtk_disp-driver-to-aotmic-API/20210406-180018
base: e49d033bddf5b565044e2abe4241353959bc9120
config: powerpc64-randconfig-r023-20210406 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project a46f59a747a7273cc439efaf3b4f98d8b63d2f20)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc64 cross compiling tool for clang build
# apt-get install binutils-powerpc64-linux-gnu
# https://github.com/0day-ci/linux/commit/0a2486ac437e3b8d36a0bf8ce9648c22e42ffda4
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Rex-BC-Chen/Convert-the-mtk_disp-driver-to-aotmic-API/20210406-180018
git checkout 0a2486ac437e3b8d36a0bf8ce9648c22e42ffda4
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:155:1: note: expanded from here
__do_outl
^
arch/powerpc/include/asm/io.h:537:62: note: expanded from macro '__do_outl'
#define __do_outl(val, port) writel(val,(PCI_IO_ADDR)_IO_BASE+port);
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/pwm/pwm-mtk-disp.c:10:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:43:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(insb, (unsigned long p, void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:169:1: note: expanded from here
__do_insb
^
arch/powerpc/include/asm/io.h:556:56: note: expanded from macro '__do_insb'
#define __do_insb(p, b, n) readsb((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/pwm/pwm-mtk-disp.c:10:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:45:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(insw, (unsigned long p, void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:171:1: note: expanded from here
__do_insw
^
arch/powerpc/include/asm/io.h:557:56: note: expanded from macro '__do_insw'
#define __do_insw(p, b, n) readsw((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/pwm/pwm-mtk-disp.c:10:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:47:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(insl, (unsigned long p, void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:173:1: note: expanded from here
__do_insl
^
arch/powerpc/include/asm/io.h:558:56: note: expanded from macro '__do_insl'
#define __do_insl(p, b, n) readsl((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/pwm/pwm-mtk-disp.c:10:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:49:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(outsb, (unsigned long p, const void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:175:1: note: expanded from here
__do_outsb
^
arch/powerpc/include/asm/io.h:559:58: note: expanded from macro '__do_outsb'
#define __do_outsb(p, b, n) writesb((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/pwm/pwm-mtk-disp.c:10:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:51:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(outsw, (unsigned long p, const void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:177:1: note: expanded from here
__do_outsw
^
arch/powerpc/include/asm/io.h:560:58: note: expanded from macro '__do_outsw'
#define __do_outsw(p, b, n) writesw((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/pwm/pwm-mtk-disp.c:10:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:53:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(outsl, (unsigned long p, const void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:179:1: note: expanded from here
__do_outsl
^
arch/powerpc/include/asm/io.h:561:58: note: expanded from macro '__do_outsl'
#define __do_outsl(p, b, n) writesl((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
~~~~~~~~~~~~~~~~~~~~~^
>> drivers/pwm/pwm-mtk-disp.c:109:4: warning: format specifies type 'int' but the argument has type 'u64' (aka 'unsigned long long') [-Wformat]
rate);
^~~~
include/linux/dev_printk.h:112:32: note: expanded from macro 'dev_err'
_dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
13 warnings generated.
vim +109 drivers/pwm/pwm-mtk-disp.c
70
71 static int mtk_disp_pwm_enable(struct pwm_chip *chip,
72 const struct pwm_state *state)
73 {
74 struct mtk_disp_pwm *mdp = to_mtk_disp_pwm(chip);
75 u32 clk_div, period, high_width, value, polarity;
76 u64 div, rate;
77 int err;
78
79 /*
80 * Find period, high_width and clk_div to suit duty_ns and period_ns.
81 * Calculate proper div value to keep period value in the bound.
82 *
83 * period_ns = 10^9 * (clk_div + 1) * (period + 1) / PWM_CLK_RATE
84 * duty_ns = 10^9 * (clk_div + 1) * high_width / PWM_CLK_RATE
85 *
86 * period = (PWM_CLK_RATE * period_ns) / (10^9 * (clk_div + 1)) - 1
87 * high_width = (PWM_CLK_RATE * duty_ns) / (10^9 * (clk_div + 1))
88 */
89 if (!mdp->enabled) {
90 err = clk_prepare_enable(mdp->clk_main);
91 if (err < 0) {
92 dev_err(chip->dev, "Can't enable mdp->clk_main: %d\n",
93 err);
94 return err;
95 }
96 err = clk_prepare_enable(mdp->clk_mm);
97 if (err < 0) {
98 dev_err(chip->dev, "Can't enable mdp->clk_mm: %d\n",
99 err);
100 clk_disable_unprepare(mdp->clk_main);
101 return err;
102 }
103 }
104 rate = clk_get_rate(mdp->clk_main);
105 clk_div = div_u64(rate * state->period, NSEC_PER_SEC) >>
106 PWM_PERIOD_BIT_WIDTH;
107 if (clk_div > PWM_CLKDIV_MAX) {
108 dev_err(chip->dev, "clock rate is too high: rate = %d Hz\n",
> 109 rate);
110 clk_disable_unprepare(mdp->clk_mm);
111 clk_disable_unprepare(mdp->clk_main);
112 return -EINVAL;
113 }
114 div = NSEC_PER_SEC * (clk_div + 1);
115 period = div64_u64(rate * state->period, div);
116 if (period > 0)
117 period--;
118
119 high_width = div64_u64(rate * state->duty_cycle, div);
120 value = period | (high_width << PWM_HIGH_WIDTH_SHIFT);
121 polarity = 0;
122 if (state->polarity == PWM_POLARITY_INVERSED)
123 polarity = PWM_POLARITY;
124
125 mtk_disp_pwm_update_bits(mdp, mdp->data->con0,
126 PWM_CLKDIV_MASK,
127 clk_div << PWM_CLKDIV_SHIFT);
128 mtk_disp_pwm_update_bits(mdp, mdp->data->con0,
129 PWM_POLARITY, polarity);
130 mtk_disp_pwm_update_bits(mdp, mdp->data->con1,
131 PWM_PERIOD_MASK | PWM_HIGH_WIDTH_MASK,
132 value);
133
134 if (mdp->data->has_commit) {
135 mtk_disp_pwm_update_bits(mdp, mdp->data->commit,
136 mdp->data->commit_mask,
137 mdp->data->commit_mask);
138 mtk_disp_pwm_update_bits(mdp, mdp->data->commit,
139 mdp->data->commit_mask,
140 0x0);
141 } else {
142 mtk_disp_pwm_update_bits(mdp, mdp->data->bls_debug,
143 mdp->data->bls_debug_mask,
144 mdp->data->bls_debug_mask);
145 mtk_disp_pwm_update_bits(mdp, mdp->data->con0,
146 mdp->data->con0_sel,
147 mdp->data->con0_sel);
148 }
149
150 mtk_disp_pwm_update_bits(mdp, DISP_PWM_EN, mdp->data->enable_mask,
151 mdp->data->enable_mask);
152 mdp->enabled = true;
153 return 0;
154 }
155
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32832 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Rex-BC Chen <rex-bc.chen@mediatek.com>,
thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de,
lee.jones@linaro.org, matthias.bgg@gmail.com
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
Rex-BC Chen <rex-bc.chen@mediatek.com>
Subject: Re: [v3,PATCH 2/3] pwm: mtk_disp: convert the driver to atomic API
Date: Tue, 6 Apr 2021 22:37:08 +0800 [thread overview]
Message-ID: <202104062217.1uJvXdY2-lkp@intel.com> (raw)
In-Reply-To: <1617703062-4251-3-git-send-email-rex-bc.chen@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 11583 bytes --]
Hi Rex-BC,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on v5.12-rc6]
[also build test WARNING on next-20210406]
[cannot apply to pwm/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Rex-BC-Chen/Convert-the-mtk_disp-driver-to-aotmic-API/20210406-180018
base: e49d033bddf5b565044e2abe4241353959bc9120
config: powerpc64-randconfig-r023-20210406 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project a46f59a747a7273cc439efaf3b4f98d8b63d2f20)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc64 cross compiling tool for clang build
# apt-get install binutils-powerpc64-linux-gnu
# https://github.com/0day-ci/linux/commit/0a2486ac437e3b8d36a0bf8ce9648c22e42ffda4
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Rex-BC-Chen/Convert-the-mtk_disp-driver-to-aotmic-API/20210406-180018
git checkout 0a2486ac437e3b8d36a0bf8ce9648c22e42ffda4
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:155:1: note: expanded from here
__do_outl
^
arch/powerpc/include/asm/io.h:537:62: note: expanded from macro '__do_outl'
#define __do_outl(val, port) writel(val,(PCI_IO_ADDR)_IO_BASE+port);
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/pwm/pwm-mtk-disp.c:10:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:43:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(insb, (unsigned long p, void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:169:1: note: expanded from here
__do_insb
^
arch/powerpc/include/asm/io.h:556:56: note: expanded from macro '__do_insb'
#define __do_insb(p, b, n) readsb((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/pwm/pwm-mtk-disp.c:10:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:45:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(insw, (unsigned long p, void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:171:1: note: expanded from here
__do_insw
^
arch/powerpc/include/asm/io.h:557:56: note: expanded from macro '__do_insw'
#define __do_insw(p, b, n) readsw((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/pwm/pwm-mtk-disp.c:10:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:47:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(insl, (unsigned long p, void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:173:1: note: expanded from here
__do_insl
^
arch/powerpc/include/asm/io.h:558:56: note: expanded from macro '__do_insl'
#define __do_insl(p, b, n) readsl((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/pwm/pwm-mtk-disp.c:10:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:49:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(outsb, (unsigned long p, const void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:175:1: note: expanded from here
__do_outsb
^
arch/powerpc/include/asm/io.h:559:58: note: expanded from macro '__do_outsb'
#define __do_outsb(p, b, n) writesb((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/pwm/pwm-mtk-disp.c:10:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:51:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(outsw, (unsigned long p, const void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:177:1: note: expanded from here
__do_outsw
^
arch/powerpc/include/asm/io.h:560:58: note: expanded from macro '__do_outsw'
#define __do_outsw(p, b, n) writesw((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/pwm/pwm-mtk-disp.c:10:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:53:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(outsl, (unsigned long p, const void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:179:1: note: expanded from here
__do_outsl
^
arch/powerpc/include/asm/io.h:561:58: note: expanded from macro '__do_outsl'
#define __do_outsl(p, b, n) writesl((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
~~~~~~~~~~~~~~~~~~~~~^
>> drivers/pwm/pwm-mtk-disp.c:109:4: warning: format specifies type 'int' but the argument has type 'u64' (aka 'unsigned long long') [-Wformat]
rate);
^~~~
include/linux/dev_printk.h:112:32: note: expanded from macro 'dev_err'
_dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
13 warnings generated.
vim +109 drivers/pwm/pwm-mtk-disp.c
70
71 static int mtk_disp_pwm_enable(struct pwm_chip *chip,
72 const struct pwm_state *state)
73 {
74 struct mtk_disp_pwm *mdp = to_mtk_disp_pwm(chip);
75 u32 clk_div, period, high_width, value, polarity;
76 u64 div, rate;
77 int err;
78
79 /*
80 * Find period, high_width and clk_div to suit duty_ns and period_ns.
81 * Calculate proper div value to keep period value in the bound.
82 *
83 * period_ns = 10^9 * (clk_div + 1) * (period + 1) / PWM_CLK_RATE
84 * duty_ns = 10^9 * (clk_div + 1) * high_width / PWM_CLK_RATE
85 *
86 * period = (PWM_CLK_RATE * period_ns) / (10^9 * (clk_div + 1)) - 1
87 * high_width = (PWM_CLK_RATE * duty_ns) / (10^9 * (clk_div + 1))
88 */
89 if (!mdp->enabled) {
90 err = clk_prepare_enable(mdp->clk_main);
91 if (err < 0) {
92 dev_err(chip->dev, "Can't enable mdp->clk_main: %d\n",
93 err);
94 return err;
95 }
96 err = clk_prepare_enable(mdp->clk_mm);
97 if (err < 0) {
98 dev_err(chip->dev, "Can't enable mdp->clk_mm: %d\n",
99 err);
100 clk_disable_unprepare(mdp->clk_main);
101 return err;
102 }
103 }
104 rate = clk_get_rate(mdp->clk_main);
105 clk_div = div_u64(rate * state->period, NSEC_PER_SEC) >>
106 PWM_PERIOD_BIT_WIDTH;
107 if (clk_div > PWM_CLKDIV_MAX) {
108 dev_err(chip->dev, "clock rate is too high: rate = %d Hz\n",
> 109 rate);
110 clk_disable_unprepare(mdp->clk_mm);
111 clk_disable_unprepare(mdp->clk_main);
112 return -EINVAL;
113 }
114 div = NSEC_PER_SEC * (clk_div + 1);
115 period = div64_u64(rate * state->period, div);
116 if (period > 0)
117 period--;
118
119 high_width = div64_u64(rate * state->duty_cycle, div);
120 value = period | (high_width << PWM_HIGH_WIDTH_SHIFT);
121 polarity = 0;
122 if (state->polarity == PWM_POLARITY_INVERSED)
123 polarity = PWM_POLARITY;
124
125 mtk_disp_pwm_update_bits(mdp, mdp->data->con0,
126 PWM_CLKDIV_MASK,
127 clk_div << PWM_CLKDIV_SHIFT);
128 mtk_disp_pwm_update_bits(mdp, mdp->data->con0,
129 PWM_POLARITY, polarity);
130 mtk_disp_pwm_update_bits(mdp, mdp->data->con1,
131 PWM_PERIOD_MASK | PWM_HIGH_WIDTH_MASK,
132 value);
133
134 if (mdp->data->has_commit) {
135 mtk_disp_pwm_update_bits(mdp, mdp->data->commit,
136 mdp->data->commit_mask,
137 mdp->data->commit_mask);
138 mtk_disp_pwm_update_bits(mdp, mdp->data->commit,
139 mdp->data->commit_mask,
140 0x0);
141 } else {
142 mtk_disp_pwm_update_bits(mdp, mdp->data->bls_debug,
143 mdp->data->bls_debug_mask,
144 mdp->data->bls_debug_mask);
145 mtk_disp_pwm_update_bits(mdp, mdp->data->con0,
146 mdp->data->con0_sel,
147 mdp->data->con0_sel);
148 }
149
150 mtk_disp_pwm_update_bits(mdp, DISP_PWM_EN, mdp->data->enable_mask,
151 mdp->data->enable_mask);
152 mdp->enabled = true;
153 return 0;
154 }
155
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32832 bytes --]
[-- Attachment #3: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Rex-BC Chen <rex-bc.chen@mediatek.com>,
thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de,
lee.jones@linaro.org, matthias.bgg@gmail.com
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
Rex-BC Chen <rex-bc.chen@mediatek.com>
Subject: Re: [v3,PATCH 2/3] pwm: mtk_disp: convert the driver to atomic API
Date: Tue, 6 Apr 2021 22:37:08 +0800 [thread overview]
Message-ID: <202104062217.1uJvXdY2-lkp@intel.com> (raw)
In-Reply-To: <1617703062-4251-3-git-send-email-rex-bc.chen@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 11583 bytes --]
Hi Rex-BC,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on v5.12-rc6]
[also build test WARNING on next-20210406]
[cannot apply to pwm/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Rex-BC-Chen/Convert-the-mtk_disp-driver-to-aotmic-API/20210406-180018
base: e49d033bddf5b565044e2abe4241353959bc9120
config: powerpc64-randconfig-r023-20210406 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project a46f59a747a7273cc439efaf3b4f98d8b63d2f20)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc64 cross compiling tool for clang build
# apt-get install binutils-powerpc64-linux-gnu
# https://github.com/0day-ci/linux/commit/0a2486ac437e3b8d36a0bf8ce9648c22e42ffda4
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Rex-BC-Chen/Convert-the-mtk_disp-driver-to-aotmic-API/20210406-180018
git checkout 0a2486ac437e3b8d36a0bf8ce9648c22e42ffda4
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:155:1: note: expanded from here
__do_outl
^
arch/powerpc/include/asm/io.h:537:62: note: expanded from macro '__do_outl'
#define __do_outl(val, port) writel(val,(PCI_IO_ADDR)_IO_BASE+port);
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/pwm/pwm-mtk-disp.c:10:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:43:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(insb, (unsigned long p, void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:169:1: note: expanded from here
__do_insb
^
arch/powerpc/include/asm/io.h:556:56: note: expanded from macro '__do_insb'
#define __do_insb(p, b, n) readsb((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/pwm/pwm-mtk-disp.c:10:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:45:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(insw, (unsigned long p, void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:171:1: note: expanded from here
__do_insw
^
arch/powerpc/include/asm/io.h:557:56: note: expanded from macro '__do_insw'
#define __do_insw(p, b, n) readsw((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/pwm/pwm-mtk-disp.c:10:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:47:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(insl, (unsigned long p, void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:173:1: note: expanded from here
__do_insl
^
arch/powerpc/include/asm/io.h:558:56: note: expanded from macro '__do_insl'
#define __do_insl(p, b, n) readsl((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/pwm/pwm-mtk-disp.c:10:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:49:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(outsb, (unsigned long p, const void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:175:1: note: expanded from here
__do_outsb
^
arch/powerpc/include/asm/io.h:559:58: note: expanded from macro '__do_outsb'
#define __do_outsb(p, b, n) writesb((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/pwm/pwm-mtk-disp.c:10:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:51:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(outsw, (unsigned long p, const void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:177:1: note: expanded from here
__do_outsw
^
arch/powerpc/include/asm/io.h:560:58: note: expanded from macro '__do_outsw'
#define __do_outsw(p, b, n) writesw((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/pwm/pwm-mtk-disp.c:10:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:53:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(outsl, (unsigned long p, const void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:179:1: note: expanded from here
__do_outsl
^
arch/powerpc/include/asm/io.h:561:58: note: expanded from macro '__do_outsl'
#define __do_outsl(p, b, n) writesl((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
~~~~~~~~~~~~~~~~~~~~~^
>> drivers/pwm/pwm-mtk-disp.c:109:4: warning: format specifies type 'int' but the argument has type 'u64' (aka 'unsigned long long') [-Wformat]
rate);
^~~~
include/linux/dev_printk.h:112:32: note: expanded from macro 'dev_err'
_dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
13 warnings generated.
vim +109 drivers/pwm/pwm-mtk-disp.c
70
71 static int mtk_disp_pwm_enable(struct pwm_chip *chip,
72 const struct pwm_state *state)
73 {
74 struct mtk_disp_pwm *mdp = to_mtk_disp_pwm(chip);
75 u32 clk_div, period, high_width, value, polarity;
76 u64 div, rate;
77 int err;
78
79 /*
80 * Find period, high_width and clk_div to suit duty_ns and period_ns.
81 * Calculate proper div value to keep period value in the bound.
82 *
83 * period_ns = 10^9 * (clk_div + 1) * (period + 1) / PWM_CLK_RATE
84 * duty_ns = 10^9 * (clk_div + 1) * high_width / PWM_CLK_RATE
85 *
86 * period = (PWM_CLK_RATE * period_ns) / (10^9 * (clk_div + 1)) - 1
87 * high_width = (PWM_CLK_RATE * duty_ns) / (10^9 * (clk_div + 1))
88 */
89 if (!mdp->enabled) {
90 err = clk_prepare_enable(mdp->clk_main);
91 if (err < 0) {
92 dev_err(chip->dev, "Can't enable mdp->clk_main: %d\n",
93 err);
94 return err;
95 }
96 err = clk_prepare_enable(mdp->clk_mm);
97 if (err < 0) {
98 dev_err(chip->dev, "Can't enable mdp->clk_mm: %d\n",
99 err);
100 clk_disable_unprepare(mdp->clk_main);
101 return err;
102 }
103 }
104 rate = clk_get_rate(mdp->clk_main);
105 clk_div = div_u64(rate * state->period, NSEC_PER_SEC) >>
106 PWM_PERIOD_BIT_WIDTH;
107 if (clk_div > PWM_CLKDIV_MAX) {
108 dev_err(chip->dev, "clock rate is too high: rate = %d Hz\n",
> 109 rate);
110 clk_disable_unprepare(mdp->clk_mm);
111 clk_disable_unprepare(mdp->clk_main);
112 return -EINVAL;
113 }
114 div = NSEC_PER_SEC * (clk_div + 1);
115 period = div64_u64(rate * state->period, div);
116 if (period > 0)
117 period--;
118
119 high_width = div64_u64(rate * state->duty_cycle, div);
120 value = period | (high_width << PWM_HIGH_WIDTH_SHIFT);
121 polarity = 0;
122 if (state->polarity == PWM_POLARITY_INVERSED)
123 polarity = PWM_POLARITY;
124
125 mtk_disp_pwm_update_bits(mdp, mdp->data->con0,
126 PWM_CLKDIV_MASK,
127 clk_div << PWM_CLKDIV_SHIFT);
128 mtk_disp_pwm_update_bits(mdp, mdp->data->con0,
129 PWM_POLARITY, polarity);
130 mtk_disp_pwm_update_bits(mdp, mdp->data->con1,
131 PWM_PERIOD_MASK | PWM_HIGH_WIDTH_MASK,
132 value);
133
134 if (mdp->data->has_commit) {
135 mtk_disp_pwm_update_bits(mdp, mdp->data->commit,
136 mdp->data->commit_mask,
137 mdp->data->commit_mask);
138 mtk_disp_pwm_update_bits(mdp, mdp->data->commit,
139 mdp->data->commit_mask,
140 0x0);
141 } else {
142 mtk_disp_pwm_update_bits(mdp, mdp->data->bls_debug,
143 mdp->data->bls_debug_mask,
144 mdp->data->bls_debug_mask);
145 mtk_disp_pwm_update_bits(mdp, mdp->data->con0,
146 mdp->data->con0_sel,
147 mdp->data->con0_sel);
148 }
149
150 mtk_disp_pwm_update_bits(mdp, DISP_PWM_EN, mdp->data->enable_mask,
151 mdp->data->enable_mask);
152 mdp->enabled = true;
153 return 0;
154 }
155
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32832 bytes --]
[-- Attachment #3: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [v3, PATCH 2/3] pwm: mtk_disp: convert the driver to atomic API
Date: Tue, 06 Apr 2021 22:37:08 +0800 [thread overview]
Message-ID: <202104062217.1uJvXdY2-lkp@intel.com> (raw)
In-Reply-To: <1617703062-4251-3-git-send-email-rex-bc.chen@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 11818 bytes --]
Hi Rex-BC,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on v5.12-rc6]
[also build test WARNING on next-20210406]
[cannot apply to pwm/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Rex-BC-Chen/Convert-the-mtk_disp-driver-to-aotmic-API/20210406-180018
base: e49d033bddf5b565044e2abe4241353959bc9120
config: powerpc64-randconfig-r023-20210406 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project a46f59a747a7273cc439efaf3b4f98d8b63d2f20)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc64 cross compiling tool for clang build
# apt-get install binutils-powerpc64-linux-gnu
# https://github.com/0day-ci/linux/commit/0a2486ac437e3b8d36a0bf8ce9648c22e42ffda4
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Rex-BC-Chen/Convert-the-mtk_disp-driver-to-aotmic-API/20210406-180018
git checkout 0a2486ac437e3b8d36a0bf8ce9648c22e42ffda4
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:155:1: note: expanded from here
__do_outl
^
arch/powerpc/include/asm/io.h:537:62: note: expanded from macro '__do_outl'
#define __do_outl(val, port) writel(val,(PCI_IO_ADDR)_IO_BASE+port);
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/pwm/pwm-mtk-disp.c:10:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:43:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(insb, (unsigned long p, void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:169:1: note: expanded from here
__do_insb
^
arch/powerpc/include/asm/io.h:556:56: note: expanded from macro '__do_insb'
#define __do_insb(p, b, n) readsb((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/pwm/pwm-mtk-disp.c:10:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:45:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(insw, (unsigned long p, void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:171:1: note: expanded from here
__do_insw
^
arch/powerpc/include/asm/io.h:557:56: note: expanded from macro '__do_insw'
#define __do_insw(p, b, n) readsw((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/pwm/pwm-mtk-disp.c:10:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:47:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(insl, (unsigned long p, void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:173:1: note: expanded from here
__do_insl
^
arch/powerpc/include/asm/io.h:558:56: note: expanded from macro '__do_insl'
#define __do_insl(p, b, n) readsl((PCI_IO_ADDR)_IO_BASE+(p), (b), (n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/pwm/pwm-mtk-disp.c:10:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:49:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(outsb, (unsigned long p, const void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:175:1: note: expanded from here
__do_outsb
^
arch/powerpc/include/asm/io.h:559:58: note: expanded from macro '__do_outsb'
#define __do_outsb(p, b, n) writesb((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/pwm/pwm-mtk-disp.c:10:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:51:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(outsw, (unsigned long p, const void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:177:1: note: expanded from here
__do_outsw
^
arch/powerpc/include/asm/io.h:560:58: note: expanded from macro '__do_outsw'
#define __do_outsw(p, b, n) writesw((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
~~~~~~~~~~~~~~~~~~~~~^
In file included from drivers/pwm/pwm-mtk-disp.c:10:
In file included from include/linux/io.h:13:
In file included from arch/powerpc/include/asm/io.h:619:
arch/powerpc/include/asm/io-defs.h:53:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
DEF_PCI_AC_NORET(outsl, (unsigned long p, const void *b, unsigned long c),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET'
__do_##name al; \
^~~~~~~~~~~~~~
<scratch space>:179:1: note: expanded from here
__do_outsl
^
arch/powerpc/include/asm/io.h:561:58: note: expanded from macro '__do_outsl'
#define __do_outsl(p, b, n) writesl((PCI_IO_ADDR)_IO_BASE+(p),(b),(n))
~~~~~~~~~~~~~~~~~~~~~^
>> drivers/pwm/pwm-mtk-disp.c:109:4: warning: format specifies type 'int' but the argument has type 'u64' (aka 'unsigned long long') [-Wformat]
rate);
^~~~
include/linux/dev_printk.h:112:32: note: expanded from macro 'dev_err'
_dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
13 warnings generated.
vim +109 drivers/pwm/pwm-mtk-disp.c
70
71 static int mtk_disp_pwm_enable(struct pwm_chip *chip,
72 const struct pwm_state *state)
73 {
74 struct mtk_disp_pwm *mdp = to_mtk_disp_pwm(chip);
75 u32 clk_div, period, high_width, value, polarity;
76 u64 div, rate;
77 int err;
78
79 /*
80 * Find period, high_width and clk_div to suit duty_ns and period_ns.
81 * Calculate proper div value to keep period value in the bound.
82 *
83 * period_ns = 10^9 * (clk_div + 1) * (period + 1) / PWM_CLK_RATE
84 * duty_ns = 10^9 * (clk_div + 1) * high_width / PWM_CLK_RATE
85 *
86 * period = (PWM_CLK_RATE * period_ns) / (10^9 * (clk_div + 1)) - 1
87 * high_width = (PWM_CLK_RATE * duty_ns) / (10^9 * (clk_div + 1))
88 */
89 if (!mdp->enabled) {
90 err = clk_prepare_enable(mdp->clk_main);
91 if (err < 0) {
92 dev_err(chip->dev, "Can't enable mdp->clk_main: %d\n",
93 err);
94 return err;
95 }
96 err = clk_prepare_enable(mdp->clk_mm);
97 if (err < 0) {
98 dev_err(chip->dev, "Can't enable mdp->clk_mm: %d\n",
99 err);
100 clk_disable_unprepare(mdp->clk_main);
101 return err;
102 }
103 }
104 rate = clk_get_rate(mdp->clk_main);
105 clk_div = div_u64(rate * state->period, NSEC_PER_SEC) >>
106 PWM_PERIOD_BIT_WIDTH;
107 if (clk_div > PWM_CLKDIV_MAX) {
108 dev_err(chip->dev, "clock rate is too high: rate = %d Hz\n",
> 109 rate);
110 clk_disable_unprepare(mdp->clk_mm);
111 clk_disable_unprepare(mdp->clk_main);
112 return -EINVAL;
113 }
114 div = NSEC_PER_SEC * (clk_div + 1);
115 period = div64_u64(rate * state->period, div);
116 if (period > 0)
117 period--;
118
119 high_width = div64_u64(rate * state->duty_cycle, div);
120 value = period | (high_width << PWM_HIGH_WIDTH_SHIFT);
121 polarity = 0;
122 if (state->polarity == PWM_POLARITY_INVERSED)
123 polarity = PWM_POLARITY;
124
125 mtk_disp_pwm_update_bits(mdp, mdp->data->con0,
126 PWM_CLKDIV_MASK,
127 clk_div << PWM_CLKDIV_SHIFT);
128 mtk_disp_pwm_update_bits(mdp, mdp->data->con0,
129 PWM_POLARITY, polarity);
130 mtk_disp_pwm_update_bits(mdp, mdp->data->con1,
131 PWM_PERIOD_MASK | PWM_HIGH_WIDTH_MASK,
132 value);
133
134 if (mdp->data->has_commit) {
135 mtk_disp_pwm_update_bits(mdp, mdp->data->commit,
136 mdp->data->commit_mask,
137 mdp->data->commit_mask);
138 mtk_disp_pwm_update_bits(mdp, mdp->data->commit,
139 mdp->data->commit_mask,
140 0x0);
141 } else {
142 mtk_disp_pwm_update_bits(mdp, mdp->data->bls_debug,
143 mdp->data->bls_debug_mask,
144 mdp->data->bls_debug_mask);
145 mtk_disp_pwm_update_bits(mdp, mdp->data->con0,
146 mdp->data->con0_sel,
147 mdp->data->con0_sel);
148 }
149
150 mtk_disp_pwm_update_bits(mdp, DISP_PWM_EN, mdp->data->enable_mask,
151 mdp->data->enable_mask);
152 mdp->enabled = true;
153 return 0;
154 }
155
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32832 bytes --]
next prev parent reply other threads:[~2021-04-06 14:37 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 9:57 [v3,PATCH 0/3] Convert the mtk_disp driver to aotmic API Rex-BC Chen
2021-04-06 9:57 ` Rex-BC Chen
2021-04-06 9:57 ` Rex-BC Chen
2021-04-06 9:57 ` [v3,PATCH 1/3] pwm: mtk_disp: clear the clock operations Rex-BC Chen
2021-04-06 9:57 ` Rex-BC Chen
2021-04-06 9:57 ` Rex-BC Chen
2021-04-06 10:07 ` Uwe Kleine-König
2021-04-06 10:07 ` Uwe Kleine-König
2021-04-06 10:07 ` Uwe Kleine-König
2021-04-06 9:57 ` [v3,PATCH 2/3] pwm: mtk_disp: convert the driver to atomic API Rex-BC Chen
2021-04-06 9:57 ` Rex-BC Chen
2021-04-06 9:57 ` Rex-BC Chen
2021-04-06 10:19 ` Uwe Kleine-König
2021-04-06 10:19 ` Uwe Kleine-König
2021-04-06 10:19 ` Uwe Kleine-König
2021-04-06 14:37 ` kernel test robot [this message]
2021-04-06 14:37 ` [v3, PATCH " kernel test robot
2021-04-06 14:37 ` [v3,PATCH " kernel test robot
2021-04-06 14:37 ` kernel test robot
2021-04-06 14:52 ` kernel test robot
2021-04-06 14:52 ` [v3, PATCH " kernel test robot
2021-04-06 14:52 ` [v3,PATCH " kernel test robot
2021-04-06 14:52 ` kernel test robot
2021-04-06 9:57 ` [v3,PATCH 3/3] pwm: mtk_disp: implement .get_state() Rex-BC Chen
2021-04-06 9:57 ` Rex-BC Chen
2021-04-06 9:57 ` Rex-BC Chen
2021-04-06 10:27 ` Uwe Kleine-König
2021-04-06 10:27 ` Uwe Kleine-König
2021-04-06 10:27 ` Uwe Kleine-König
2021-04-09 12:24 ` Thierry Reding
2021-04-09 12:24 ` Thierry Reding
2021-04-09 12:24 ` Thierry Reding
2021-04-09 21:52 ` Uwe Kleine-König
2021-04-09 21:52 ` Uwe Kleine-König
2021-04-09 21:52 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202104062217.1uJvXdY2-lkp@intel.com \
--to=lkp@intel.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=clang-built-linux@googlegroups.com \
--cc=kbuild-all@lists.01.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=rex-bc.chen@mediatek.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.