From: kernel test robot <lkp@intel.com>
To: Hongbo Li <herbert.tencent@gmail.com>,
keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
herbert@gondor.apana.org.au, dhowells@redhat.com,
zohar@linux.ibm.com, jarkko@kernel.org, herberthbli@tencent.com
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
linux-integrity@vger.kernel.org,
Hongbo Li <herbert.tencent@gmail.com>
Subject: Re: [PATCH v3 2/4] crypto: support rsa-pss encoding
Date: Wed, 7 Apr 2021 16:40:53 +0800 [thread overview]
Message-ID: <202104071609.Dx9pPd4S-lkp@intel.com> (raw)
In-Reply-To: <1617767358-25279-3-git-send-email-herbert.tencent@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2300 bytes --]
Hi Hongbo,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on cryptodev/master]
[also build test WARNING on crypto/master security/next-testing linus/master v5.12-rc6 next-20210406]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Hongbo-Li/crypto-add-rsa-pss-support-for-x509/20210407-115152
base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
config: x86_64-randconfig-s021-20210407 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-279-g6d5d9b42-dirty
# https://github.com/0day-ci/linux/commit/cd6d6b64f74124a91cb5f0e5d5485d8b159c0ff7
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Hongbo-Li/crypto-add-rsa-pss-support-for-x509/20210407-115152
git checkout cd6d6b64f74124a91cb5f0e5d5485d8b159c0ff7
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> crypto/rsa_helper.c:247:33: sparse: sparse: cast to restricted __be16
>> crypto/rsa_helper.c:247:33: sparse: sparse: cast to restricted __be16
>> crypto/rsa_helper.c:247:33: sparse: sparse: cast to restricted __be16
>> crypto/rsa_helper.c:247:33: sparse: sparse: cast to restricted __be16
vim +247 crypto/rsa_helper.c
235
236 int rsa_get_pss_saltlen(void *context, size_t hdrlen, unsigned char tag,
237 const void *value, size_t vlen)
238 {
239 struct rsa_pss_ctx *ctx = context;
240
241 if (!value || vlen < 1 || vlen > 2)
242 return -EINVAL;
243
244 if (vlen == 1)
245 ctx->salt_len = *(u8 *)value;
246 else if (vlen == 2)
> 247 ctx->salt_len = ntohs(*(u16 *)value);
248
249 return 0;
250 }
251
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35310 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v3 2/4] crypto: support rsa-pss encoding
Date: Wed, 07 Apr 2021 16:40:53 +0800 [thread overview]
Message-ID: <202104071609.Dx9pPd4S-lkp@intel.com> (raw)
In-Reply-To: <1617767358-25279-3-git-send-email-herbert.tencent@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2359 bytes --]
Hi Hongbo,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on cryptodev/master]
[also build test WARNING on crypto/master security/next-testing linus/master v5.12-rc6 next-20210406]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Hongbo-Li/crypto-add-rsa-pss-support-for-x509/20210407-115152
base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
config: x86_64-randconfig-s021-20210407 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-279-g6d5d9b42-dirty
# https://github.com/0day-ci/linux/commit/cd6d6b64f74124a91cb5f0e5d5485d8b159c0ff7
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Hongbo-Li/crypto-add-rsa-pss-support-for-x509/20210407-115152
git checkout cd6d6b64f74124a91cb5f0e5d5485d8b159c0ff7
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> crypto/rsa_helper.c:247:33: sparse: sparse: cast to restricted __be16
>> crypto/rsa_helper.c:247:33: sparse: sparse: cast to restricted __be16
>> crypto/rsa_helper.c:247:33: sparse: sparse: cast to restricted __be16
>> crypto/rsa_helper.c:247:33: sparse: sparse: cast to restricted __be16
vim +247 crypto/rsa_helper.c
235
236 int rsa_get_pss_saltlen(void *context, size_t hdrlen, unsigned char tag,
237 const void *value, size_t vlen)
238 {
239 struct rsa_pss_ctx *ctx = context;
240
241 if (!value || vlen < 1 || vlen > 2)
242 return -EINVAL;
243
244 if (vlen == 1)
245 ctx->salt_len = *(u8 *)value;
246 else if (vlen == 2)
> 247 ctx->salt_len = ntohs(*(u16 *)value);
248
249 return 0;
250 }
251
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35310 bytes --]
next prev parent reply other threads:[~2021-04-07 8:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 3:49 [PATCH v3 0/4] crypto: add rsa pss support for x509 Hongbo Li
2021-04-07 3:49 ` [PATCH v3 1/4] x509: add support for rsa-pss Hongbo Li
2021-04-07 3:49 ` [PATCH v3 2/4] crypto: support rsa-pss encoding Hongbo Li
2021-04-07 8:40 ` kernel test robot [this message]
2021-04-07 8:40 ` kernel test robot
2021-04-07 3:49 ` [PATCH v3 3/4] crypto: add rsa pss test vector Hongbo Li
2021-04-07 3:49 ` [PATCH v3 4/4] ima: add support for rsa pss verification Hongbo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202104071609.Dx9pPd4S-lkp@intel.com \
--to=lkp@intel.com \
--cc=dhowells@redhat.com \
--cc=herbert.tencent@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=herberthbli@tencent.com \
--cc=jarkko@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.