From: "hch@infradead.org" <hch@infradead.org>
To: Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: "hch@infradead.org" <hch@infradead.org>,
"dsterba@suse.cz" <dsterba@suse.cz>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
Mike Snitzer <snitzer@redhat.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Christoph Hellwig <hch@lst.de>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
David Sterba <dsterba@suse.com>,
Josef Bacik <josef@toxicpanda.com>,
Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
Naohiro Aota <Naohiro.Aota@wdc.com>
Subject: Re: [PATCH 3/4] btrfs: zoned: fail mount if the device does not support zone append
Date: Mon, 19 Apr 2021 10:39:21 +0100 [thread overview]
Message-ID: <20210419093921.GA3226573@infradead.org> (raw)
In-Reply-To: <BL0PR04MB651459AE484861FD4EA20669E7499@BL0PR04MB6514.namprd04.prod.outlook.com>
On Mon, Apr 19, 2021 at 09:35:37AM +0000, Damien Le Moal wrote:
> This is only to avoid someone from running zoned-btrfs on top of dm-crypt.
> Without this patch, mount will be OK and file data writes will also actually be
> OK. But all reads will miserably fail... I would rather have this patch in than
> deal with the "bug reports" about btrfs failing to read files. No ?
>
> Note that like you, I dislike having to add such code. But it was my oversight
> when I worked on getting dm-crypt to work on zoned drives. Zone append was
> overlooked at that time... My bad, really.
dm-crypt needs to stop pretending it supports zoned devices if it
doesn't. Note that dm-crypt could fairly trivially support zone append
by doing the same kind of emulation that the sd driver does.
WARNING: multiple messages have this Message-ID (diff)
From: "hch@infradead.org" <hch@infradead.org>
To: Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: "hch@infradead.org" <hch@infradead.org>,
"dsterba@suse.cz" <dsterba@suse.cz>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
Mike Snitzer <snitzer@redhat.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Christoph Hellwig <hch@lst.de>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
David Sterba <dsterba@suse.com>,
Josef Bacik <josef@toxicpanda.com>,
Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
Naohiro Aota <Naohiro.Aota@wdc.com>
Subject: Re: [PATCH 3/4] btrfs: zoned: fail mount if the device does not support zone append
Date: Mon, 19 Apr 2021 10:39:21 +0100 [thread overview]
Message-ID: <20210419093921.GA3226573@infradead.org> (raw)
In-Reply-To: <BL0PR04MB651459AE484861FD4EA20669E7499@BL0PR04MB6514.namprd04.prod.outlook.com>
On Mon, Apr 19, 2021 at 09:35:37AM +0000, Damien Le Moal wrote:
> This is only to avoid someone from running zoned-btrfs on top of dm-crypt.
> Without this patch, mount will be OK and file data writes will also actually be
> OK. But all reads will miserably fail... I would rather have this patch in than
> deal with the "bug reports" about btrfs failing to read files. No ?
>
> Note that like you, I dislike having to add such code. But it was my oversight
> when I worked on getting dm-crypt to work on zoned drives. Zone append was
> overlooked at that time... My bad, really.
dm-crypt needs to stop pretending it supports zoned devices if it
doesn't. Note that dm-crypt could fairly trivially support zone append
by doing the same kind of emulation that the sd driver does.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
WARNING: multiple messages have this Message-ID (diff)
From: "hch@infradead.org" <hch@infradead.org>
To: Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: Jens Axboe <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Mike Snitzer <snitzer@redhat.com>,
Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
"dsterba@suse.cz" <dsterba@suse.cz>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Josef Bacik <josef@toxicpanda.com>,
"hch@infradead.org" <hch@infradead.org>,
David Sterba <dsterba@suse.com>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
Naohiro Aota <Naohiro.Aota@wdc.com>
Subject: Re: [dm-devel] [PATCH 3/4] btrfs: zoned: fail mount if the device does not support zone append
Date: Mon, 19 Apr 2021 10:39:21 +0100 [thread overview]
Message-ID: <20210419093921.GA3226573@infradead.org> (raw)
In-Reply-To: <BL0PR04MB651459AE484861FD4EA20669E7499@BL0PR04MB6514.namprd04.prod.outlook.com>
On Mon, Apr 19, 2021 at 09:35:37AM +0000, Damien Le Moal wrote:
> This is only to avoid someone from running zoned-btrfs on top of dm-crypt.
> Without this patch, mount will be OK and file data writes will also actually be
> OK. But all reads will miserably fail... I would rather have this patch in than
> deal with the "bug reports" about btrfs failing to read files. No ?
>
> Note that like you, I dislike having to add such code. But it was my oversight
> when I worked on getting dm-crypt to work on zoned drives. Zone append was
> overlooked at that time... My bad, really.
dm-crypt needs to stop pretending it supports zoned devices if it
doesn't. Note that dm-crypt could fairly trivially support zone append
by doing the same kind of emulation that the sd driver does.
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-04-19 9:42 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 3:05 [PATCH 0/4] Fix dm-crypt zoned block device support Damien Le Moal
2021-04-16 3:05 ` [dm-devel] " Damien Le Moal
2021-04-16 3:05 ` Damien Le Moal
2021-04-16 3:05 ` [PATCH 1/4] dm: Introduce zone append support control Damien Le Moal
2021-04-16 3:05 ` [dm-devel] " Damien Le Moal
2021-04-16 3:05 ` Damien Le Moal
2021-04-16 6:51 ` Johannes Thumshirn
2021-04-16 6:51 ` [dm-devel] " Johannes Thumshirn
2021-04-16 6:51 ` Johannes Thumshirn
2021-04-16 3:05 ` [PATCH 2/4] dm crypt: Fix zoned block device support Damien Le Moal
2021-04-16 3:05 ` [dm-devel] " Damien Le Moal
2021-04-16 3:05 ` Damien Le Moal
2021-04-16 7:13 ` Johannes Thumshirn
2021-04-16 7:13 ` [dm-devel] " Johannes Thumshirn
2021-04-16 7:13 ` Johannes Thumshirn
2021-04-16 7:30 ` Damien Le Moal
2021-04-16 7:30 ` [dm-devel] " Damien Le Moal
2021-04-16 7:30 ` Damien Le Moal
2021-04-16 9:10 ` Johannes Thumshirn
2021-04-16 9:10 ` [dm-devel] " Johannes Thumshirn
2021-04-16 9:10 ` Johannes Thumshirn
2021-04-16 3:05 ` [PATCH 3/4] btrfs: zoned: fail mount if the device does not support zone append Damien Le Moal
2021-04-16 3:05 ` [dm-devel] " Damien Le Moal
2021-04-16 3:05 ` Damien Le Moal
2021-04-16 16:17 ` David Sterba
2021-04-16 16:17 ` [dm-devel] " David Sterba
2021-04-16 16:17 ` David Sterba
2021-04-19 9:28 ` Christoph Hellwig
2021-04-19 9:28 ` [dm-devel] " Christoph Hellwig
2021-04-19 9:28 ` Christoph Hellwig
2021-04-19 9:35 ` Damien Le Moal
2021-04-19 9:35 ` [dm-devel] " Damien Le Moal
2021-04-19 9:35 ` Damien Le Moal
2021-04-19 9:39 ` hch [this message]
2021-04-19 9:39 ` [dm-devel] " hch
2021-04-19 9:39 ` hch
2021-04-19 9:46 ` Damien Le Moal
2021-04-19 9:46 ` [dm-devel] " Damien Le Moal
2021-04-19 9:46 ` Damien Le Moal
2021-04-19 16:48 ` David Sterba
2021-04-19 16:48 ` [dm-devel] " David Sterba
2021-04-19 16:48 ` David Sterba
2021-04-19 9:39 ` Johannes Thumshirn
2021-04-19 9:39 ` [dm-devel] " Johannes Thumshirn
2021-04-19 9:39 ` Johannes Thumshirn
2021-04-16 3:05 ` [PATCH 4/4] zonefs: fix synchronous write to sequential zone files Damien Le Moal
2021-04-16 3:05 ` [dm-devel] " Damien Le Moal
2021-04-16 3:05 ` Damien Le Moal
2021-04-16 6:50 ` Johannes Thumshirn
2021-04-16 6:50 ` [dm-devel] " Johannes Thumshirn
2021-04-16 6:50 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210419093921.GA3226573@infradead.org \
--to=hch@infradead.org \
--cc=Damien.LeMoal@wdc.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=Naohiro.Aota@wdc.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=hch@lst.de \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=shinichiro.kawasaki@wdc.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.