From: Jason Gunthorpe <jgg@nvidia.com>
To: Devesh Sharma <devesh.sharma@broadcom.com>
Cc: Leon Romanovsky <leon@kernel.org>,
Doug Ledford <dledford@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-rdma <linux-rdma@vger.kernel.org>,
Michael Chan <michael.chan@broadcom.com>,
Naresh Kumar PBS <nareshkumar.pbs@broadcom.com>,
Netdev <netdev@vger.kernel.org>,
Selvin Xavier <selvin.xavier@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Subject: Re: [PATCH rdma-next v2 0/5] Get rid of custom made module dependency
Date: Mon, 19 Apr 2021 14:38:09 -0300 [thread overview]
Message-ID: <20210419173809.GW1370958@nvidia.com> (raw)
In-Reply-To: <CANjDDBgsh9FrQOgB-uR0GGYZHcF5cnTy4Efnd3L_-T2_eWqxsg@mail.gmail.com>
On Sun, Apr 18, 2021 at 12:09:16AM +0530, Devesh Sharma wrote:
> The host crash I indicated earlier is actually caused by patch 4 and
> not by patch 3 from this series. I spent time to root cause the
This makes a lot more sense.
The ulp_id stuff does need to go away as well though.
> problem and realized that patch-4 is touching quite many areas which
> would require much intrusive testing and validation.
> As I indicated earlier, we are implementing the PCI Aux driver
> interface at a faster pace.
Doing an aux driver doesn't mean you get to keep all these single
implementation function pointers - see the discussion around Intel's
patches.
> The problem of module referencing would be rectified with PCI aux
> change by inheritance.
The first three patches are clearly an improvement, and quite trivial,
so I'm going to take them.
Jason
next prev parent reply other threads:[~2021-04-19 17:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 6:57 [PATCH rdma-next v2 0/5] Get rid of custom made module dependency Leon Romanovsky
2021-04-01 6:57 ` [PATCH rdma-next v2 1/5] RDMA/bnxt_re: Depend on bnxt ethernet driver and not blindly select it Leon Romanovsky
2021-04-21 17:50 ` Devesh Sharma
2021-04-01 6:57 ` [PATCH rdma-next v2 2/5] RDMA/bnxt_re: Create direct symbolic link between bnxt modules Leon Romanovsky
2021-04-21 17:51 ` Devesh Sharma
2021-04-01 6:57 ` [PATCH rdma-next v2 3/5] RDMA/bnxt_re: Get rid of custom module reference counting Leon Romanovsky
2021-04-21 17:52 ` Devesh Sharma
2021-04-01 6:57 ` [PATCH rdma-next v2 4/5] net/bnxt: Remove useless check of non-existent ULP id Leon Romanovsky
2021-04-01 6:57 ` [PATCH rdma-next v2 5/5] net/bnxt: Use direct API instead of useless indirection Leon Romanovsky
2021-04-03 10:22 ` [PATCH rdma-next v2 0/5] Get rid of custom made module dependency Devesh Sharma
2021-04-03 11:42 ` Leon Romanovsky
2021-04-08 11:36 ` Devesh Sharma
2021-04-08 11:44 ` Leon Romanovsky
2021-04-08 11:53 ` Jason Gunthorpe
2021-04-08 12:03 ` Leon Romanovsky
2021-04-08 15:21 ` Devesh Sharma
2021-04-08 15:12 ` Devesh Sharma
2021-04-12 7:40 ` Leon Romanovsky
2021-04-14 13:45 ` Devesh Sharma
2021-04-17 8:14 ` Leon Romanovsky
2021-04-17 18:39 ` Devesh Sharma
2021-04-18 4:18 ` Leon Romanovsky
2021-04-19 17:38 ` Jason Gunthorpe [this message]
2021-04-19 19:04 ` Devesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210419173809.GW1370958@nvidia.com \
--to=jgg@nvidia.com \
--cc=davem@davemloft.net \
--cc=devesh.sharma@broadcom.com \
--cc=dledford@redhat.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=nareshkumar.pbs@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=selvin.xavier@broadcom.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.