Re: [PATCH rdma-next v2 1/5] RDMA/bnxt_re: Depend on bnxt ethernet driver and not blindly select it

From: Devesh Sharma <devesh.sharma@broadcom.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
	Jason Gunthorpe <jgg@nvidia.com>,
	Leon Romanovsky <leonro@nvidia.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-rdma <linux-rdma@vger.kernel.org>,
	Michael Chan <michael.chan@broadcom.com>,
	Naresh Kumar PBS <nareshkumar.pbs@broadcom.com>,
	Netdev <netdev@vger.kernel.org>,
	Selvin Xavier <selvin.xavier@broadcom.com>,
	Somnath Kotur <somnath.kotur@broadcom.com>,
	Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Subject: Re: [PATCH rdma-next v2 1/5] RDMA/bnxt_re: Depend on bnxt ethernet driver and not blindly select it
Date: Wed, 21 Apr 2021 23:20:28 +0530	[thread overview]
Message-ID: <CANjDDBhiXdO3ve70RA55svoptWXGiL7thwhr5k7L2CAd1n1P=A@mail.gmail.com> (raw)
In-Reply-To: <20210401065715.565226-2-leon@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1498 bytes --]

On Thu, Apr 1, 2021 at 12:27 PM Leon Romanovsky <leon@kernel.org> wrote:
>
> From: Leon Romanovsky <leonro@nvidia.com>
>
> The "select" kconfig keyword provides reverse dependency, however it
> doesn't check that selected symbol meets its own dependencies. Usually
> "select" is used for non-visible symbols, so instead of trying to keep
> dependencies in sync with BNXT ethernet driver, simply "depends on" it,
> like Kconfig documentation suggest.
>
> * CONFIG_PCI is already required by BNXT
> * CONFIG_NETDEVICES and CONFIG_ETHERNET are needed to chose BNXT
>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
>  drivers/infiniband/hw/bnxt_re/Kconfig | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/hw/bnxt_re/Kconfig b/drivers/infiniband/hw/bnxt_re/Kconfig
> index 0feac5132ce1..6a17f5cdb020 100644
> --- a/drivers/infiniband/hw/bnxt_re/Kconfig
> +++ b/drivers/infiniband/hw/bnxt_re/Kconfig
> @@ -2,9 +2,7 @@
>  config INFINIBAND_BNXT_RE
>         tristate "Broadcom Netxtreme HCA support"
>         depends on 64BIT
> -       depends on ETHERNET && NETDEVICES && PCI && INET && DCB
> -       select NET_VENDOR_BROADCOM
> -       select BNXT
> +       depends on INET && DCB && BNXT
>         help
>           This driver supports Broadcom NetXtreme-E 10/25/40/50 gigabit
>           RoCE HCAs.  To compile this driver as a module, choose M here:
> --
> 2.30.2
>
Acked-By: Devesh Sharma <devesh.sharma@broadcom.com>

-- 
-Regards
Devesh

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]