From: Sudeep Holla <sudeep.holla@arm.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Hanjun Guo <guohanjun@huawei.com>,
dann frazier <dann.frazier@canonical.com>,
Fu Wei <wefu@redhat.com>, Len Brown <lenb@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel-team@android.com,
stable@vger.kernel.org, Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH 1/2] ACPI: GTDT: Don't corrupt interrupt mappings on watchdow probe failure
Date: Wed, 21 Apr 2021 18:20:56 +0100 [thread overview]
Message-ID: <20210421172056.n2yoggo5epqwdhtc@bogus> (raw)
In-Reply-To: <20210421164317.1718831-2-maz@kernel.org>
(with stable email fixed, but may need separate posting anyways)
On Wed, Apr 21, 2021 at 05:43:16PM +0100, Marc Zyngier wrote:
> When failing the driver probe because of invalid firmware properties,
> the GTDT driver unmaps the interrupt that it mapped earlier.
>
> However, it never checks whether the mapping of the interrupt actially
> succeeded. Even more, should the firmware report an illegal interrupt
> number that overlaps with the GIC SGI range, this can result in an
> IPI being unmapped, and subsequent fireworks (as reported by Dann
> Frazier).
>
> Rework the driver to have a slightly saner behaviour and actually
> check whether the interrupt has been mapped before unmapping things.
>
> Reported-by: dann frazier <dann.frazier@canonical.com>
> Fixes: ca9ae5ec4ef0 ("acpi/arm64: Add SBSA Generic Watchdog support in GTDT driver")
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> Link: https://lore.kernel.org/r/YH87dtTfwYgavusz@xps13.dannf
> Cc: stable@vgerlkernel.org
^^^
I thought I messed up while replying with my fat fingers, but here is the
culprit. I got mail delivery failure to my reply, thought I will let you
know as it may be difficult to notice this when using git send-email.
--
Regards,
Sudeep
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Hanjun Guo <guohanjun@huawei.com>,
dann frazier <dann.frazier@canonical.com>,
Fu Wei <wefu@redhat.com>, Len Brown <lenb@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel-team@android.com,
stable@vger.kernel.org, Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH 1/2] ACPI: GTDT: Don't corrupt interrupt mappings on watchdow probe failure
Date: Wed, 21 Apr 2021 18:20:56 +0100 [thread overview]
Message-ID: <20210421172056.n2yoggo5epqwdhtc@bogus> (raw)
In-Reply-To: <20210421164317.1718831-2-maz@kernel.org>
(with stable email fixed, but may need separate posting anyways)
On Wed, Apr 21, 2021 at 05:43:16PM +0100, Marc Zyngier wrote:
> When failing the driver probe because of invalid firmware properties,
> the GTDT driver unmaps the interrupt that it mapped earlier.
>
> However, it never checks whether the mapping of the interrupt actially
> succeeded. Even more, should the firmware report an illegal interrupt
> number that overlaps with the GIC SGI range, this can result in an
> IPI being unmapped, and subsequent fireworks (as reported by Dann
> Frazier).
>
> Rework the driver to have a slightly saner behaviour and actually
> check whether the interrupt has been mapped before unmapping things.
>
> Reported-by: dann frazier <dann.frazier@canonical.com>
> Fixes: ca9ae5ec4ef0 ("acpi/arm64: Add SBSA Generic Watchdog support in GTDT driver")
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> Link: https://lore.kernel.org/r/YH87dtTfwYgavusz@xps13.dannf
> Cc: stable@vgerlkernel.org
^^^
I thought I messed up while replying with my fat fingers, but here is the
culprit. I got mail delivery failure to my reply, thought I will let you
know as it may be difficult to notice this when using git send-email.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-21 17:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 16:43 [PATCH 0/2] arm64: ACPI GTDT watchdog fixes Marc Zyngier
2021-04-21 16:43 ` Marc Zyngier
2021-04-21 16:43 ` [PATCH 1/2] ACPI: GTDT: Don't corrupt interrupt mappings on watchdow probe failure Marc Zyngier
2021-04-21 16:43 ` Marc Zyngier
2021-04-21 17:14 ` Sudeep Holla
2021-04-21 17:14 ` Sudeep Holla
2021-04-21 17:20 ` Sudeep Holla [this message]
2021-04-21 17:20 ` Sudeep Holla
2021-04-21 17:57 ` Marc Zyngier
2021-04-21 17:57 ` Marc Zyngier
2021-04-21 16:43 ` [PATCH 2/2] ACPI: irq: Prevent unregistering of GIC SGIs Marc Zyngier
2021-04-21 16:43 ` Marc Zyngier
2021-04-21 17:15 ` Sudeep Holla
2021-04-21 17:15 ` Sudeep Holla
2021-04-21 17:56 ` Marc Zyngier
2021-04-21 17:56 ` Marc Zyngier
2021-04-21 18:09 ` [PATCH 0/2] arm64: ACPI GTDT watchdog fixes dann frazier
2021-04-21 18:09 ` dann frazier
2021-04-22 13:42 ` Hanjun Guo
2021-04-22 13:42 ` Hanjun Guo
2021-04-22 14:23 ` Lorenzo Pieralisi
2021-04-22 14:23 ` Lorenzo Pieralisi
2021-04-23 13:43 ` Catalin Marinas
2021-04-23 13:43 ` Catalin Marinas
2021-04-23 17:11 ` Catalin Marinas
2021-04-23 17:11 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210421172056.n2yoggo5epqwdhtc@bogus \
--to=sudeep.holla@arm.com \
--cc=dann.frazier@canonical.com \
--cc=guohanjun@huawei.com \
--cc=kernel-team@android.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=maz@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=stable@vger.kernel.org \
--cc=wefu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.