From: Nishanth Menon <nm@ti.com> To: Yang Li <yang.lee@linux.alibaba.com> Cc: <ssantosh@kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-pm@vger.kernel.org> Subject: Re: [PATCH v2] soc: ti: smartreflex after the relocation to maintain consistency Date: Mon, 26 Apr 2021 09:47:08 -0500 [thread overview] Message-ID: <20210426144708.3r3h4csg6wywyude@italics> (raw) In-Reply-To: <1619090212-103038-1-git-send-email-yang.lee@linux.alibaba.com> On 19:16-20210422, Yang Li wrote: > v2: According to Nishanth Menon's suggestion, the subject has been > corrected. > https://lore.kernel.org/patchwork/patch/1383883/ The above does'nt belong to commit message. it should probably be posted in diffstat section. will also be good to rebase once 5.13-rc1 is out. > > Fix the following coccicheck warning: > ./drivers/soc/ti/smartreflex.c:820:0-23: WARNING: pm_sr_fops should be > defined with DEFINE_DEBUGFS_ATTRIBUTE > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > Reviewed-by: Nishanth Menon <nm@ti.com> > --- > drivers/soc/ti/smartreflex.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/ti/smartreflex.c b/drivers/soc/ti/smartreflex.c > index 5376f3d..b3c7460 100644 > --- a/drivers/soc/ti/smartreflex.c > +++ b/drivers/soc/ti/smartreflex.c > @@ -817,7 +817,7 @@ static int omap_sr_autocomp_store(void *data, u64 val) > return 0; > } > > -DEFINE_SIMPLE_ATTRIBUTE(pm_sr_fops, omap_sr_autocomp_show, > +DEFINE_DEBUGFS_ATTRIBUTE(pm_sr_fops, omap_sr_autocomp_show, > omap_sr_autocomp_store, "%llu\n"); > > static int omap_sr_probe(struct platform_device *pdev) > -- > 1.8.3.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com> To: Yang Li <yang.lee@linux.alibaba.com> Cc: <ssantosh@kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-pm@vger.kernel.org> Subject: Re: [PATCH v2] soc: ti: smartreflex after the relocation to maintain consistency Date: Mon, 26 Apr 2021 09:47:08 -0500 [thread overview] Message-ID: <20210426144708.3r3h4csg6wywyude@italics> (raw) In-Reply-To: <1619090212-103038-1-git-send-email-yang.lee@linux.alibaba.com> On 19:16-20210422, Yang Li wrote: > v2: According to Nishanth Menon's suggestion, the subject has been > corrected. > https://lore.kernel.org/patchwork/patch/1383883/ The above does'nt belong to commit message. it should probably be posted in diffstat section. will also be good to rebase once 5.13-rc1 is out. > > Fix the following coccicheck warning: > ./drivers/soc/ti/smartreflex.c:820:0-23: WARNING: pm_sr_fops should be > defined with DEFINE_DEBUGFS_ATTRIBUTE > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > Reviewed-by: Nishanth Menon <nm@ti.com> > --- > drivers/soc/ti/smartreflex.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/ti/smartreflex.c b/drivers/soc/ti/smartreflex.c > index 5376f3d..b3c7460 100644 > --- a/drivers/soc/ti/smartreflex.c > +++ b/drivers/soc/ti/smartreflex.c > @@ -817,7 +817,7 @@ static int omap_sr_autocomp_store(void *data, u64 val) > return 0; > } > > -DEFINE_SIMPLE_ATTRIBUTE(pm_sr_fops, omap_sr_autocomp_show, > +DEFINE_DEBUGFS_ATTRIBUTE(pm_sr_fops, omap_sr_autocomp_show, > omap_sr_autocomp_store, "%llu\n"); > > static int omap_sr_probe(struct platform_device *pdev) > -- > 1.8.3.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-26 14:48 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-22 11:16 [PATCH v2] soc: ti: smartreflex after the relocation to maintain consistency Yang Li 2021-04-22 11:16 ` Yang Li 2021-04-26 14:47 ` Nishanth Menon [this message] 2021-04-26 14:47 ` Nishanth Menon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210426144708.3r3h4csg6wywyude@italics \ --to=nm@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=ssantosh@kernel.org \ --cc=yang.lee@linux.alibaba.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.