All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
	rodrigo.vivi@intel.com, airlied@linux.ie, daniel@ffwll.ch,
	chris@chris-wilson.co.uk
Cc: intel-gfx@lists.freedesktop.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	dri-devel@lists.freedesktop.org
Subject: [PATCH v8 0/5] drm: Move struct drm_device.pdev to legacy
Date: Thu, 29 Apr 2021 12:50:56 +0200	[thread overview]
Message-ID: <20210429105101.25667-1-tzimmermann@suse.de> (raw)

V8 of the patchset fixes more bitrot and some commit messages.

The pdev field in struct drm_device points to a PCI device structure and
goes back to UMS-only days when all DRM drivers were for PCI devices.
Meanwhile we also support USB, SPI and platform devices. Each of those
uses the generic device stored in struct drm_device.dev.

To reduce duplication and remove the special case of PCI, this patchset
converts all modesetting drivers from pdev to dev and makes pdev a field
for legacy UMS drivers.

For PCI devices, the pointer in struct drm_device.dev can be upcasted to
struct pci_device; or tested for PCI with dev_is_pci(). In several places
the code can use the dev field directly.

After converting all drivers and the DRM core, the pdev fields becomes
only relevant for legacy drivers. In a later patchset, we may want to
convert these as well and remove pdev entirely.

v8:
	* fix pdev bitrot in ast
	* fix commit messages (Michael)
v7:
	* fix instances of pdev that have benn added under i915/
v6:
	* also remove assignment in i915/selftests in later patch (Chris)
v5:
	* remove assignment in later patch (Chris)
v4:
	* merged several patches
	* moved core changes into separate patch
	* vmwgfx build fix
v3:
	* merged several patches
	* fix one pdev reference in nouveau (Jeremy)
	* rebases
v2:
	* move whitespace fixes into separate patches (Alex, Sam)
	* move i915 gt/ and gvt/ changes into separate patches (Joonas)

Thomas Zimmermann (5):
  drm/ast: Remove reference to struct drm_device.pdev
  drm/i915/gt: Remove reference to struct drm_device.pdev
  drm/i915: Remove reference to struct drm_device.pdev
  drm/i915: Don't assign to struct drm_device.pdev
  drm: Move struct drm_device.pdev to legacy section

 drivers/gpu/drm/ast/ast_main.c                   | 1 -
 drivers/gpu/drm/i915/gt/intel_region_lmem.c      | 2 +-
 drivers/gpu/drm/i915/i915_drv.c                  | 1 -
 drivers/gpu/drm/i915/intel_runtime_pm.h          | 2 +-
 drivers/gpu/drm/i915/selftests/mock_gem_device.c | 1 -
 include/drm/drm_device.h                         | 6 +++---
 6 files changed, 5 insertions(+), 8 deletions(-)


base-commit: bf25e1addaf44137e20ce95de72ff118b37d808c
prerequisite-patch-id: c2b2f08f0eccc9f5df0c0da49fa1d36267deb11d
prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24
prerequisite-patch-id: c59ca2ddb182af06006fa360ad3e90fe16b93d3a
--
2.31.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
	rodrigo.vivi@intel.com, airlied@linux.ie, daniel@ffwll.ch,
	chris@chris-wilson.co.uk
Cc: intel-gfx@lists.freedesktop.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	dri-devel@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v8 0/5] drm: Move struct drm_device.pdev to legacy
Date: Thu, 29 Apr 2021 12:50:56 +0200	[thread overview]
Message-ID: <20210429105101.25667-1-tzimmermann@suse.de> (raw)

V8 of the patchset fixes more bitrot and some commit messages.

The pdev field in struct drm_device points to a PCI device structure and
goes back to UMS-only days when all DRM drivers were for PCI devices.
Meanwhile we also support USB, SPI and platform devices. Each of those
uses the generic device stored in struct drm_device.dev.

To reduce duplication and remove the special case of PCI, this patchset
converts all modesetting drivers from pdev to dev and makes pdev a field
for legacy UMS drivers.

For PCI devices, the pointer in struct drm_device.dev can be upcasted to
struct pci_device; or tested for PCI with dev_is_pci(). In several places
the code can use the dev field directly.

After converting all drivers and the DRM core, the pdev fields becomes
only relevant for legacy drivers. In a later patchset, we may want to
convert these as well and remove pdev entirely.

v8:
	* fix pdev bitrot in ast
	* fix commit messages (Michael)
v7:
	* fix instances of pdev that have benn added under i915/
v6:
	* also remove assignment in i915/selftests in later patch (Chris)
v5:
	* remove assignment in later patch (Chris)
v4:
	* merged several patches
	* moved core changes into separate patch
	* vmwgfx build fix
v3:
	* merged several patches
	* fix one pdev reference in nouveau (Jeremy)
	* rebases
v2:
	* move whitespace fixes into separate patches (Alex, Sam)
	* move i915 gt/ and gvt/ changes into separate patches (Joonas)

Thomas Zimmermann (5):
  drm/ast: Remove reference to struct drm_device.pdev
  drm/i915/gt: Remove reference to struct drm_device.pdev
  drm/i915: Remove reference to struct drm_device.pdev
  drm/i915: Don't assign to struct drm_device.pdev
  drm: Move struct drm_device.pdev to legacy section

 drivers/gpu/drm/ast/ast_main.c                   | 1 -
 drivers/gpu/drm/i915/gt/intel_region_lmem.c      | 2 +-
 drivers/gpu/drm/i915/i915_drv.c                  | 1 -
 drivers/gpu/drm/i915/intel_runtime_pm.h          | 2 +-
 drivers/gpu/drm/i915/selftests/mock_gem_device.c | 1 -
 include/drm/drm_device.h                         | 6 +++---
 6 files changed, 5 insertions(+), 8 deletions(-)


base-commit: bf25e1addaf44137e20ce95de72ff118b37d808c
prerequisite-patch-id: c2b2f08f0eccc9f5df0c0da49fa1d36267deb11d
prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24
prerequisite-patch-id: c59ca2ddb182af06006fa360ad3e90fe16b93d3a
--
2.31.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2021-04-29 10:51 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-29 10:50 Thomas Zimmermann [this message]
2021-04-29 10:50 ` [Intel-gfx] [PATCH v8 0/5] drm: Move struct drm_device.pdev to legacy Thomas Zimmermann
2021-04-29 10:50 ` [PATCH v8 1/5] drm/ast: Remove reference to struct drm_device.pdev Thomas Zimmermann
2021-04-29 10:50   ` [Intel-gfx] " Thomas Zimmermann
2021-04-29 16:04   ` Ruhl, Michael J
2021-04-29 16:04     ` [Intel-gfx] " Ruhl, Michael J
2021-04-29 19:22     ` Thomas Zimmermann
2021-04-29 19:22       ` [Intel-gfx] " Thomas Zimmermann
2021-04-29 10:50 ` [PATCH v8 2/5] drm/i915/gt: " Thomas Zimmermann
2021-04-29 10:50   ` [Intel-gfx] " Thomas Zimmermann
2021-04-29 16:02   ` Ruhl, Michael J
2021-04-29 16:02     ` Ruhl, Michael J
2021-04-29 10:50 ` [PATCH v8 3/5] drm/i915: " Thomas Zimmermann
2021-04-29 10:50   ` [Intel-gfx] " Thomas Zimmermann
2021-04-29 16:03   ` Ruhl, Michael J
2021-04-29 16:03     ` [Intel-gfx] " Ruhl, Michael J
2021-04-29 10:51 ` [PATCH v8 4/5] drm/i915: Don't assign " Thomas Zimmermann
2021-04-29 10:51   ` [Intel-gfx] " Thomas Zimmermann
2021-04-29 10:51 ` [PATCH v8 5/5] drm: Move struct drm_device.pdev to legacy section Thomas Zimmermann
2021-04-29 10:51   ` [Intel-gfx] " Thomas Zimmermann
2021-04-29 16:58 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: Move struct drm_device.pdev to legacy (rev8) Patchwork
2021-04-29 17:26 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-04-29 20:28 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210429105101.25667-1-tzimmermann@suse.de \
    --to=tzimmermann@suse.de \
    --cc=airlied@linux.ie \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.