From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> To: qemu-devel@nongnu.org, groug@kaod.org, jose.carlos.venegas.munoz@intel.com, ma.mandourr@gmail.com Cc: virtio-fs@redhat.com, vgoyal@redhat.com, stefanha@redhat.com Subject: [PULL 08/12] virtiofsd: Changed allocations of fuse_session to GLib's functions Date: Thu, 6 May 2021 19:56:37 +0100 [thread overview] Message-ID: <20210506185641.284821-9-dgilbert@redhat.com> (raw) In-Reply-To: <20210506185641.284821-1-dgilbert@redhat.com> From: Mahmoud Mandour <ma.mandourr@gmail.com> Replaced the allocation and deallocation of fuse_session structs from calloc() and free() calls to g_try_new0() and g_free(). Signed-off-by: Mahmoud Mandour <ma.mandourr@gmail.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Message-Id: <20210420154643.58439-4-ma.mandourr@gmail.com> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> --- tools/virtiofsd/fuse_lowlevel.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/virtiofsd/fuse_lowlevel.c b/tools/virtiofsd/fuse_lowlevel.c index 88496f9560..7fe2cef1eb 100644 --- a/tools/virtiofsd/fuse_lowlevel.c +++ b/tools/virtiofsd/fuse_lowlevel.c @@ -2470,7 +2470,7 @@ void fuse_session_destroy(struct fuse_session *se) free(se->vu_socket_path); se->vu_socket_path = NULL; - free(se); + g_free(se); } @@ -2493,7 +2493,7 @@ struct fuse_session *fuse_session_new(struct fuse_args *args, return NULL; } - se = (struct fuse_session *)calloc(1, sizeof(struct fuse_session)); + se = g_try_new0(struct fuse_session, 1); if (se == NULL) { fuse_log(FUSE_LOG_ERR, "fuse: failed to allocate fuse object\n"); goto out1; @@ -2553,7 +2553,7 @@ struct fuse_session *fuse_session_new(struct fuse_args *args, out4: fuse_opt_free_args(args); out2: - free(se); + g_free(se); out1: return NULL; } -- 2.31.1
WARNING: multiple messages have this Message-ID (diff)
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> To: qemu-devel@nongnu.org, groug@kaod.org, jose.carlos.venegas.munoz@intel.com, ma.mandourr@gmail.com Cc: virtio-fs@redhat.com, vgoyal@redhat.com Subject: [Virtio-fs] [PULL 08/12] virtiofsd: Changed allocations of fuse_session to GLib's functions Date: Thu, 6 May 2021 19:56:37 +0100 [thread overview] Message-ID: <20210506185641.284821-9-dgilbert@redhat.com> (raw) In-Reply-To: <20210506185641.284821-1-dgilbert@redhat.com> From: Mahmoud Mandour <ma.mandourr@gmail.com> Replaced the allocation and deallocation of fuse_session structs from calloc() and free() calls to g_try_new0() and g_free(). Signed-off-by: Mahmoud Mandour <ma.mandourr@gmail.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Message-Id: <20210420154643.58439-4-ma.mandourr@gmail.com> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> --- tools/virtiofsd/fuse_lowlevel.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/virtiofsd/fuse_lowlevel.c b/tools/virtiofsd/fuse_lowlevel.c index 88496f9560..7fe2cef1eb 100644 --- a/tools/virtiofsd/fuse_lowlevel.c +++ b/tools/virtiofsd/fuse_lowlevel.c @@ -2470,7 +2470,7 @@ void fuse_session_destroy(struct fuse_session *se) free(se->vu_socket_path); se->vu_socket_path = NULL; - free(se); + g_free(se); } @@ -2493,7 +2493,7 @@ struct fuse_session *fuse_session_new(struct fuse_args *args, return NULL; } - se = (struct fuse_session *)calloc(1, sizeof(struct fuse_session)); + se = g_try_new0(struct fuse_session, 1); if (se == NULL) { fuse_log(FUSE_LOG_ERR, "fuse: failed to allocate fuse object\n"); goto out1; @@ -2553,7 +2553,7 @@ struct fuse_session *fuse_session_new(struct fuse_args *args, out4: fuse_opt_free_args(args); out2: - free(se); + g_free(se); out1: return NULL; } -- 2.31.1
next prev parent reply other threads:[~2021-05-06 19:07 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-06 18:56 [PULL 00/12] virtiofs queue Dr. David Alan Gilbert (git) 2021-05-06 18:56 ` [Virtio-fs] " Dr. David Alan Gilbert (git) 2021-05-06 18:56 ` [PULL 01/12] virtiofsd: Fix side-effect in assert() Dr. David Alan Gilbert (git) 2021-05-06 18:56 ` [Virtio-fs] " Dr. David Alan Gilbert (git) 2021-05-06 19:11 ` Edward McClanahan 2021-05-06 18:56 ` [PULL 02/12] virtiofsd: Allow use "-o xattrmap" without "-o xattr" Dr. David Alan Gilbert (git) 2021-05-06 18:56 ` [Virtio-fs] " Dr. David Alan Gilbert (git) 2021-05-06 18:56 ` [PULL 03/12] virtiofsd: Add help for -o xattr-mapping Dr. David Alan Gilbert (git) 2021-05-06 18:56 ` [Virtio-fs] " Dr. David Alan Gilbert (git) 2021-05-06 18:56 ` [PULL 04/12] virtiofs: Fixup printf args Dr. David Alan Gilbert (git) 2021-05-06 18:56 ` [Virtio-fs] " Dr. David Alan Gilbert (git) 2021-05-06 18:56 ` [PULL 05/12] virtiofsd: Don't assume header layout Dr. David Alan Gilbert (git) 2021-05-06 18:56 ` [Virtio-fs] " Dr. David Alan Gilbert (git) 2021-05-06 18:56 ` [PULL 06/12] virtiofsd: Changed allocations of fuse_req to GLib functions Dr. David Alan Gilbert (git) 2021-05-06 18:56 ` [Virtio-fs] " Dr. David Alan Gilbert (git) 2021-05-06 18:56 ` [PULL 07/12] virtiofsd: Changed allocations of iovec to GLib's functions Dr. David Alan Gilbert (git) 2021-05-06 18:56 ` [Virtio-fs] " Dr. David Alan Gilbert (git) 2021-05-06 18:56 ` Dr. David Alan Gilbert (git) [this message] 2021-05-06 18:56 ` [Virtio-fs] [PULL 08/12] virtiofsd: Changed allocations of fuse_session " Dr. David Alan Gilbert (git) 2021-05-06 18:56 ` [PULL 09/12] virtiofsd: Changed allocation of lo_map_elems " Dr. David Alan Gilbert (git) 2021-05-06 18:56 ` [Virtio-fs] " Dr. David Alan Gilbert (git) 2021-05-06 18:56 ` [PULL 10/12] virtiofsd: Changed allocations of fv_VuDev & its internals to GLib functions Dr. David Alan Gilbert (git) 2021-05-06 18:56 ` [Virtio-fs] " Dr. David Alan Gilbert (git) 2021-05-06 18:56 ` [PULL 11/12] virtiofsd/passthrough_ll.c: Changed local allocations " Dr. David Alan Gilbert (git) 2021-05-06 18:56 ` [Virtio-fs] " Dr. David Alan Gilbert (git) 2021-05-06 18:56 ` [PULL 12/12] virtiofsd/fuse_virtio.c: Changed allocations of locals to GLib Dr. David Alan Gilbert (git) 2021-05-06 18:56 ` [Virtio-fs] " Dr. David Alan Gilbert (git) 2021-05-11 15:05 ` [PULL 00/12] virtiofs queue Peter Maydell 2021-05-11 15:05 ` [Virtio-fs] " Peter Maydell
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210506185641.284821-9-dgilbert@redhat.com \ --to=dgilbert@redhat.com \ --cc=groug@kaod.org \ --cc=jose.carlos.venegas.munoz@intel.com \ --cc=ma.mandourr@gmail.com \ --cc=qemu-devel@nongnu.org \ --cc=stefanha@redhat.com \ --cc=vgoyal@redhat.com \ --cc=virtio-fs@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.