From: kernel test robot <lkp@intel.com> To: Ben Gardon <bgardon@google.com>, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: kbuild-all@lists.01.org, Paolo Bonzini <pbonzini@redhat.com>, Peter Xu <peterx@redhat.com>, Sean Christopherson <seanjc@google.com>, Peter Shier <pshier@google.com>, Yulei Zhang <yulei.kernel@gmail.com>, Wanpeng Li <kernellwp@gmail.com>, Xiao Guangrong <xiaoguangrong.eric@gmail.com>, Kai Huang <kai.huang@intel.com> Subject: Re: [PATCH v3 7/8] KVM: x86/mmu: Protect rmaps independently with SRCU Date: Fri, 7 May 2021 07:58:54 +0800 [thread overview] Message-ID: <202105070704.q3RA348X-lkp@intel.com> (raw) In-Reply-To: <20210506184241.618958-8-bgardon@google.com> [-- Attachment #1: Type: text/plain, Size: 4224 bytes --] Hi Ben, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on kvm/queue] [also build test WARNING on tip/master linus/master next-20210506] [cannot apply to linux/master v5.12] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Ben-Gardon/Lazily-allocate-memslot-rmaps/20210507-024533 base: https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue config: x86_64-randconfig-s021-20210506 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-341-g8af24329-dirty # https://github.com/0day-ci/linux/commit/dd56af97c1d2b22f9acd46d33c83ac5e7bf67acc git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Ben-Gardon/Lazily-allocate-memslot-rmaps/20210507-024533 git checkout dd56af97c1d2b22f9acd46d33c83ac5e7bf67acc # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> sparse warnings: (new ones prefixed by >>) >> arch/x86/kvm/mmu/mmu.c:938:16: sparse: sparse: incompatible types in comparison expression (different address spaces): >> arch/x86/kvm/mmu/mmu.c:938:16: sparse: struct kvm_rmap_head [noderef] __rcu * >> arch/x86/kvm/mmu/mmu.c:938:16: sparse: struct kvm_rmap_head * arch/x86/kvm/mmu/mmu.c: note: in included file (through include/linux/kvm_host.h, arch/x86/kvm/irq.h): arch/x86/include/asm/kvm_host.h:1871:36: sparse: sparse: marked inline, but without a definition arch/x86/include/asm/kvm_host.h:1871:36: sparse: sparse: marked inline, but without a definition arch/x86/include/asm/kvm_host.h:1871:36: sparse: sparse: marked inline, but without a definition arch/x86/include/asm/kvm_host.h:1871:36: sparse: sparse: marked inline, but without a definition arch/x86/include/asm/kvm_host.h:1871:36: sparse: sparse: marked inline, but without a definition arch/x86/include/asm/kvm_host.h:1871:36: sparse: sparse: marked inline, but without a definition arch/x86/include/asm/kvm_host.h:1871:36: sparse: sparse: marked inline, but without a definition arch/x86/include/asm/kvm_host.h:1871:36: sparse: sparse: marked inline, but without a definition arch/x86/include/asm/kvm_host.h:1871:36: sparse: sparse: marked inline, but without a definition arch/x86/include/asm/kvm_host.h:1871:36: sparse: sparse: marked inline, but without a definition arch/x86/include/asm/kvm_host.h:1871:36: sparse: sparse: marked inline, but without a definition arch/x86/include/asm/kvm_host.h:1871:36: sparse: sparse: marked inline, but without a definition arch/x86/include/asm/kvm_host.h:1871:36: sparse: sparse: marked inline, but without a definition -- arch/x86/kvm/x86.c:10926:17: sparse: sparse: incompatible types in comparison expression (different address spaces): >> arch/x86/kvm/x86.c:10926:17: sparse: struct kvm_rmap_head [noderef] __rcu * >> arch/x86/kvm/x86.c:10926:17: sparse: struct kvm_rmap_head * arch/x86/kvm/x86.c: note: in included file (through include/linux/notifier.h, include/linux/memory_hotplug.h, include/linux/mmzone.h, ...): include/linux/srcu.h:182:9: sparse: sparse: context imbalance in 'vcpu_enter_guest' - unexpected unlock vim +938 arch/x86/kvm/mmu/mmu.c 929 930 static struct kvm_rmap_head *__gfn_to_rmap(struct kvm *kvm, gfn_t gfn, 931 int level, 932 struct kvm_memory_slot *slot) 933 { 934 struct kvm_rmap_head *head; 935 unsigned long idx; 936 937 idx = gfn_to_index(gfn, slot->base_gfn, level); > 938 head = srcu_dereference_check(slot->arch.rmap[level - PG_LEVEL_4K], 939 &kvm->srcu, 940 lockdep_is_held(&kvm->slots_arch_lock)); 941 return &head[idx]; 942 } 943 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 38255 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH v3 7/8] KVM: x86/mmu: Protect rmaps independently with SRCU Date: Fri, 07 May 2021 07:58:54 +0800 [thread overview] Message-ID: <202105070704.q3RA348X-lkp@intel.com> (raw) In-Reply-To: <20210506184241.618958-8-bgardon@google.com> [-- Attachment #1: Type: text/plain, Size: 4301 bytes --] Hi Ben, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on kvm/queue] [also build test WARNING on tip/master linus/master next-20210506] [cannot apply to linux/master v5.12] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Ben-Gardon/Lazily-allocate-memslot-rmaps/20210507-024533 base: https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue config: x86_64-randconfig-s021-20210506 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-341-g8af24329-dirty # https://github.com/0day-ci/linux/commit/dd56af97c1d2b22f9acd46d33c83ac5e7bf67acc git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Ben-Gardon/Lazily-allocate-memslot-rmaps/20210507-024533 git checkout dd56af97c1d2b22f9acd46d33c83ac5e7bf67acc # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> sparse warnings: (new ones prefixed by >>) >> arch/x86/kvm/mmu/mmu.c:938:16: sparse: sparse: incompatible types in comparison expression (different address spaces): >> arch/x86/kvm/mmu/mmu.c:938:16: sparse: struct kvm_rmap_head [noderef] __rcu * >> arch/x86/kvm/mmu/mmu.c:938:16: sparse: struct kvm_rmap_head * arch/x86/kvm/mmu/mmu.c: note: in included file (through include/linux/kvm_host.h, arch/x86/kvm/irq.h): arch/x86/include/asm/kvm_host.h:1871:36: sparse: sparse: marked inline, but without a definition arch/x86/include/asm/kvm_host.h:1871:36: sparse: sparse: marked inline, but without a definition arch/x86/include/asm/kvm_host.h:1871:36: sparse: sparse: marked inline, but without a definition arch/x86/include/asm/kvm_host.h:1871:36: sparse: sparse: marked inline, but without a definition arch/x86/include/asm/kvm_host.h:1871:36: sparse: sparse: marked inline, but without a definition arch/x86/include/asm/kvm_host.h:1871:36: sparse: sparse: marked inline, but without a definition arch/x86/include/asm/kvm_host.h:1871:36: sparse: sparse: marked inline, but without a definition arch/x86/include/asm/kvm_host.h:1871:36: sparse: sparse: marked inline, but without a definition arch/x86/include/asm/kvm_host.h:1871:36: sparse: sparse: marked inline, but without a definition arch/x86/include/asm/kvm_host.h:1871:36: sparse: sparse: marked inline, but without a definition arch/x86/include/asm/kvm_host.h:1871:36: sparse: sparse: marked inline, but without a definition arch/x86/include/asm/kvm_host.h:1871:36: sparse: sparse: marked inline, but without a definition arch/x86/include/asm/kvm_host.h:1871:36: sparse: sparse: marked inline, but without a definition -- arch/x86/kvm/x86.c:10926:17: sparse: sparse: incompatible types in comparison expression (different address spaces): >> arch/x86/kvm/x86.c:10926:17: sparse: struct kvm_rmap_head [noderef] __rcu * >> arch/x86/kvm/x86.c:10926:17: sparse: struct kvm_rmap_head * arch/x86/kvm/x86.c: note: in included file (through include/linux/notifier.h, include/linux/memory_hotplug.h, include/linux/mmzone.h, ...): include/linux/srcu.h:182:9: sparse: sparse: context imbalance in 'vcpu_enter_guest' - unexpected unlock vim +938 arch/x86/kvm/mmu/mmu.c 929 930 static struct kvm_rmap_head *__gfn_to_rmap(struct kvm *kvm, gfn_t gfn, 931 int level, 932 struct kvm_memory_slot *slot) 933 { 934 struct kvm_rmap_head *head; 935 unsigned long idx; 936 937 idx = gfn_to_index(gfn, slot->base_gfn, level); > 938 head = srcu_dereference_check(slot->arch.rmap[level - PG_LEVEL_4K], 939 &kvm->srcu, 940 lockdep_is_held(&kvm->slots_arch_lock)); 941 return &head[idx]; 942 } 943 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 38255 bytes --]
next prev parent reply other threads:[~2021-05-06 23:59 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-06 18:42 [PATCH v3 0/8] Lazily allocate memslot rmaps Ben Gardon 2021-05-06 18:42 ` [PATCH v3 1/8] KVM: x86/mmu: Deduplicate rmap freeing Ben Gardon 2021-05-07 7:42 ` David Hildenbrand 2021-05-06 18:42 ` [PATCH v3 2/8] KVM: x86/mmu: Factor out allocating memslot rmap Ben Gardon 2021-05-07 7:46 ` David Hildenbrand 2021-05-10 16:29 ` Ben Gardon 2021-05-06 18:42 ` [PATCH v3 3/8] KVM: mmu: Refactor memslot copy Ben Gardon 2021-05-07 7:48 ` David Hildenbrand 2021-05-06 18:42 ` [PATCH v3 4/8] KVM: mmu: Add slots_arch_lock for memslot arch fields Ben Gardon 2021-05-06 18:42 ` [PATCH v3 5/8] KVM: x86/mmu: Add a field to control memslot rmap allocation Ben Gardon 2021-05-06 23:44 ` Ben Gardon 2021-05-07 7:50 ` David Hildenbrand 2021-05-07 8:28 ` Paolo Bonzini 2021-05-10 16:14 ` Ben Gardon 2021-05-10 16:33 ` Paolo Bonzini 2021-05-10 16:37 ` Ben Gardon 2021-05-06 18:42 ` [PATCH v3 6/8] KVM: x86/mmu: Skip rmap operations if rmaps not allocated Ben Gardon 2021-05-06 23:07 ` kernel test robot 2021-05-06 23:07 ` kernel test robot 2021-05-06 18:42 ` [PATCH v3 7/8] KVM: x86/mmu: Protect rmaps independently with SRCU Ben Gardon 2021-05-06 23:58 ` kernel test robot [this message] 2021-05-06 23:58 ` kernel test robot 2021-05-07 0:56 ` kernel test robot 2021-05-07 0:56 ` kernel test robot 2021-05-07 8:42 ` Paolo Bonzini 2021-05-10 17:45 ` Sean Christopherson 2021-05-10 17:53 ` Paolo Bonzini 2021-05-10 18:28 ` Sean Christopherson 2021-05-11 16:22 ` Ben Gardon 2021-05-11 16:45 ` Paolo Bonzini 2021-05-06 18:42 ` [PATCH v3 8/8] KVM: x86/mmu: Lazily allocate memslot rmaps Ben Gardon 2021-05-07 1:10 ` kernel test robot 2021-05-07 1:10 ` kernel test robot 2021-05-07 8:28 ` Paolo Bonzini 2021-05-07 7:40 ` [PATCH v3 0/8] " David Hildenbrand
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202105070704.q3RA348X-lkp@intel.com \ --to=lkp@intel.com \ --cc=bgardon@google.com \ --cc=kai.huang@intel.com \ --cc=kbuild-all@lists.01.org \ --cc=kernellwp@gmail.com \ --cc=kvm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=pbonzini@redhat.com \ --cc=peterx@redhat.com \ --cc=pshier@google.com \ --cc=seanjc@google.com \ --cc=xiaoguangrong.eric@gmail.com \ --cc=yulei.kernel@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.