All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH v9 05/10] regulator: IRQ based event/error notification helpers
Date: Mon, 10 May 2021 22:30:47 +0800	[thread overview]
Message-ID: <202105102231.rNWqL74r-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 4177 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <a22cf56239512f52ae5927f226e79d890d7a1240.1620645507.git.matti.vaittinen@fi.rohmeurope.com>
References: <a22cf56239512f52ae5927f226e79d890d7a1240.1620645507.git.matti.vaittinen@fi.rohmeurope.com>
TO: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>, Matti Vaittinen <mazziesaccount@gmail.com>
TO: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>, Matti Vaittinen <mazziesaccount@gmail.com>
CC: Mark Brown <broonie@kernel.org>
CC: Kees Cook <keescook@chromium.org>
CC: Andy Shevchenko <andy.shevchenko@gmail.com>
CC: Zhang Rui <rui.zhang@intel.com>
CC: Guenter Roeck <linux@roeck-us.net>
CC: "agross(a)kernel.org" <agross@kernel.org>
CC: "devicetree(a)vger.kernel.org" <devicetree@vger.kernel.org>
CC: "linux-power" <linux-power@fi.rohmeurope.com>
CC: "linux-kernel(a)vger.kernel.org" <linux-kernel@vger.kernel.org>

Hi Matti,

I love your patch! Perhaps something to improve:

[auto build test WARNING on 6efb943b8616ec53a5e444193dccf1af9ad627b5]

url:    https://github.com/0day-ci/linux/commits/Matti-Vaittinen/Extend-regulator-notification-support/20210510-203125
base:   6efb943b8616ec53a5e444193dccf1af9ad627b5
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago
config: i386-randconfig-s002-20210510 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-341-g8af24329-dirty
        # https://github.com/0day-ci/linux/commit/904edb46fa37ac86bc1e7a1629141e037f45ebed
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Matti-Vaittinen/Extend-regulator-notification-support/20210510-203125
        git checkout 904edb46fa37ac86bc1e7a1629141e037f45ebed
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/kernel.h:12,
                    from arch/x86/include/asm/percpu.h:27,
                    from arch/x86/include/asm/current.h:6,
                    from include/linux/sched.h:12,
                    from include/linux/ratelimit.h:6,
                    from include/linux/dev_printk.h:16,
                    from include/linux/device.h:15,
                    from drivers/regulator/irq_helpers.c:10:
   drivers/regulator/irq_helpers.c: In function 'regulator_notifier_isr':
>> include/linux/bitops.h:35:2: warning: this 'for' clause does not guard... [-Wmisleading-indentation]
      35 |  for ((bit) = find_first_bit((addr), (size));  \
         |  ^~~
   drivers/regulator/irq_helpers.c:242:3: note: in expansion of macro 'for_each_set_bit'
     242 |   for_each_set_bit(j, &stat->notifs, BITS_PER_TYPE(stat->notifs))
         |   ^~~~~~~~~~~~~~~~
   drivers/regulator/irq_helpers.c:244:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'for'
     244 |    pr_dbg("Sending regulator notification EVT 0x%lx\r\n",
         |    ^~~~~~
   drivers/regulator/irq_helpers.c:244:4: error: implicit declaration of function 'pr_dbg'; did you mean 'pr_debug'? [-Werror=implicit-function-declaration]
     244 |    pr_dbg("Sending regulator notification EVT 0x%lx\r\n",
         |    ^~~~~~
         |    pr_debug
   cc1: some warnings being treated as errors


vim +/for +35 include/linux/bitops.h

^1da177e4c3f41 Linus Torvalds 2005-04-16  33  
984b3f5746ed2c Akinobu Mita   2010-03-05  34  #define for_each_set_bit(bit, addr, size) \
3e037454bcfa4b Shannon Nelson 2007-10-16 @35  	for ((bit) = find_first_bit((addr), (size));		\
3e037454bcfa4b Shannon Nelson 2007-10-16  36  	     (bit) < (size);					\
3e037454bcfa4b Shannon Nelson 2007-10-16  37  	     (bit) = find_next_bit((addr), (size), (bit) + 1))
3e037454bcfa4b Shannon Nelson 2007-10-16  38  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34105 bytes --]

             reply	other threads:[~2021-05-10 14:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-10 14:30 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-05-10 11:26 [PATCH v9 00/10] Extend regulator notification support Matti Vaittinen
2021-05-10 11:29 ` [PATCH v9 05/10] regulator: IRQ based event/error notification helpers Matti Vaittinen
2021-05-10 17:35   ` kernel test robot
2021-05-10 17:35     ` kernel test robot
2021-05-10 20:15     ` Andy Shevchenko
2021-05-10 20:15       ` Andy Shevchenko
2021-05-10 19:45   ` kernel test robot
2021-05-10 19:45     ` kernel test robot
2021-05-10 20:20     ` Andy Shevchenko
2021-05-10 20:20       ` Andy Shevchenko
2021-05-11  3:24       ` Matti Vaittinen
2021-05-11  3:24         ` Matti Vaittinen
2021-05-11  4:54   ` Matti Vaittinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202105102231.rNWqL74r-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.