From: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
kernel test robot <lkp@intel.com>
Cc: kbuild-all@lists.01.org, Mark Brown <broonie@kernel.org>,
Kees Cook <keescook@chromium.org>,
Zhang Rui <rui.zhang@intel.com>,
Guenter Roeck <linux@roeck-us.net>,
"agross@kernel.org" <agross@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-power <linux-power@fi.rohmeurope.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v9 05/10] regulator: IRQ based event/error notification helpers
Date: Tue, 11 May 2021 06:24:32 +0300 [thread overview]
Message-ID: <6121a55d7db8cc4376c068e289fb29b9d4479dbd.camel@fi.rohmeurope.com> (raw)
In-Reply-To: <CAHp75Vfw+5R-qN+iGC4hYSbL6phOoSZ7nuNsyroQPODxEmMaNA@mail.gmail.com>
Hi Andy, All,
On Mon, 2021-05-10 at 23:20 +0300, Andy Shevchenko wrote:
> On Mon, May 10, 2021 at 10:46 PM kernel test robot <lkp@intel.com>
> wrote:
> >
> > include/linux/bitops.h:35:2: warning: this 'for' clause does not
> > guard... [-Wmisleading-indentation]
> > 35 | for ((bit) = find_first_bit((addr), (size)); \
> > | ^~~
> > drivers/regulator/irq_helpers.c:242:3: note: in expansion of
> > macro 'for_each_set_bit'
> > 242 | for_each_set_bit(j, &stat->notifs, BITS_PER_TYPE(stat-
> > >notifs))
> > | ^~~~~~~~~~~~~~~~
> > drivers/regulator/irq_helpers.c:244:4: note: ...this statement,
> > but the latter is misleadingly indented as if it were guarded by
> > the 'for'
>
> Seems like missed {}
>
> Matti, there is a serious question: how had you tested this...
I actually did. I did not just run rebase for the series and threw new
version but I actually did run this in real HW, with real break-out
board and with a fresh info print to see the event being sent.
> (besides obvious compilation error)
> Perhaps you have to fix your process somewhere to avoid missing
> important steps?
Yes. Can't deny this. And process fix should be simple. If code/patch
needs a change (even a print removal/print severity change/parameter
change) - then it needs to be tested again prior formatting the
patches.
Sorry folks.
--Matti
WARNING: multiple messages have this Message-ID (diff)
From: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v9 05/10] regulator: IRQ based event/error notification helpers
Date: Tue, 11 May 2021 06:24:32 +0300 [thread overview]
Message-ID: <6121a55d7db8cc4376c068e289fb29b9d4479dbd.camel@fi.rohmeurope.com> (raw)
In-Reply-To: <CAHp75Vfw+5R-qN+iGC4hYSbL6phOoSZ7nuNsyroQPODxEmMaNA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1422 bytes --]
Hi Andy, All,
On Mon, 2021-05-10 at 23:20 +0300, Andy Shevchenko wrote:
> On Mon, May 10, 2021 at 10:46 PM kernel test robot <lkp@intel.com>
> wrote:
> >
> > include/linux/bitops.h:35:2: warning: this 'for' clause does not
> > guard... [-Wmisleading-indentation]
> > 35 | for ((bit) = find_first_bit((addr), (size)); \
> > | ^~~
> > drivers/regulator/irq_helpers.c:242:3: note: in expansion of
> > macro 'for_each_set_bit'
> > 242 | for_each_set_bit(j, &stat->notifs, BITS_PER_TYPE(stat-
> > >notifs))
> > | ^~~~~~~~~~~~~~~~
> > drivers/regulator/irq_helpers.c:244:4: note: ...this statement,
> > but the latter is misleadingly indented as if it were guarded by
> > the 'for'
>
> Seems like missed {}
>
> Matti, there is a serious question: how had you tested this...
I actually did. I did not just run rebase for the series and threw new
version but I actually did run this in real HW, with real break-out
board and with a fresh info print to see the event being sent.
> (besides obvious compilation error)
> Perhaps you have to fix your process somewhere to avoid missing
> important steps?
Yes. Can't deny this. And process fix should be simple. If code/patch
needs a change (even a print removal/print severity change/parameter
change) - then it needs to be tested again prior formatting the
patches.
Sorry folks.
--Matti
next prev parent reply other threads:[~2021-05-11 3:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 11:26 [PATCH v9 00/10] Extend regulator notification support Matti Vaittinen
2021-05-10 11:27 ` [PATCH v9 01/10] dt_bindings: Add protection limit properties Matti Vaittinen
2021-05-10 11:28 ` [PATCH v9 02/10] reboot: Add hardware protection power-off Matti Vaittinen
2021-05-12 8:20 ` Petr Mladek
2021-05-12 12:00 ` Vaittinen, Matti
2021-05-13 8:34 ` Petr Mladek
2021-05-17 4:57 ` Matti Vaittinen
2021-05-10 11:29 ` [PATCH v9 03/10] thermal: Use generic HW-protection shutdown API Matti Vaittinen
2021-05-10 11:29 ` [PATCH v9 04/10] regulator: add warning flags Matti Vaittinen
2021-05-10 11:29 ` [PATCH v9 05/10] regulator: IRQ based event/error notification helpers Matti Vaittinen
2021-05-10 17:35 ` kernel test robot
2021-05-10 17:35 ` kernel test robot
2021-05-10 20:15 ` Andy Shevchenko
2021-05-10 20:15 ` Andy Shevchenko
2021-05-10 19:45 ` kernel test robot
2021-05-10 19:45 ` kernel test robot
2021-05-10 20:20 ` Andy Shevchenko
2021-05-10 20:20 ` Andy Shevchenko
2021-05-11 3:24 ` Matti Vaittinen [this message]
2021-05-11 3:24 ` Matti Vaittinen
2021-05-11 4:54 ` Matti Vaittinen
2021-05-10 11:30 ` [PATCH v9 06/10] regulator: add property parsing and callbacks to set protection limits Matti Vaittinen
2021-05-10 11:30 ` [PATCH v9 07/10] dt-bindings: regulator: bd9576 add FET ON-resistance for OCW Matti Vaittinen
2021-05-10 11:30 ` [PATCH v9 08/10] regulator: bd9576: Support error reporting Matti Vaittinen
2021-05-10 11:31 ` [PATCH v9 09/10] regulator: bd9576: Fix the driver name in id table Matti Vaittinen
2021-05-10 11:31 ` [PATCH v9 10/10] MAINTAINERS: Add reviewer for regulator irq_helpers Matti Vaittinen
2021-05-10 14:30 [PATCH v9 05/10] regulator: IRQ based event/error notification helpers kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6121a55d7db8cc4376c068e289fb29b9d4479dbd.camel@fi.rohmeurope.com \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=agross@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-power@fi.rohmeurope.com \
--cc=linux@roeck-us.net \
--cc=lkp@intel.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.