All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Hilber <peter.hilber@opensynergy.com>
To: <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>
Cc: Peter Hilber <peter.hilber@opensynergy.com>,
	Rob Herring <robh+dt@kernel.org>, <linux-kernel@vger.kernel.org>,
	<sudeep.holla@arm.com>, <souvik.chakravarty@arm.com>,
	<alex.bennee@linaro.org>, <jean-philippe@linaro.org>,
	<igor.skalkin@opensynergy.com>, <mikhail.golubev@opensynergy.com>,
	<anton.yakovlev@opensynergy.com>,
	Vasyl Vavrychuk <Vasyl.Vavrychuk@opensynergy.com>,
	Andriy Tryshnivskyy <Andriy.Tryshnivskyy@opensynergy.com>,
	Cristian Marussi <cristian.marussi@arm.com>
Subject: [RFC PATCH v3 08/12] firmware: arm_scmi: Add optional drop_message() transport op
Date: Tue, 11 May 2021 02:20:36 +0200	[thread overview]
Message-ID: <20210511002040.802226-9-peter.hilber@opensynergy.com> (raw)
In-Reply-To: <20210511002040.802226-1-peter.hilber@opensynergy.com>

The virtio transport will need to know when the core has finished using
a message. Add a transport op that indicates this to scmi_rx_callback().
Do not address the polling case for now.

Signed-off-by: Peter Hilber <peter.hilber@opensynergy.com>
---
 drivers/firmware/arm_scmi/common.h | 2 ++
 drivers/firmware/arm_scmi/driver.c | 4 ++++
 2 files changed, 6 insertions(+)

diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi/common.h
index 5ab2ea0f7db2..51ee08bdcb0c 100644
--- a/drivers/firmware/arm_scmi/common.h
+++ b/drivers/firmware/arm_scmi/common.h
@@ -298,6 +298,7 @@ struct scmi_chan_info {
  * @fetch_notification: Callback to fetch notification
  * @clear_channel: Callback to clear a channel
  * @poll_done: Callback to poll transfer status
+ * @drop_message: Optional callback when finished using msg_handle
  */
 struct scmi_transport_ops {
 	int (*link_supplier)(struct device *dev);
@@ -315,6 +316,7 @@ struct scmi_transport_ops {
 				   struct scmi_xfer *xfer, void *msg_handle);
 	void (*clear_channel)(struct scmi_chan_info *cinfo);
 	bool (*poll_done)(struct scmi_chan_info *cinfo, struct scmi_xfer *xfer);
+	void (*drop_message)(struct scmi_chan_info *cinfo, void *msg_handle);
 };
 
 int scmi_protocol_device_request(const struct scmi_device_id *id_table);
diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
index cc27978b4bea..e04e7c8e6928 100644
--- a/drivers/firmware/arm_scmi/driver.c
+++ b/drivers/firmware/arm_scmi/driver.c
@@ -371,6 +371,7 @@ void scmi_rx_callback(struct scmi_chan_info *cinfo, u32 msg_hdr,
 {
 	u16 xfer_id = MSG_XTRACT_TOKEN(msg_hdr);
 	u8 msg_type = MSG_XTRACT_TYPE(msg_hdr);
+	struct scmi_info *info = handle_to_scmi_info(cinfo->handle);
 
 	switch (msg_type) {
 	case MSG_TYPE_NOTIFICATION:
@@ -384,6 +385,9 @@ void scmi_rx_callback(struct scmi_chan_info *cinfo, u32 msg_hdr,
 		WARN_ONCE(1, "received unknown msg_type:%d\n", msg_type);
 		break;
 	}
+
+	if (info->desc->ops->drop_message)
+		info->desc->ops->drop_message(cinfo, msg_handle);
 }
 
 /**
-- 
2.25.1



WARNING: multiple messages have this Message-ID (diff)
From: Peter Hilber <peter.hilber@opensynergy.com>
To: <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>
Cc: Peter Hilber <peter.hilber@opensynergy.com>,
	Rob Herring <robh+dt@kernel.org>, <linux-kernel@vger.kernel.org>,
	<sudeep.holla@arm.com>,  <souvik.chakravarty@arm.com>,
	<alex.bennee@linaro.org>, <jean-philippe@linaro.org>,
	<igor.skalkin@opensynergy.com>, <mikhail.golubev@opensynergy.com>,
	<anton.yakovlev@opensynergy.com>,
	Vasyl Vavrychuk <Vasyl.Vavrychuk@opensynergy.com>,
	Andriy Tryshnivskyy <Andriy.Tryshnivskyy@opensynergy.com>,
	Cristian Marussi <cristian.marussi@arm.com>
Subject: [RFC PATCH v3 08/12] firmware: arm_scmi: Add optional drop_message() transport op
Date: Tue, 11 May 2021 02:20:36 +0200	[thread overview]
Message-ID: <20210511002040.802226-9-peter.hilber@opensynergy.com> (raw)
In-Reply-To: <20210511002040.802226-1-peter.hilber@opensynergy.com>

The virtio transport will need to know when the core has finished using
a message. Add a transport op that indicates this to scmi_rx_callback().
Do not address the polling case for now.

Signed-off-by: Peter Hilber <peter.hilber@opensynergy.com>
---
 drivers/firmware/arm_scmi/common.h | 2 ++
 drivers/firmware/arm_scmi/driver.c | 4 ++++
 2 files changed, 6 insertions(+)

diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi/common.h
index 5ab2ea0f7db2..51ee08bdcb0c 100644
--- a/drivers/firmware/arm_scmi/common.h
+++ b/drivers/firmware/arm_scmi/common.h
@@ -298,6 +298,7 @@ struct scmi_chan_info {
  * @fetch_notification: Callback to fetch notification
  * @clear_channel: Callback to clear a channel
  * @poll_done: Callback to poll transfer status
+ * @drop_message: Optional callback when finished using msg_handle
  */
 struct scmi_transport_ops {
 	int (*link_supplier)(struct device *dev);
@@ -315,6 +316,7 @@ struct scmi_transport_ops {
 				   struct scmi_xfer *xfer, void *msg_handle);
 	void (*clear_channel)(struct scmi_chan_info *cinfo);
 	bool (*poll_done)(struct scmi_chan_info *cinfo, struct scmi_xfer *xfer);
+	void (*drop_message)(struct scmi_chan_info *cinfo, void *msg_handle);
 };
 
 int scmi_protocol_device_request(const struct scmi_device_id *id_table);
diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
index cc27978b4bea..e04e7c8e6928 100644
--- a/drivers/firmware/arm_scmi/driver.c
+++ b/drivers/firmware/arm_scmi/driver.c
@@ -371,6 +371,7 @@ void scmi_rx_callback(struct scmi_chan_info *cinfo, u32 msg_hdr,
 {
 	u16 xfer_id = MSG_XTRACT_TOKEN(msg_hdr);
 	u8 msg_type = MSG_XTRACT_TYPE(msg_hdr);
+	struct scmi_info *info = handle_to_scmi_info(cinfo->handle);
 
 	switch (msg_type) {
 	case MSG_TYPE_NOTIFICATION:
@@ -384,6 +385,9 @@ void scmi_rx_callback(struct scmi_chan_info *cinfo, u32 msg_hdr,
 		WARN_ONCE(1, "received unknown msg_type:%d\n", msg_type);
 		break;
 	}
+
+	if (info->desc->ops->drop_message)
+		info->desc->ops->drop_message(cinfo, msg_handle);
 }
 
 /**
-- 
2.25.1



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-05-11  0:29 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11  0:20 [RFC PATCH v3 00/12] firmware: arm_scmi: Add virtio transport Peter Hilber
2021-05-11  0:20 ` [virtio-dev] " Peter Hilber
2021-05-11  0:20 ` Peter Hilber
2021-05-11  0:20 ` [RFC PATCH v3 01/12] firmware: arm_scmi, smccc, mailbox: Make shmem based transports optional Peter Hilber
2021-05-11  0:20   ` Peter Hilber
2021-06-21  4:09   ` Jassi Brar
2021-06-21  4:09     ` Jassi Brar
2021-06-21  8:54     ` Sudeep Holla
2021-06-21  8:54       ` Sudeep Holla
2021-06-21  9:01       ` Cristian Marussi
2021-06-21  9:01         ` Cristian Marussi
2021-05-11  0:20 ` [RFC PATCH v3 02/12] firmware: arm_scmi: Add transport init/deinit Peter Hilber
2021-05-11  0:20   ` Peter Hilber
2021-05-11  0:20 ` [RFC PATCH v3 03/12] firmware: arm_scmi: Add op to override max message # Peter Hilber
2021-05-11  0:20   ` Peter Hilber
2021-05-11  0:20 ` [RFC PATCH v3 04/12] firmware: arm_scmi: Add optional link_supplier() transport op Peter Hilber
2021-05-11  0:20   ` Peter Hilber
2021-05-11  0:20 ` [RFC PATCH v3 05/12] firmware: arm_scmi: Add per-device transport private info Peter Hilber
2021-05-11  0:20   ` Peter Hilber
2021-05-11  0:20 ` [RFC PATCH v3 06/12] firmware: arm_scmi: Add is_scmi_protocol_device() Peter Hilber
2021-05-11  0:20   ` Peter Hilber
2021-05-11  0:20 ` [RFC PATCH v3 07/12] firmware: arm_scmi: Add msg_handle to some transport ops Peter Hilber
2021-05-11  0:20   ` Peter Hilber
2021-05-11  0:20 ` Peter Hilber [this message]
2021-05-11  0:20   ` [RFC PATCH v3 08/12] firmware: arm_scmi: Add optional drop_message() transport op Peter Hilber
2021-05-11  0:20 ` [RFC PATCH v3 09/12] firmware: arm_scmi: Add message passing abstractions for transports Peter Hilber
2021-05-11  0:20   ` Peter Hilber
2021-05-11  0:20 ` [RFC PATCH v3 10/12] dt-bindings: arm: Add virtio transport for SCMI Peter Hilber
2021-05-11  0:20   ` [virtio-dev] " Peter Hilber
2021-05-11  0:20   ` Peter Hilber
2021-05-17 21:39   ` Rob Herring
2021-05-17 21:39     ` Rob Herring
2021-05-17 21:39     ` Rob Herring
2021-05-11  0:20 ` [RFC PATCH v3 11/12] firmware: arm_scmi: Add virtio transport Peter Hilber
2021-05-11  0:20   ` [virtio-dev] " Peter Hilber
2021-05-11  0:20   ` Peter Hilber
2021-05-18  8:08   ` Cristian Marussi
2021-05-18  8:08     ` Cristian Marussi
2021-05-26 14:40   ` Cristian Marussi
2021-05-26 14:40     ` Cristian Marussi
2021-06-04  9:19     ` Peter Hilber
2021-06-04  9:19       ` [virtio-dev] " Peter Hilber
2021-06-04  9:19       ` Peter Hilber
2021-06-04 11:56       ` Cristian Marussi
2021-06-04 11:56         ` Cristian Marussi
2021-06-01 14:53   ` Vincent Guittot
2021-06-01 14:53     ` Vincent Guittot
2021-06-02  8:25     ` Peter Hilber
2021-06-02  8:25       ` [virtio-dev] " Peter Hilber
2021-06-02  8:25       ` Peter Hilber
2021-06-02  8:33       ` Cristian Marussi
2021-06-02  8:33         ` Cristian Marussi
2021-06-02  8:34       ` Vincent Guittot
2021-06-02  8:34         ` Vincent Guittot
2021-05-11  0:20 ` [RFC PATCH v3 12/12] firmware: arm_scmi: Handle races between core and transport Peter Hilber
2021-05-11  0:20   ` Peter Hilber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210511002040.802226-9-peter.hilber@opensynergy.com \
    --to=peter.hilber@opensynergy.com \
    --cc=Andriy.Tryshnivskyy@opensynergy.com \
    --cc=Vasyl.Vavrychuk@opensynergy.com \
    --cc=alex.bennee@linaro.org \
    --cc=anton.yakovlev@opensynergy.com \
    --cc=cristian.marussi@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=igor.skalkin@opensynergy.com \
    --cc=jean-philippe@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikhail.golubev@opensynergy.com \
    --cc=robh+dt@kernel.org \
    --cc=souvik.chakravarty@arm.com \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.