From: Hyeonggon Yoo <42.hyeyoo@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Oliver Neukum <oneukum@suse.com>,
Vasily Khoruzhick <anarsoul@gmail.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] sound: line6: Fix race condition in line6_probe
Date: Tue, 18 May 2021 00:03:58 +0900 [thread overview]
Message-ID: <20210517150358.GB56459@hyeyoo> (raw)
In-Reply-To: <s5ha6oto1bb.wl-tiwai@suse.de>
On Mon, May 17, 2021 at 04:57:28PM +0200, Takashi Iwai wrote:
> Yes, there can be likely a few other holes in this driver, but for
> fixing them, we'd need an actual test device. The initialization
> procedure of this device seems complex (multi-staged) and very
> sensitive.
> Takashi
Yeap, this driver is so complex,
and I agree that we need actual device to test
if we do that big scale of refactoring.
Sadly I don't have one :(
Thanks,
Hyeonggon
WARNING: multiple messages have this Message-ID (diff)
From: Hyeonggon Yoo <42.hyeyoo@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Oliver Neukum <oneukum@suse.com>, Takashi Iwai <tiwai@suse.com>,
Vasily Khoruzhick <anarsoul@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] sound: line6: Fix race condition in line6_probe
Date: Tue, 18 May 2021 00:03:58 +0900 [thread overview]
Message-ID: <20210517150358.GB56459@hyeyoo> (raw)
In-Reply-To: <s5ha6oto1bb.wl-tiwai@suse.de>
On Mon, May 17, 2021 at 04:57:28PM +0200, Takashi Iwai wrote:
> Yes, there can be likely a few other holes in this driver, but for
> fixing them, we'd need an actual test device. The initialization
> procedure of this device seems complex (multi-staged) and very
> sensitive.
> Takashi
Yeap, this driver is so complex,
and I agree that we need actual device to test
if we do that big scale of refactoring.
Sadly I don't have one :(
Thanks,
Hyeonggon
next prev parent reply other threads:[~2021-05-17 16:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 13:27 [RFC PATCH] sound: line6: Fix race condition in line6_probe Hyeonggon Yoo
2021-05-17 13:43 ` Takashi Iwai
2021-05-17 13:43 ` Takashi Iwai
2021-05-17 14:48 ` Hyeonggon Yoo
2021-05-17 14:48 ` Hyeonggon Yoo
2021-05-17 14:57 ` Takashi Iwai
2021-05-17 14:57 ` Takashi Iwai
2021-05-17 15:03 ` Hyeonggon Yoo [this message]
2021-05-17 15:03 ` Hyeonggon Yoo
2021-05-17 14:56 ` Hyeonggon Yoo
2021-05-17 14:56 ` Hyeonggon Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210517150358.GB56459@hyeyoo \
--to=42.hyeyoo@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=anarsoul@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.