From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: James Schulman <james.schulman@cirrus.com>,
David Rhodes <david.rhodes@cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Paul Handrigan <Paul.Handrigan@cirrus.com>,
<alsa-devel@alsa-project.org>, <patches@opensource.cirrus.com>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] ASoC: cs35l33: fix an error code in probe()
Date: Thu, 20 May 2021 09:12:37 +0000 [thread overview]
Message-ID: <20210520091237.GI64205@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <YKXuyGEzhPT35R3G@mwanda>
On Thu, May 20, 2021 at 08:08:24AM +0300, Dan Carpenter wrote:
> This error path returns zero (success) but it should return -EINVAL.
>
> Fixes: 3333cb7187b9 ("ASoC: cs35l33: Initial commit of the cs35l33 CODEC driver.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
Good spot dude, sorry I missed that one in my recent fix ups.
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
WARNING: multiple messages have this Message-ID (diff)
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
patches@opensource.cirrus.com, kernel-janitors@vger.kernel.org,
Takashi Iwai <tiwai@suse.com>,
Paul Handrigan <Paul.Handrigan@cirrus.com>,
Mark Brown <broonie@kernel.org>,
James Schulman <james.schulman@cirrus.com>,
David Rhodes <david.rhodes@cirrus.com>
Subject: Re: [PATCH] ASoC: cs35l33: fix an error code in probe()
Date: Thu, 20 May 2021 09:12:37 +0000 [thread overview]
Message-ID: <20210520091237.GI64205@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <YKXuyGEzhPT35R3G@mwanda>
On Thu, May 20, 2021 at 08:08:24AM +0300, Dan Carpenter wrote:
> This error path returns zero (success) but it should return -EINVAL.
>
> Fixes: 3333cb7187b9 ("ASoC: cs35l33: Initial commit of the cs35l33 CODEC driver.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
Good spot dude, sorry I missed that one in my recent fix ups.
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
next prev parent reply other threads:[~2021-05-20 9:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 5:08 [PATCH] ASoC: cs35l33: fix an error code in probe() Dan Carpenter
2021-05-20 5:08 ` Dan Carpenter
2021-05-20 9:12 ` Charles Keepax [this message]
2021-05-20 9:12 ` Charles Keepax
2021-05-20 21:08 ` Mark Brown
2021-05-20 21:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210520091237.GI64205@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=Paul.Handrigan@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=david.rhodes@cirrus.com \
--cc=james.schulman@cirrus.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.