All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Matheus Castanho <msc@linux.ibm.com>
Cc: Florian Weimer <fweimer@redhat.com>,
	Matheus Castanho via Libc-alpha <libc-alpha@sourceware.org>,
	Nicholas Piggin <npiggin@gmail.com>,
	musl@lists.openwall.com, linux-api@vger.kernel.org,
	libc-dev@lists.llvm.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: Linux powerpc new system call instruction and ABI
Date: Fri, 21 May 2021 23:52:04 +0300	[thread overview]
Message-ID: <20210521205204.GA24309@altlinux.org> (raw)
In-Reply-To: <87eedz3li3.fsf@linux.ibm.com>

On Fri, May 21, 2021 at 05:00:36PM -0300, Matheus Castanho wrote:
> Florian Weimer <fweimer@redhat.com> writes:
> > * Matheus Castanho via Libc-alpha:
> >> From: Nicholas Piggin <npiggin@gmail.com>
> >> Subject: [PATCH 1/1] powerpc: Fix handling of scv return error codes
> >>
> >> When using scv on templated ASM syscalls, current code interprets any
> >> negative return value as error, but the only valid error codes are in
> >> the range -4095..-1 according to the ABI.
> >>
> >> Reviewed-by: Matheus Castanho <msc@linux.ibm.com>
> >
> > Please reference bug 27892 in the commit message.  I'd also appreciate a
> > backport to the 2.33 release branch (where you need to add NEWS manually
> > to add the bug reference).
> 
> No problem. [BZ #27892] appended to the commit title. I'll make sure to
> backport to 2.33 as well.

Could you also mention in the commit message that the change fixes
'signal.gen.test' strace test where it was observed initially?


-- 
ldv

WARNING: multiple messages have this Message-ID (diff)
From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Matheus Castanho <msc@linux.ibm.com>
Cc: Florian Weimer <fweimer@redhat.com>,
	Matheus Castanho via Libc-alpha <libc-alpha@sourceware.org>,
	linux-api@vger.kernel.org, musl@lists.openwall.com,
	Nicholas Piggin <npiggin@gmail.com>,
	libc-dev@lists.llvm.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: Linux powerpc new system call instruction and ABI
Date: Fri, 21 May 2021 23:52:04 +0300	[thread overview]
Message-ID: <20210521205204.GA24309@altlinux.org> (raw)
In-Reply-To: <87eedz3li3.fsf@linux.ibm.com>

On Fri, May 21, 2021 at 05:00:36PM -0300, Matheus Castanho wrote:
> Florian Weimer <fweimer@redhat.com> writes:
> > * Matheus Castanho via Libc-alpha:
> >> From: Nicholas Piggin <npiggin@gmail.com>
> >> Subject: [PATCH 1/1] powerpc: Fix handling of scv return error codes
> >>
> >> When using scv on templated ASM syscalls, current code interprets any
> >> negative return value as error, but the only valid error codes are in
> >> the range -4095..-1 according to the ABI.
> >>
> >> Reviewed-by: Matheus Castanho <msc@linux.ibm.com>
> >
> > Please reference bug 27892 in the commit message.  I'd also appreciate a
> > backport to the 2.33 release branch (where you need to add NEWS manually
> > to add the bug reference).
> 
> No problem. [BZ #27892] appended to the commit title. I'll make sure to
> backport to 2.33 as well.

Could you also mention in the commit message that the change fixes
'signal.gen.test' strace test where it was observed initially?


-- 
ldv

  reply	other threads:[~2021-05-21 20:52 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-11  8:12 Linux powerpc new system call instruction and ABI Nicholas Piggin
2020-06-11  8:12 ` Nicholas Piggin
2020-06-11  8:12 ` [PATCH 1/2] powerpc/64s/exception: treat NIA below __end_interrupts as soft-masked Nicholas Piggin
2020-06-11  8:12   ` Nicholas Piggin
2020-07-24 13:25   ` Michael Ellerman
2020-07-24 13:25     ` Michael Ellerman
2020-06-11  8:12 ` [PATCH 2/2] powerpc/64s: system call support for scv/rfscv instructions Nicholas Piggin
2020-06-11  8:12   ` Nicholas Piggin
2020-07-23  6:47   ` Michael Ellerman
2020-07-23 16:48     ` Christophe Leroy
2020-07-23 16:48       ` Christophe Leroy
2020-07-24 10:45       ` Michael Ellerman
2020-07-24 10:45         ` Michael Ellerman
2020-06-11 21:02 ` Linux powerpc new system call instruction and ABI Segher Boessenkool
2020-06-11 21:02   ` Segher Boessenkool
2020-06-14  9:26   ` Nicholas Piggin
2020-06-14  9:26     ` Nicholas Piggin
2021-05-18 23:13 ` Dmitry V. Levin
2021-05-18 23:13   ` Dmitry V. Levin
2021-05-19  2:50   ` Nicholas Piggin
2021-05-19  2:50     ` Nicholas Piggin
2021-05-19  5:01     ` Nicholas Piggin
2021-05-19  5:01       ` Nicholas Piggin
2021-05-21 19:40       ` Matheus Castanho
2021-05-21 19:40         ` Matheus Castanho
2021-05-21 19:52         ` Florian Weimer
2021-05-21 19:52           ` Florian Weimer
2021-05-21 20:00           ` Matheus Castanho
2021-05-21 20:00             ` Matheus Castanho
2021-05-21 20:52             ` Dmitry V. Levin [this message]
2021-05-21 20:52               ` Dmitry V. Levin
2021-05-24 12:11               ` Matheus Castanho
2021-05-24 12:11                 ` Matheus Castanho
2021-05-24 20:33                 ` Matheus Castanho
2021-05-24 20:33                   ` Matheus Castanho
2021-05-19 10:24     ` Dmitry V. Levin
2021-05-19 10:24       ` Dmitry V. Levin
2021-05-19 10:59       ` Nicholas Piggin
2021-05-19 10:59         ` Nicholas Piggin
2021-05-19 12:39         ` Tulio Magno Quites Machado Filho
2021-05-19 12:39           ` Tulio Magno Quites Machado Filho
2021-05-19 13:26         ` Dmitry V. Levin
2021-05-19 13:26           ` Dmitry V. Levin
2021-05-19 22:51           ` Nicholas Piggin
2021-05-19 22:51             ` Nicholas Piggin
2021-05-19 23:27             ` Dmitry V. Levin
2021-05-19 23:27               ` Dmitry V. Levin
2021-05-20  2:40               ` Nicholas Piggin
2021-05-20  2:40                 ` Nicholas Piggin
2021-05-20  3:06                 ` Dmitry V. Levin
2021-05-20  3:06                   ` Dmitry V. Levin
2021-05-20  5:12                   ` Nicholas Piggin
2021-05-20  5:12                     ` Nicholas Piggin
2021-05-19  7:33   ` Joakim Tjernlund
2021-05-19  7:33     ` Joakim Tjernlund
2021-05-19  7:55     ` Nicholas Piggin
2021-05-19  7:55       ` Nicholas Piggin
2021-05-19  8:08       ` Joakim Tjernlund
2021-05-19  8:08         ` Joakim Tjernlund
2021-05-19  8:42         ` Nicholas Piggin
2021-05-19  8:42           ` Nicholas Piggin
2021-05-19 11:12           ` Nicholas Piggin
2021-05-19 11:12             ` Nicholas Piggin
2021-05-19 14:38           ` Segher Boessenkool
2021-05-19 14:38             ` Segher Boessenkool
2021-05-19 15:06             ` Joakim Tjernlund
2021-05-19 15:06               ` Joakim Tjernlund
2021-05-19 15:22               ` Segher Boessenkool
2021-05-19 15:22                 ` Segher Boessenkool
2021-05-19 15:36                 ` [musl] " Rich Felker
2021-05-19 15:36                   ` Rich Felker
2021-05-19 18:09                 ` Joakim Tjernlund
2021-05-19 18:09                   ` Joakim Tjernlund
2021-05-19 23:48                   ` [musl] " Rich Felker
2021-05-19 23:48                     ` Rich Felker
2021-05-20  1:06                     ` Dmitry V. Levin
2021-05-20  1:06                       ` Dmitry V. Levin
2021-05-20  2:45                       ` Nicholas Piggin
2021-05-20  2:45                         ` Nicholas Piggin
2021-05-20  2:59                         ` Dmitry V. Levin
2021-05-20  2:59                           ` Dmitry V. Levin
2021-05-20  7:20                           ` Nicholas Piggin
2021-05-20  7:20                             ` Nicholas Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210521205204.GA24309@altlinux.org \
    --to=ldv@altlinux.org \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=libc-dev@lists.llvm.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=msc@linux.ibm.com \
    --cc=musl@lists.openwall.com \
    --cc=npiggin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.